From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932800AbcDHQu5 (ORCPT ); Fri, 8 Apr 2016 12:50:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42730 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932574AbcDHQux (ORCPT ); Fri, 8 Apr 2016 12:50:53 -0400 Date: Fri, 8 Apr 2016 09:50:51 -0700 From: Greg KH To: Rui Salvaterra Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com, eunb.song@samsung.com, minchan@kernel.org, chanho.min@lge.com, kyungsik.lee@lge.com, stable@vger.kernel.org Subject: Re: [PATCH] lib: lz4: fixed zram with lz4 on big endian machines Message-ID: <20160408165051.GB16346@kroah.com> References: <1460129004-2011-1-git-send-email-rsalvaterra@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460129004-2011-1-git-send-email-rsalvaterra@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 08, 2016 at 04:23:24PM +0100, Rui Salvaterra wrote: > Based on Sergey's test patch [1], this fixes zram with lz4 compression on big endian cpus. Tested on ppc64 with no regression on x86_64. Please wrap your text at 72 columns in a changelog comment. > > [1] http://marc.info/?l=linux-kernel&m=145994470805853&w=4 > > Cc: stable@vger.kernel.org > Signed-off-by: Rui Salvaterra Please attribute Sergey here in the signed-off-by area with a "Suggested-by:" type mark > --- > lib/lz4/lz4defs.h | 29 +++++++++++++++-------------- > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h > index abcecdc..a98c08c 100644 > --- a/lib/lz4/lz4defs.h > +++ b/lib/lz4/lz4defs.h > @@ -11,8 +11,7 @@ > /* > * Detects 64 bits mode > */ > -#if (defined(__x86_64__) || defined(__x86_64) || defined(__amd64__) \ > - || defined(__ppc64__) || defined(__LP64__)) > +#if defined(CONFIG_64BIT) This patch seems to do two different things, clean up the #if tests, and change the endian of some calls. Can you break this up into 2 different patches? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 8 Apr 2016 09:50:51 -0700 From: Greg KH To: Rui Salvaterra Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com, eunb.song@samsung.com, minchan@kernel.org, chanho.min@lge.com, kyungsik.lee@lge.com, stable@vger.kernel.org Subject: Re: [PATCH] lib: lz4: fixed zram with lz4 on big endian machines Message-ID: <20160408165051.GB16346@kroah.com> References: <1460129004-2011-1-git-send-email-rsalvaterra@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460129004-2011-1-git-send-email-rsalvaterra@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: On Fri, Apr 08, 2016 at 04:23:24PM +0100, Rui Salvaterra wrote: > Based on Sergey's test patch [1], this fixes zram with lz4 compression on big endian cpus. Tested on ppc64 with no regression on x86_64. Please wrap your text at 72 columns in a changelog comment. > > [1] http://marc.info/?l=linux-kernel&m=145994470805853&w=4 > > Cc: stable@vger.kernel.org > Signed-off-by: Rui Salvaterra Please attribute Sergey here in the signed-off-by area with a "Suggested-by:" type mark > --- > lib/lz4/lz4defs.h | 29 +++++++++++++++-------------- > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h > index abcecdc..a98c08c 100644 > --- a/lib/lz4/lz4defs.h > +++ b/lib/lz4/lz4defs.h > @@ -11,8 +11,7 @@ > /* > * Detects 64 bits mode > */ > -#if (defined(__x86_64__) || defined(__x86_64) || defined(__amd64__) \ > - || defined(__ppc64__) || defined(__LP64__)) > +#if defined(CONFIG_64BIT) This patch seems to do two different things, clean up the #if tests, and change the endian of some calls. Can you break this up into 2 different patches? thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org