* [U-Boot] [PATCH] USB: g_dnl: Change device class
@ 2016-04-07 23:49 John Tobias
2016-04-08 9:19 ` Lukasz Majewski
2016-04-11 11:21 ` Lukasz Majewski
0 siblings, 2 replies; 5+ messages in thread
From: John Tobias @ 2016-04-07 23:49 UTC (permalink / raw)
To: u-boot
The USB Mass Storage (ums) works in Windows, Linux and OS X (EL Capitan).
But, not in OS X (Yosemite). By applying the said patch, it extends
the ums support.
Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
---
drivers/usb/gadget/g_dnl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
index 2fa6da4..bd3aad9 100644
--- a/drivers/usb/gadget/g_dnl.c
+++ b/drivers/usb/gadget/g_dnl.c
@@ -58,8 +58,8 @@ static struct usb_device_descriptor device_desc = {
.bDescriptorType = USB_DT_DEVICE,
.bcdUSB = __constant_cpu_to_le16(0x0200),
- .bDeviceClass = USB_CLASS_COMM,
- .bDeviceSubClass = 0x02, /*0x02:CDC-modem , 0x00:CDC-serial*/
+ .bDeviceClass = USB_CLASS_PER_INTERFACE,
+ .bDeviceSubClass = 0, /*0x02:CDC-modem , 0x00:CDC-serial*/
.idVendor = __constant_cpu_to_le16(CONFIG_G_DNL_VENDOR_NUM),
.idProduct = __constant_cpu_to_le16(CONFIG_G_DNL_PRODUCT_NUM),
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] USB: g_dnl: Change device class
2016-04-07 23:49 [U-Boot] [PATCH] USB: g_dnl: Change device class John Tobias
@ 2016-04-08 9:19 ` Lukasz Majewski
2016-04-08 15:41 ` John Tobias
2016-04-11 11:21 ` Lukasz Majewski
1 sibling, 1 reply; 5+ messages in thread
From: Lukasz Majewski @ 2016-04-08 9:19 UTC (permalink / raw)
To: u-boot
Hi John,
> The USB Mass Storage (ums) works in Windows, Linux and OS X (EL
> Capitan). But, not in OS X (Yosemite). By applying the said patch, it
> extends the ums support.
>
> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> ---
> drivers/usb/gadget/g_dnl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
> index 2fa6da4..bd3aad9 100644
> --- a/drivers/usb/gadget/g_dnl.c
> +++ b/drivers/usb/gadget/g_dnl.c
> @@ -58,8 +58,8 @@ static struct usb_device_descriptor device_desc = {
> .bDescriptorType = USB_DT_DEVICE,
>
> .bcdUSB = __constant_cpu_to_le16(0x0200),
> - .bDeviceClass = USB_CLASS_COMM,
> - .bDeviceSubClass = 0x02, /*0x02:CDC-modem , 0x00:CDC-serial*/
> + .bDeviceClass = USB_CLASS_PER_INTERFACE,
> + .bDeviceSubClass = 0, /*0x02:CDC-modem , 0x00:CDC-serial*/
Have you tested if this patch is not introducing any regression on
Linux and Windows?
>
> .idVendor = __constant_cpu_to_le16(CONFIG_G_DNL_VENDOR_NUM),
> .idProduct =
> __constant_cpu_to_le16(CONFIG_G_DNL_PRODUCT_NUM),
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] USB: g_dnl: Change device class
2016-04-08 9:19 ` Lukasz Majewski
@ 2016-04-08 15:41 ` John Tobias
2016-04-08 20:12 ` Lukasz Majewski
0 siblings, 1 reply; 5+ messages in thread
From: John Tobias @ 2016-04-08 15:41 UTC (permalink / raw)
To: u-boot
Hi Lukas,
On Fri, Apr 8, 2016 at 2:19 AM, Lukasz Majewski <l.majewski@samsung.com>
wrote:
> Hi John,
>
> > The USB Mass Storage (ums) works in Windows, Linux and OS X (EL
> > Capitan). But, not in OS X (Yosemite). By applying the said patch, it
> > extends the ums support.
> >
> > Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> > ---
> > drivers/usb/gadget/g_dnl.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
> > index 2fa6da4..bd3aad9 100644
> > --- a/drivers/usb/gadget/g_dnl.c
> > +++ b/drivers/usb/gadget/g_dnl.c
> > @@ -58,8 +58,8 @@ static struct usb_device_descriptor device_desc = {
> > .bDescriptorType = USB_DT_DEVICE,
> >
> > .bcdUSB = __constant_cpu_to_le16(0x0200),
> > - .bDeviceClass = USB_CLASS_COMM,
> > - .bDeviceSubClass = 0x02, /*0x02:CDC-modem , 0x00:CDC-serial*/
> > + .bDeviceClass = USB_CLASS_PER_INTERFACE,
> > + .bDeviceSubClass = 0, /*0x02:CDC-modem , 0x00:CDC-serial*/
>
> Have you tested if this patch is not introducing any regression on
> Linux and Windows?
>
The test what I did is like this:
Linux:
- Run ums to expose all my eMMC partition - shows all correctly
- Run ums to expose only 1 partition of my eMMC - show correctly
Windows:
- Run ums to expose all my eMMC partition - it detects but it prompts,
if I want to format it (due to a non windows partition)
- Run ums to expose only the FAT32 partition - it show the partition
correctly.
Note: I have a patch to expose only 1 partition:
e.g: ums 0 mmc 1:8
>
> >
> > .idVendor = __constant_cpu_to_le16(CONFIG_G_DNL_VENDOR_NUM),
> > .idProduct =
> > __constant_cpu_to_le16(CONFIG_G_DNL_PRODUCT_NUM),
>
>
>
> --
> Best regards,
>
> Lukasz Majewski
>
> Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
>
Regards,
John
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] USB: g_dnl: Change device class
2016-04-08 15:41 ` John Tobias
@ 2016-04-08 20:12 ` Lukasz Majewski
0 siblings, 0 replies; 5+ messages in thread
From: Lukasz Majewski @ 2016-04-08 20:12 UTC (permalink / raw)
To: u-boot
On Fri, 8 Apr 2016 08:41:14 -0700
John Tobias <john.tobias.ph@gmail.com> wrote:
> Hi Lukas,
>
>
> On Fri, Apr 8, 2016 at 2:19 AM, Lukasz Majewski
> <l.majewski@samsung.com> wrote:
>
> > Hi John,
> >
> > > The USB Mass Storage (ums) works in Windows, Linux and OS X (EL
> > > Capitan). But, not in OS X (Yosemite). By applying the said
> > > patch, it extends the ums support.
> > >
> > > Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> > > ---
> > > drivers/usb/gadget/g_dnl.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/g_dnl.c
> > > b/drivers/usb/gadget/g_dnl.c index 2fa6da4..bd3aad9 100644
> > > --- a/drivers/usb/gadget/g_dnl.c
> > > +++ b/drivers/usb/gadget/g_dnl.c
> > > @@ -58,8 +58,8 @@ static struct usb_device_descriptor device_desc
> > > = { .bDescriptorType = USB_DT_DEVICE,
> > >
> > > .bcdUSB = __constant_cpu_to_le16(0x0200),
> > > - .bDeviceClass = USB_CLASS_COMM,
> > > - .bDeviceSubClass = 0x02, /*0x02:CDC-modem ,
> > > 0x00:CDC-serial*/
> > > + .bDeviceClass = USB_CLASS_PER_INTERFACE,
> > > + .bDeviceSubClass = 0, /*0x02:CDC-modem , 0x00:CDC-serial*/
> >
> > Have you tested if this patch is not introducing any regression on
> > Linux and Windows?
> >
>
> The test what I did is like this:
>
> Linux:
> - Run ums to expose all my eMMC partition - shows all correctly
> - Run ums to expose only 1 partition of my eMMC - show correctly
>
> Windows:
> - Run ums to expose all my eMMC partition - it detects but it
> prompts, if I want to format it (due to a non windows partition)
> - Run ums to expose only the FAT32 partition - it show the
> partition correctly.
>
Ok, I see. Thanks for your effort on testing. I do appreciate it.
>
> Note: I have a patch to expose only 1 partition:
> e.g: ums 0 mmc 1:8
Yes, I've just received it. I will provide feedback shortly.
>
>
> >
> > >
> > > .idVendor = __constant_cpu_to_le16(CONFIG_G_DNL_VENDOR_NUM),
> > > .idProduct =
> > > __constant_cpu_to_le16(CONFIG_G_DNL_PRODUCT_NUM),
> >
> >
> >
> > --
> > Best regards,
> >
> > Lukasz Majewski
> >
> > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
> >
>
> Regards,
>
> John
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160408/ab9e0bea/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] USB: g_dnl: Change device class
2016-04-07 23:49 [U-Boot] [PATCH] USB: g_dnl: Change device class John Tobias
2016-04-08 9:19 ` Lukasz Majewski
@ 2016-04-11 11:21 ` Lukasz Majewski
1 sibling, 0 replies; 5+ messages in thread
From: Lukasz Majewski @ 2016-04-11 11:21 UTC (permalink / raw)
To: u-boot
Hi John,
> The USB Mass Storage (ums) works in Windows, Linux and OS X (EL
> Capitan). But, not in OS X (Yosemite). By applying the said patch, it
> extends the ums support.
>
> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
Test HW: Odroid XU3 with test/py for UMS, DFU
Applied to u-boot-dfu branch
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-11 11:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-07 23:49 [U-Boot] [PATCH] USB: g_dnl: Change device class John Tobias
2016-04-08 9:19 ` Lukasz Majewski
2016-04-08 15:41 ` John Tobias
2016-04-08 20:12 ` Lukasz Majewski
2016-04-11 11:21 ` Lukasz Majewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.