From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH 10/15] irqchip/gic: Remove static irq_chip definition for eoimode1 Date: Sat, 9 Apr 2016 12:38:25 +0100 Message-ID: <20160409123825.3550eb16@arm.com> References: <1458224359-32665-1-git-send-email-jonathanh@nvidia.com> <1458224359-32665-11-git-send-email-jonathanh@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1458224359-32665-11-git-send-email-jonathanh@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: Jon Hunter Cc: Thomas Gleixner , Jason Cooper , =?ISO-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Stephen Warren , Thierry Reding , Kevin Hilman , Geert Uytterhoeven , Grygorii Strashko , Lars-Peter Clausen , Linus Walleij , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On Thu, 17 Mar 2016 14:19:14 +0000 Jon Hunter wrote: > There are only 3 differences (not including the name) in the definitions > of the gic_chip and gic_eoimode1_chip structures. Instead of statically > defining the gic_eoimode1_chip structure, remove it and populate the > eoimode1 functions dynamically for the appropriate GIC irqchips. > > Signed-off-by: Jon Hunter Linus' remark notwithstanding, Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.