From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [198.137.202.9] ([198.137.202.9]:34294 "EHLO bombadil.infradead.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753428AbcDJRQT (ORCPT ); Sun, 10 Apr 2016 13:16:19 -0400 Date: Sun, 10 Apr 2016 10:15:28 -0700 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , Bob Peterson , linux-fsdevel@vger.kernel.org, Jan Kara , Al Viro Subject: Re: [vfs PATCH v3 1/4] VFS: move iomap from exportfs.h to iomap.h Message-ID: <20160410171528.GA9118@infradead.org> References: <1457122300-28514-1-git-send-email-rpeterso@redhat.com> <1457122300-28514-2-git-send-email-rpeterso@redhat.com> <20160315072912.GE11669@infradead.org> <690524895.44280573.1459194784327.JavaMail.zimbra@redhat.com> <20160329074026.GD8568@infradead.org> <20160329222036.GD30721@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160329222036.GD30721@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Mar 30, 2016 at 09:20:36AM +1100, Dave Chinner wrote: > QA over the past couple of days has indicatedno regressions, so I'm > going to seriously consider the multipage write code for the next > XFS merge. I'd be happy to also take fiemap code based on the same > iomap interfaces, especially if we can make it a generic, fully > functional fiemap implementation and use it in XFS, too. Now that's I've spent some more time with it: it depend on your idea of fully functional. For the actual file data the fiemap implementation is simple and beautiful. But XFS also supports the odd FIEMAP_FLAG_XATTR flags, which makes no sense at all for an fiemap based implementation.