From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755690AbcDLCuZ (ORCPT ); Mon, 11 Apr 2016 22:50:25 -0400 Received: from mail.kernel.org ([198.145.29.136]:32788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753166AbcDLCuX (ORCPT ); Mon, 11 Apr 2016 22:50:23 -0400 Date: Tue, 12 Apr 2016 10:49:47 +0800 From: Shawn Guo To: Yuan Yao Cc: robh+dt@kernel.org, mark.rutland@arm.com, computersforpeace@gmail.com, pawel.moll@arm.com, han.xu@nxp.com, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Yuan Yao Subject: Re: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support Message-ID: <20160412024947.GD15949@tiger> References: <1459406701-40993-1-git-send-email-yao.yuan@freescale.com> <1459406701-40993-3-git-send-email-yao.yuan@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459406701-40993-3-git-send-email-yao.yuan@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2016 at 02:45:01PM +0800, Yuan Yao wrote: > From: Yuan Yao > > Signed-off-by: Yuan Yao Please style of 'arm64: dts: ls1043a: ' for subject prefix. > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 16 ++++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 14 ++++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > index 97e9906..c8303a3 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > @@ -100,6 +100,22 @@ > }; > }; > > +&qspi { Please sort such labeled node alphabetically in label name. That said, it should go after &lpuart0. > + num-cs = <2>; I do not see this property in bindings doc. > + bus-num = <0>; > + status = "okay"; Please let 'status' line be the last of property list. > + fsl,ddr-sampling-point = <4>; I do not see this one in bindings definition either. > + > + qflash0: s25fl128s@0 { > + compatible = "spansion,m25p80"; > + #address-cells = <1>; > + #size-cells = <1>; > + spi-max-frequency = <20000000>; > + ddr-quad-read; Ditto > + reg = <0>; > + }; > +}; > + > &i2c0 { > status = "okay"; > pca9547@77 { > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > index be72bf5..49b1aeb 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > @@ -208,6 +208,20 @@ > status = "disabled"; > }; > > + qspi: quadspi@1550000 { Please sort the node in .dtsi in order of unit-address. That said, the node should be added between ifc@1530000 and esdhc@1560000. Shawn > + compatible = "fsl,ls1043a-qspi", "fsl,ls1021a-qspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x1550000 0x0 0x10000>, > + <0x0 0x40000000 0x0 0x4000000>; > + reg-names = "QuadSPI", "QuadSPI-memory"; > + interrupts = <0 99 0x4>; > + clock-names = "qspi_en", "qspi"; > + clocks = <&clockgen 4 0>, <&clockgen 4 0>; > + big-endian; > + status = "disabled"; > + }; > + > i2c0: i2c@2180000 { > compatible = "fsl,vf610-i2c"; > #address-cells = <1>; > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support Date: Tue, 12 Apr 2016 10:49:47 +0800 Message-ID: <20160412024947.GD15949@tiger> References: <1459406701-40993-1-git-send-email-yao.yuan@freescale.com> <1459406701-40993-3-git-send-email-yao.yuan@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1459406701-40993-3-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yuan Yao Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, han.xu-3arQi8VN3Tc@public.gmane.org, leoyang.li-3arQi8VN3Tc@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Yuan Yao List-Id: devicetree@vger.kernel.org On Thu, Mar 31, 2016 at 02:45:01PM +0800, Yuan Yao wrote: > From: Yuan Yao > > Signed-off-by: Yuan Yao Please style of 'arm64: dts: ls1043a: ' for subject prefix. > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 16 ++++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 14 ++++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > index 97e9906..c8303a3 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > @@ -100,6 +100,22 @@ > }; > }; > > +&qspi { Please sort such labeled node alphabetically in label name. That said, it should go after &lpuart0. > + num-cs = <2>; I do not see this property in bindings doc. > + bus-num = <0>; > + status = "okay"; Please let 'status' line be the last of property list. > + fsl,ddr-sampling-point = <4>; I do not see this one in bindings definition either. > + > + qflash0: s25fl128s@0 { > + compatible = "spansion,m25p80"; > + #address-cells = <1>; > + #size-cells = <1>; > + spi-max-frequency = <20000000>; > + ddr-quad-read; Ditto > + reg = <0>; > + }; > +}; > + > &i2c0 { > status = "okay"; > pca9547@77 { > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > index be72bf5..49b1aeb 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > @@ -208,6 +208,20 @@ > status = "disabled"; > }; > > + qspi: quadspi@1550000 { Please sort the node in .dtsi in order of unit-address. That said, the node should be added between ifc@1530000 and esdhc@1560000. Shawn > + compatible = "fsl,ls1043a-qspi", "fsl,ls1021a-qspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x1550000 0x0 0x10000>, > + <0x0 0x40000000 0x0 0x4000000>; > + reg-names = "QuadSPI", "QuadSPI-memory"; > + interrupts = <0 99 0x4>; > + clock-names = "qspi_en", "qspi"; > + clocks = <&clockgen 4 0>, <&clockgen 4 0>; > + big-endian; > + status = "disabled"; > + }; > + > i2c0: i2c@2180000 { > compatible = "fsl,vf610-i2c"; > #address-cells = <1>; > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Tue, 12 Apr 2016 10:49:47 +0800 Subject: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support In-Reply-To: <1459406701-40993-3-git-send-email-yao.yuan@freescale.com> References: <1459406701-40993-1-git-send-email-yao.yuan@freescale.com> <1459406701-40993-3-git-send-email-yao.yuan@freescale.com> Message-ID: <20160412024947.GD15949@tiger> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 31, 2016 at 02:45:01PM +0800, Yuan Yao wrote: > From: Yuan Yao > > Signed-off-by: Yuan Yao Please style of 'arm64: dts: ls1043a: ' for subject prefix. > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 16 ++++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 14 ++++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > index 97e9906..c8303a3 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > @@ -100,6 +100,22 @@ > }; > }; > > +&qspi { Please sort such labeled node alphabetically in label name. That said, it should go after &lpuart0. > + num-cs = <2>; I do not see this property in bindings doc. > + bus-num = <0>; > + status = "okay"; Please let 'status' line be the last of property list. > + fsl,ddr-sampling-point = <4>; I do not see this one in bindings definition either. > + > + qflash0: s25fl128s at 0 { > + compatible = "spansion,m25p80"; > + #address-cells = <1>; > + #size-cells = <1>; > + spi-max-frequency = <20000000>; > + ddr-quad-read; Ditto > + reg = <0>; > + }; > +}; > + > &i2c0 { > status = "okay"; > pca9547 at 77 { > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > index be72bf5..49b1aeb 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > @@ -208,6 +208,20 @@ > status = "disabled"; > }; > > + qspi: quadspi at 1550000 { Please sort the node in .dtsi in order of unit-address. That said, the node should be added between ifc at 1530000 and esdhc at 1560000. Shawn > + compatible = "fsl,ls1043a-qspi", "fsl,ls1021a-qspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x1550000 0x0 0x10000>, > + <0x0 0x40000000 0x0 0x4000000>; > + reg-names = "QuadSPI", "QuadSPI-memory"; > + interrupts = <0 99 0x4>; > + clock-names = "qspi_en", "qspi"; > + clocks = <&clockgen 4 0>, <&clockgen 4 0>; > + big-endian; > + status = "disabled"; > + }; > + > i2c0: i2c at 2180000 { > compatible = "fsl,vf610-i2c"; > #address-cells = <1>; > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >