From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use new i915_gem_object_pin_map for LRC
Date: Tue, 12 Apr 2016 10:30:37 +0100 [thread overview]
Message-ID: <20160412093037.GJ20240@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1460451148-18848-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On Tue, Apr 12, 2016 at 09:52:28AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> We can use the new pin/lazy unpin API for simplicity
> and more performance in the execlist submission paths.
>
> v2:
> * Fix error handling and convert more users.
> * Compact some names for readability.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Hmm, the stress tests that would exercise this are already currently
fail (thinking of gem_ctx_create etc). But this should not excerbate it
much!
> - lrc_state_page = i915_gem_object_get_dirty_page(ctx_obj, LRC_STATE_PN);
> - if (WARN_ON(!lrc_state_page)) {
> - ret = -ENODEV;
> + obj_addr = i915_gem_object_pin_map(ctx_obj);
Oops, there's a bug in pin_map in that we don't mark the object as
dirty. Can you send a quick obj->dirty = true patch?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-12 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 8:52 [PATCH] drm/i915: Use new i915_gem_object_pin_map for LRC Tvrtko Ursulin
2016-04-12 9:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-12 9:35 ` Chris Wilson
2016-04-12 9:30 ` Chris Wilson [this message]
2016-04-12 9:36 ` [PATCH] " Tvrtko Ursulin
2016-04-12 9:42 ` Chris Wilson
2016-04-12 9:43 ` Chris Wilson
2016-04-12 10:33 ` Tvrtko Ursulin
2016-04-12 13:05 ` [PATCH v3] " Tvrtko Ursulin
2016-04-12 13:12 ` Chris Wilson
2016-04-12 13:19 ` Tvrtko Ursulin
2016-04-12 13:29 ` Chris Wilson
2016-04-12 14:06 ` ✗ Fi.CI.BAT: failure for drm/i915: Use new i915_gem_object_pin_map for LRC (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412093037.GJ20240@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.