[LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed

From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed
Date: Tue, 12 Apr 2016 12:08:59 +0200	[thread overview]
Message-ID: <20160412100858.GC24915@rei.lan> (raw)
In-Reply-To: <20160412030734.GA11627@localhost.localdomain>

Hi!
> If fork failed, we should try next signum. Or the kill(-1, 9) on line
> 196 will kill a lot of processes.
> 
> Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> ---
>  testcases/kernel/syscalls/ptrace/ptrace05.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/ptrace/ptrace05.c b/testcases/kernel/syscalls/ptrace/ptrace05.c
> index d610cc0..e717319 100644
> --- a/testcases/kernel/syscalls/ptrace/ptrace05.c
> +++ b/testcases/kernel/syscalls/ptrace/ptrace05.c
> @@ -99,7 +99,7 @@ int main(int argc, char **argv)
>  		switch (child = fork()) {
>  		case -1:
>  			tst_resm(TBROK | TERRNO, "Failed to fork properly.");
> -			break;
> +			continue;

I would just change this to tst_brkm(). There is no point in continuing
the test if fork() starts failing.

-- 
Cyril Hrubis
chrubis@suse.cz