From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932598AbcDLJoj (ORCPT ); Tue, 12 Apr 2016 05:44:39 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58825 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932322AbcDLJoh (ORCPT ); Tue, 12 Apr 2016 05:44:37 -0400 Date: Tue, 12 Apr 2016 11:44:33 +0200 From: Boris Brezillon To: Jiancheng Xue Cc: Marek Vasut , Brian Norris , , , , , , , , , , , , , , , , , Russell King - ARM Linux Subject: Re: [RESEND PATCH v9] mtd: spi-nor: add hisilicon spi-nor flash controller driver Message-ID: <20160412114433.069b388e@bbrezillon> In-Reply-To: <570CC098.9070606@huawei.com> References: <1458979861-3619-1-git-send-email-xuejiancheng@huawei.com> <56F73BC9.5000300@gmail.com> <56F8F630.5050008@huawei.com> <20160404064418.GC13995@localhost> <5705C17F.9030904@huawei.com> <5705C5E2.6070206@denx.de> <57076B26.7030700@huawei.com> <5707821F.4020300@denx.de> <570AFDAF.9050607@huawei.com> <570BF933.2000607@denx.de> <570CC098.9070606@huawei.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Russell Hi Jiancheng, On Tue, 12 Apr 2016 17:32:08 +0800 Jiancheng Xue wrote: > Hi Marek, > > On 2016/4/12 3:21, Marek Vasut wrote: > > On 04/11/2016 03:28 AM, Jiancheng Xue wrote: > >> Hi, > >> > >> On 2016/4/8 18:04, Marek Vasut wrote: > >>> On 04/08/2016 10:26 AM, Jiancheng Xue wrote: > >>>> Hi, > >>>> > >>>> On 2016/4/7 10:28, Marek Vasut wrote: > >>>>> On 04/07/2016 04:10 AM, Jiancheng Xue wrote: > >>>>>> Hi Brian, > >>>>>> Thank you very much for your comments. I'll fix these issues in next version. > >>>>>> In addition, for easy understanding I'd like to rewrite hisi_spi_nor_write and > >>>>>> hisi_spi_nor_read. Your comments on these modifications will be highly appreciated. > >>>>> > >>>>> Would you please stop top-posting ? It rubs some people the wrong way. > >>>>> > >>>> I feel very sorry about that. I have read the etiquette and won't make the same mistake again. > >>>> > >>>>>> static int hisi_spi_nor_read(struct spi_nor *nor, loff_t from, size_t len, > >>>>>> size_t *retlen, u_char *read_buf) > >>>>>> { > >>>>>> struct hifmc_priv *priv = nor->priv; > >>>>>> struct hifmc_host *host = priv->host; > >>>>>> int i; > >>>>>> > >>>>>> /* read all bytes in only one time */ > >>>>>> if (len <= HIFMC_DMA_MAX_LEN) { > >>>>>> hisi_spi_nor_dma_transfer(nor, from, host->dma_buffer, > >>>>>> len, FMC_OP_READ); > >>>>>> memcpy(read_buf, host->buffer, len); > >>>>> > >>>>> Is all the ad-hoc memcpying necessary? I think you can use > >>>>> dma_map_single() and co to obtain DMAble memory for your > >>>>> controller's use and then you can probably get rid of most > >>>>> of this stuff. > >>>>> > >>>> Considering read_buf >= high_mem case, I think it is also complicated to use dma_map_* > >>>> and the DMA buffer allocated by the driver is still needed. But I am not sure about > >>>> this. Please let me know if I am wrong. Thank you! > >>> > >>> Does your controller/DMA have a limitation where it's buffers must be in > >>> the bottom 4GiB range ? The DMA framework should be able to take care of > >>> such platform limitations. > >>> > >> When read_buf is allocated by vmalloc, the underlying physical memory may be not contiguous. > >> In this case, dma_map_single can't be used directly. I think inner DMA buffer and memcpy are still > >> needed. Am I right? > > > > Take a look at drivers/spi/spi-mxs.c , look for "vmalloc" , does that > > solution help you in any way ? > > > No. I think this solution just processes the buffer within only one page. > I had referred to drivers/mtd/onenand/samsung.c and other files. > The corresponding code segment is as follows: > static int s5pc110_read_bufferram(struct mtd_info *mtd, int area, > unsigned char *buffer, int offset, size_t count) > { > void *buf = (void *) buffer; > dma_addr_t dma_src, dma_dst; > ... > /* Handle vmalloc address */ > if (buf >= high_memory) { > struct page *page; > > if (((size_t) buf & PAGE_MASK) != > ((size_t) (buf + count - 1) & PAGE_MASK)) > goto normal; > page = vmalloc_to_page(buf); > if (!page) > goto normal; > > ... > } else { > ... > } > > normal: > ... > memcpy(buffer, p, count); > > return 0; > } > I think memcpy in "normal" clause can't be removed. So I'd like to keep my original > implementation if it is also OK. What's your opinion? You might want to have a look at this series [1], and particularly at Russell's answers regarding DMA operations on non-lowmem memory. Best Regards, Boris [1]http://thread.gmane.org/gmane.linux.kernel.mm/149015 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [RESEND PATCH v9] mtd: spi-nor: add hisilicon spi-nor flash controller driver Date: Tue, 12 Apr 2016 11:44:33 +0200 Message-ID: <20160412114433.069b388e@bbrezillon> References: <1458979861-3619-1-git-send-email-xuejiancheng@huawei.com> <56F73BC9.5000300@gmail.com> <56F8F630.5050008@huawei.com> <20160404064418.GC13995@localhost> <5705C17F.9030904@huawei.com> <5705C5E2.6070206@denx.de> <57076B26.7030700@huawei.com> <5707821F.4020300@denx.de> <570AFDAF.9050607@huawei.com> <570BF933.2000607@denx.de> <570CC098.9070606@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <570CC098.9070606-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jiancheng Xue Cc: Marek Vasut , Brian Norris , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org, furquan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, suwenping-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yanhaifeng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, raojun-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, xuejiancheng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, ml.yang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, gaofei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, yanghongwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, zhangzhenxing-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, jalen.hsu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, Russell King - ARM Linux List-Id: devicetree@vger.kernel.org +Russell Hi Jiancheng, On Tue, 12 Apr 2016 17:32:08 +0800 Jiancheng Xue wrote: > Hi Marek, > > On 2016/4/12 3:21, Marek Vasut wrote: > > On 04/11/2016 03:28 AM, Jiancheng Xue wrote: > >> Hi, > >> > >> On 2016/4/8 18:04, Marek Vasut wrote: > >>> On 04/08/2016 10:26 AM, Jiancheng Xue wrote: > >>>> Hi, > >>>> > >>>> On 2016/4/7 10:28, Marek Vasut wrote: > >>>>> On 04/07/2016 04:10 AM, Jiancheng Xue wrote: > >>>>>> Hi Brian, > >>>>>> Thank you very much for your comments. I'll fix these issues in next version. > >>>>>> In addition, for easy understanding I'd like to rewrite hisi_spi_nor_write and > >>>>>> hisi_spi_nor_read. Your comments on these modifications will be highly appreciated. > >>>>> > >>>>> Would you please stop top-posting ? It rubs some people the wrong way. > >>>>> > >>>> I feel very sorry about that. I have read the etiquette and won't make the same mistake again. > >>>> > >>>>>> static int hisi_spi_nor_read(struct spi_nor *nor, loff_t from, size_t len, > >>>>>> size_t *retlen, u_char *read_buf) > >>>>>> { > >>>>>> struct hifmc_priv *priv = nor->priv; > >>>>>> struct hifmc_host *host = priv->host; > >>>>>> int i; > >>>>>> > >>>>>> /* read all bytes in only one time */ > >>>>>> if (len <= HIFMC_DMA_MAX_LEN) { > >>>>>> hisi_spi_nor_dma_transfer(nor, from, host->dma_buffer, > >>>>>> len, FMC_OP_READ); > >>>>>> memcpy(read_buf, host->buffer, len); > >>>>> > >>>>> Is all the ad-hoc memcpying necessary? I think you can use > >>>>> dma_map_single() and co to obtain DMAble memory for your > >>>>> controller's use and then you can probably get rid of most > >>>>> of this stuff. > >>>>> > >>>> Considering read_buf >= high_mem case, I think it is also complicated to use dma_map_* > >>>> and the DMA buffer allocated by the driver is still needed. But I am not sure about > >>>> this. Please let me know if I am wrong. Thank you! > >>> > >>> Does your controller/DMA have a limitation where it's buffers must be in > >>> the bottom 4GiB range ? The DMA framework should be able to take care of > >>> such platform limitations. > >>> > >> When read_buf is allocated by vmalloc, the underlying physical memory may be not contiguous. > >> In this case, dma_map_single can't be used directly. I think inner DMA buffer and memcpy are still > >> needed. Am I right? > > > > Take a look at drivers/spi/spi-mxs.c , look for "vmalloc" , does that > > solution help you in any way ? > > > No. I think this solution just processes the buffer within only one page. > I had referred to drivers/mtd/onenand/samsung.c and other files. > The corresponding code segment is as follows: > static int s5pc110_read_bufferram(struct mtd_info *mtd, int area, > unsigned char *buffer, int offset, size_t count) > { > void *buf = (void *) buffer; > dma_addr_t dma_src, dma_dst; > ... > /* Handle vmalloc address */ > if (buf >= high_memory) { > struct page *page; > > if (((size_t) buf & PAGE_MASK) != > ((size_t) (buf + count - 1) & PAGE_MASK)) > goto normal; > page = vmalloc_to_page(buf); > if (!page) > goto normal; > > ... > } else { > ... > } > > normal: > ... > memcpy(buffer, p, count); > > return 0; > } > I think memcpy in "normal" clause can't be removed. So I'd like to keep my original > implementation if it is also OK. What's your opinion? You might want to have a look at this series [1], and particularly at Russell's answers regarding DMA operations on non-lowmem memory. Best Regards, Boris [1]http://thread.gmane.org/gmane.linux.kernel.mm/149015 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html