From: Thomas Graf <tgraf@suug.ch>
To: roopa <roopa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, davem@davemloft.net,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats
Date: Tue, 12 Apr 2016 15:21:51 +0200 [thread overview]
Message-ID: <20160412132151.GA16560@pox.localdomain> (raw)
In-Reply-To: <570C7133.8070109@cumulusnetworks.com>
On 04/11/16 at 08:53pm, roopa wrote:
> Top level stats attributes can be netdev or global attributes: We can include string "LINK" in
> the names of all stats belonging to a netdev to make it easier to recognize the netdev stats (example):
> IFLA_STATS_LINK64, (netdev)
> IFLA_STATS_LINK_INET6, (netdev)
> IFLA_STATS_TCP, (non-netdev, global tcp stats)
This is fine as well. It means that we cant mix netdev and non-netdev
stats or stats for multiple netdevs in the same request which would
not be the case if you nest it and have a top level attribute which
is a list of requests. That may be borderline to overengineering
though so I'm fine this as well.
> We will need a field in netlink_callback to indicate global or netdev stats when the stats
> crosses skb boundaries. A single nlmsg cannot have both netdev and global stats.
I would treat each IFLA_STATS_ as its own nlmsg in the reply and
enforce an NLM_F_DUMP request for any multi request message.
next prev parent reply other threads:[~2016-04-12 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 6:38 [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-09 14:30 ` Jamal Hadi Salim
2016-04-09 18:00 ` roopa
2016-04-10 13:48 ` Jamal Hadi Salim
2016-04-10 19:17 ` roopa
2016-04-10 8:16 ` Thomas Graf
2016-04-10 18:28 ` roopa
2016-04-12 3:53 ` roopa
2016-04-12 13:21 ` Thomas Graf [this message]
2016-04-13 12:11 ` Jamal Hadi Salim
2016-04-14 6:36 ` roopa
2016-04-14 4:19 ` David Miller
2016-04-14 6:35 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412132151.GA16560@pox.localdomain \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.