From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933999AbcDLOEA (ORCPT ); Tue, 12 Apr 2016 10:04:00 -0400 Received: from mail.kernel.org ([198.145.29.136]:44379 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933954AbcDLODw (ORCPT ); Tue, 12 Apr 2016 10:03:52 -0400 Date: Tue, 12 Apr 2016 09:03:38 -0500 From: Rob Herring To: Nava kishore Manne Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, balbi@ti.com, gregkh@linuxfoundation.org, hyun.kwon@xilinx.com, navam@xilinx.com, radhey.shyam.pandey@xilinx.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Axi-usb: Add support for 64-bit addressing. Message-ID: <20160412140338.GA19311@rob-hp-laptop> References: <1460360506-14692-1-git-send-email-navam@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460360506-14692-1-git-send-email-navam@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2016 at 01:11:46PM +0530, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA > addressing. > > Signed-off-by: Nava kishore Manne > --- > .../devicetree/bindings/usb/udc-xilinx.txt | 3 +- > drivers/usb/gadget/udc/udc-xilinx.c | 38 ++++++++++++++++++++-- > 2 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt b/Documentation/devicetree/bindings/usb/udc-xilinx.txt > index 47b4e39..d417872 100644 > --- a/Documentation/devicetree/bindings/usb/udc-xilinx.txt > +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt > @@ -7,12 +7,13 @@ Required properties: > - interrupts : Should contain single irq line of USB2 device > controller > - xlnx,has-builtin-dma : if DMA is included > - > +- xlnx,addrwidth : Should be the dma addressing size in bits(ex: 40 bits). Now this property shows up in a 2nd device. Now I'm more convinced this is the wrong approach and should use dma-ranges. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Tue, 12 Apr 2016 09:03:38 -0500 Subject: [PATCH] Axi-usb: Add support for 64-bit addressing. In-Reply-To: <1460360506-14692-1-git-send-email-navam@xilinx.com> References: <1460360506-14692-1-git-send-email-navam@xilinx.com> Message-ID: <20160412140338.GA19311@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 11, 2016 at 01:11:46PM +0530, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA > addressing. > > Signed-off-by: Nava kishore Manne > --- > .../devicetree/bindings/usb/udc-xilinx.txt | 3 +- > drivers/usb/gadget/udc/udc-xilinx.c | 38 ++++++++++++++++++++-- > 2 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt b/Documentation/devicetree/bindings/usb/udc-xilinx.txt > index 47b4e39..d417872 100644 > --- a/Documentation/devicetree/bindings/usb/udc-xilinx.txt > +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt > @@ -7,12 +7,13 @@ Required properties: > - interrupts : Should contain single irq line of USB2 device > controller > - xlnx,has-builtin-dma : if DMA is included > - > +- xlnx,addrwidth : Should be the dma addressing size in bits(ex: 40 bits). Now this property shows up in a 2nd device. Now I'm more convinced this is the wrong approach and should use dma-ranges. Rob