From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sf: fix timebase data type in _wait_ready()
Date: Tue, 12 Apr 2016 12:03:29 -0400 [thread overview]
Message-ID: <20160412160329.GB13577@bill-the-cat> (raw)
In-Reply-To: <570D1787.2070904@wwwdotorg.org>
On Tue, Apr 12, 2016 at 09:43:03AM -0600, Stephen Warren wrote:
> On 04/06/2016 05:22 AM, Jagan Teki wrote:
> >On 5 April 2016 at 05:31, Tom Rini <trini@konsulko.com> wrote:
> >>On Mon, Apr 04, 2016 at 11:03:52AM -0600, Stephen Warren wrote:
> >>
> >>>From: Stephen Warren <swarren@nvidia.com>
> >>>
> >>>get_timer() returns an unsigned 64-bit value, but is currently assigned to
> >>>a signed 32-bit variable. Due to sign extension and data truncation, this
> >>>causes the timeout loop in spi_flash_cmd_wait_ready() to immediately (and
> >>>incorrectly) fire for about 50% of all time values, based on whether bit
> >>>31 is set. In sandbox at least, this causes the test to pass or fail based
> >>>on system uptime, as opposed to time since the U-Boot binary was started.
> >>>
> >>>Fixes: 4efad20a1751 ("sf: Update status reg check in spi_flash_cmd_wait_ready")
> >>>Signed-off-by: Stephen Warren <swarren@nvidia.com>
> >>
> >>Reviewed-by: Tom Rini <trini@konsulko.com>
> >
> >Reviewed-by: Jagan Teki <jteki@openedev.com>
>
> It'd be great if this could be applied to fix the final test/py
> failure on sandbox.
Yes, please, lets get some PRs with fixes in now :) Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160412/e256fec9/attachment.sig>
next prev parent reply other threads:[~2016-04-12 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 17:03 [U-Boot] [PATCH] sf: fix timebase data type in _wait_ready() Stephen Warren
2016-04-05 0:01 ` Tom Rini
2016-04-06 11:22 ` Jagan Teki
2016-04-12 15:43 ` Stephen Warren
2016-04-12 16:03 ` Tom Rini [this message]
2016-04-21 5:49 ` Stephen Warren
2016-04-25 16:44 ` Stephen Warren
2016-04-25 16:46 ` Tom Rini
2016-04-26 0:16 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412160329.GB13577@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.