From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Bob Peterson <rpeterso@redhat.com>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [vfs PATCH v3 1/4] VFS: move iomap from exportfs.h to iomap.h
Date: Tue, 12 Apr 2016 11:29:40 -0700 [thread overview]
Message-ID: <20160412182940.GA9125@infradead.org> (raw)
In-Reply-To: <20160411061740.GH567@dastard>
On Mon, Apr 11, 2016 at 04:17:40PM +1000, Dave Chinner wrote:
> In this case, I'd let xfs_vn_fiemap handle that. i.e. if the
> FIEMAP_FLAG_XATTR is set, run the old code, otherwise call straight
> into the new generic iomap based code.
>
> I'm not sure if how your new code is structured, but n this version
> __generic_iomap_fiemap() is passed an iomap_get_t callback function.
> We could simply have XFS pass a different callback function that
> looks up the attribute fork extent list rather than the data fork
> extent list to support FIEMAP_FLAG_XATTR appropriately because other
> than the different initial extent list root it seems to me like the
> implementation should be identical....
Providing iomap_ops for the xattr flag look feasily, but currently
there is no real testing for it. Only fsstress will call into it
at all and doesn't even verify the output. I'll send the iomap
implementation and XFS support as RFC, and then you can decide what
to do with it.
next prev parent reply other threads:[~2016-04-12 18:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 20:11 [vfs PATCH v3 0/4] vfs: Expand iomap interface to fiemap Bob Peterson
2016-03-04 20:11 ` [vfs PATCH v3 1/4] VFS: move iomap from exportfs.h to iomap.h Bob Peterson
2016-03-15 7:29 ` Christoph Hellwig
2016-03-28 19:53 ` Bob Peterson
2016-03-29 7:40 ` Christoph Hellwig
2016-03-29 22:20 ` Dave Chinner
2016-03-30 6:47 ` Christoph Hellwig
2016-04-07 19:58 ` Bob Peterson
2016-04-07 20:42 ` Christoph Hellwig
2016-04-10 17:15 ` Christoph Hellwig
2016-04-11 6:17 ` Dave Chinner
2016-04-12 18:29 ` Christoph Hellwig [this message]
2016-04-13 0:22 ` Dave Chinner
2016-03-04 20:11 ` [vfs PATCH v3 2/4] VFS: Add new __generic_iomap_fiemap interface Bob Peterson
2016-03-07 10:18 ` Jan Kara
2016-03-15 7:33 ` Christoph Hellwig
2016-03-04 20:11 ` [vfs PATCH v3 3/4] GFS2: Add function gfs2_get_iomap Bob Peterson
2016-03-04 20:11 ` [vfs PATCH v3 4/4] GFS2: Use new iomap interface for fiemap Bob Peterson
2016-03-15 7:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412182940.GA9125@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.