From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937AbcDLUBZ (ORCPT ); Tue, 12 Apr 2016 16:01:25 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36832 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756513AbcDLUBX (ORCPT ); Tue, 12 Apr 2016 16:01:23 -0400 Date: Tue, 12 Apr 2016 21:01:19 +0100 From: Matt Fleming To: Ard Biesheuvel Cc: "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Tony Luck , "Luck, Tony" Subject: Re: [PATCH 2/2] efi: Remove global 'memmap' Message-ID: <20160412200119.GH2829@codeblueprint.co.uk> References: <1460379809-18490-1-git-send-email-matt@codeblueprint.co.uk> <1460379809-18490-3-git-send-email-matt@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Apr, at 03:17:55PM, Ard Biesheuvel wrote: > > diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c > > index 1cfbfaf57a2d..0416d5d33e74 100644 > > --- a/drivers/firmware/efi/arm-runtime.c > > +++ b/drivers/firmware/efi/arm-runtime.c > > @@ -89,6 +89,7 @@ static bool __init efi_virtmap_init(void) > > */ > > static int __init arm_enable_runtime_services(void) > > { > > + phys_addr_t phys_map; > > Is the sole purpose of this variable to prevent breaking the 80-column rule? Indeed it is. > If so, please be aware that I intend to propose a patch that replaces > the ioremap_cache() below with a call to memremap(), but this is > another change that is gated by Russell merging my memremap patches > for ARM OK. Would you like me to drop this particular hunk and just go with, efi.memmap.map = (__force void *)ioremap_cache(efi.memmap.phys_map, mapsize); if you're going to rewrite it soon anyway? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 2/2] efi: Remove global 'memmap' Date: Tue, 12 Apr 2016 21:01:19 +0100 Message-ID: <20160412200119.GH2829@codeblueprint.co.uk> References: <1460379809-18490-1-git-send-email-matt@codeblueprint.co.uk> <1460379809-18490-3-git-send-email-matt@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Tony Luck , "Luck, Tony" List-Id: linux-efi@vger.kernel.org On Mon, 11 Apr, at 03:17:55PM, Ard Biesheuvel wrote: > > diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c > > index 1cfbfaf57a2d..0416d5d33e74 100644 > > --- a/drivers/firmware/efi/arm-runtime.c > > +++ b/drivers/firmware/efi/arm-runtime.c > > @@ -89,6 +89,7 @@ static bool __init efi_virtmap_init(void) > > */ > > static int __init arm_enable_runtime_services(void) > > { > > + phys_addr_t phys_map; > > Is the sole purpose of this variable to prevent breaking the 80-column rule? Indeed it is. > If so, please be aware that I intend to propose a patch that replaces > the ioremap_cache() below with a call to memremap(), but this is > another change that is gated by Russell merging my memremap patches > for ARM OK. Would you like me to drop this particular hunk and just go with, efi.memmap.map = (__force void *)ioremap_cache(efi.memmap.phys_map, mapsize); if you're going to rewrite it soon anyway?