From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:28428 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbcDMAJk (ORCPT ); Tue, 12 Apr 2016 20:09:40 -0400 Date: Wed, 13 Apr 2016 10:08:57 +1000 From: Dave Chinner To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz Subject: Re: [PATCH 0/3] writeback: minor tweaks Message-ID: <20160413000857.GB10643@dastard> References: <1460486633-26099-1-git-send-email-axboe@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460486633-26099-1-git-send-email-axboe@fb.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Apr 12, 2016 at 12:43:50PM -0600, Jens Axboe wrote: > Hi, > > Three top level patches out of the writeback throttling patchset, that > I think should make it into mainline. No functional changes in the > first two patches, and the last patch just bumps reclaim/sync > writeback to use WRITE_SYNC as a hint to the block layer. Whatever happened to adding a new flag to indicate that write requests can be throttled, rather than overloading WRITE_SYNC with yet another (conflicting) meaning? I've already pointed out the problems associated with tagging async, bulk writes as synchronous writes so that a lower layer can avoid throttling them. Please add a new flag for communicating whether writes can be throttled to the block layer instead of reusing WRITE_SYNC. Cheers, Dave. -- Dave Chinner david@fromorbit.com