From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:25904 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757832AbcDMAWK (ORCPT ); Tue, 12 Apr 2016 20:22:10 -0400 Date: Wed, 13 Apr 2016 10:22:07 +1000 From: Dave Chinner To: Christoph Hellwig Cc: Bob Peterson , linux-fsdevel@vger.kernel.org, Jan Kara , Al Viro Subject: Re: [vfs PATCH v3 1/4] VFS: move iomap from exportfs.h to iomap.h Message-ID: <20160413002207.GC10643@dastard> References: <1457122300-28514-1-git-send-email-rpeterso@redhat.com> <1457122300-28514-2-git-send-email-rpeterso@redhat.com> <20160315072912.GE11669@infradead.org> <690524895.44280573.1459194784327.JavaMail.zimbra@redhat.com> <20160329074026.GD8568@infradead.org> <20160329222036.GD30721@dastard> <20160410171528.GA9118@infradead.org> <20160411061740.GH567@dastard> <20160412182940.GA9125@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160412182940.GA9125@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Apr 12, 2016 at 11:29:40AM -0700, Christoph Hellwig wrote: > On Mon, Apr 11, 2016 at 04:17:40PM +1000, Dave Chinner wrote: > > In this case, I'd let xfs_vn_fiemap handle that. i.e. if the > > FIEMAP_FLAG_XATTR is set, run the old code, otherwise call straight > > into the new generic iomap based code. > > > > I'm not sure if how your new code is structured, but n this version > > __generic_iomap_fiemap() is passed an iomap_get_t callback function. > > We could simply have XFS pass a different callback function that > > looks up the attribute fork extent list rather than the data fork > > extent list to support FIEMAP_FLAG_XATTR appropriately because other > > than the different initial extent list root it seems to me like the > > implementation should be identical.... > > Providing iomap_ops for the xattr flag look feasily, but currently > there is no real testing for it. Only fsstress will call into it > at all and doesn't even verify the output. I'll send the iomap > implementation and XFS support as RFC, and then you can decide what > to do with it. Sure. FWIW, the xfs_io fiemap command is able to query the attribute fork rather than the data fork. I suspect it's not actually used in any regression tests in xfstests, though. Cheers, Dave. -- Dave Chinner david@fromorbit.com