From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966069AbcDMHJ1 (ORCPT ); Wed, 13 Apr 2016 03:09:27 -0400 Received: from mga09.intel.com ([134.134.136.24]:45804 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966028AbcDMHJY (ORCPT ); Wed, 13 Apr 2016 03:09:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,478,1455004800"; d="scan'208";a="957558747" Date: Wed, 13 Apr 2016 15:07:42 +0800 From: kbuild test robot To: Karol Herbst Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Ben Skeggs , Martin Peres , David Airlie , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings Message-ID: <20160413070742.GA9311@lkp-nex05> References: <201604131531.CJokPLHc%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201604131531.CJokPLHc%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Karol Herbst Signed-off-by: Fengguang Wu --- base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c @@ -129,8 +129,7 @@ nvkm_iccsense_dtor(struct nvkm_subdev *s { struct nvkm_iccsense *iccsense = nvkm_iccsense(subdev); - if (iccsense->rails) - kfree(iccsense->rails); + kfree(iccsense->rails); return iccsense; } From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings Date: Wed, 13 Apr 2016 15:07:42 +0800 Message-ID: <20160413070742.GA9311@lkp-nex05> References: <201604131531.CJokPLHc%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id C89C26E36C for ; Wed, 13 Apr 2016 07:09:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <201604131531.CJokPLHc%fengguang.wu@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Karol Herbst Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs , kbuild-all@01.org List-Id: dri-devel@lists.freedesktop.org ZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9zdWJkZXYvaWNjc2Vuc2UvYmFzZS5jOjEzMzoy LTc6IFdBUk5JTkc6IE5VTEwgY2hlY2sgYmVmb3JlIGZyZWVpbmcgZnVuY3Rpb25zIGxpa2Uga2Zy ZWUsIGRlYnVnZnNfcmVtb3ZlLCBkZWJ1Z2ZzX3JlbW92ZV9yZWN1cnNpdmUgb3IgdXNiX2ZyZWVf dXJiIGlzIG5vdCBuZWVkZWQuIE1heWJlIGNvbnNpZGVyIHJlb3JnYW5pemluZyByZWxldmFudCBj b2RlIHRvIGF2b2lkIHBhc3NpbmcgTlVMTCB2YWx1ZXMuCgogTlVMTCBjaGVjayBiZWZvcmUgc29t ZSBmcmVlaW5nIGZ1bmN0aW9ucyBpcyBub3QgbmVlZGVkLgoKIEJhc2VkIG9uIGNoZWNrcGF0Y2gg d2FybmluZwogImtmcmVlKE5VTEwpIGlzIHNhZmUgdGhpcyBjaGVjayBpcyBwcm9iYWJseSBub3Qg cmVxdWlyZWQiCiBhbmQga2ZyZWVhZGRyLmNvY2NpIGJ5IEp1bGlhIExhd2FsbC4KCkdlbmVyYXRl ZCBieTogc2NyaXB0cy9jb2NjaW5lbGxlL2ZyZWUvaWZudWxsZnJlZS5jb2NjaQoKQ0M6IEthcm9s IEhlcmJzdCA8bm91dmVhdUBrYXJvbGhlcmJzdC5kZT4KU2lnbmVkLW9mZi1ieTogRmVuZ2d1YW5n IFd1IDxmZW5nZ3Vhbmcud3VAaW50ZWwuY29tPgotLS0KCiBiYXNlLmMgfCAgICAzICstLQogMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQoKLS0tIGEvZHJpdmVy cy9ncHUvZHJtL25vdXZlYXUvbnZrbS9zdWJkZXYvaWNjc2Vuc2UvYmFzZS5jCisrKyBiL2RyaXZl cnMvZ3B1L2RybS9ub3V2ZWF1L252a20vc3ViZGV2L2ljY3NlbnNlL2Jhc2UuYwpAQCAtMTI5LDgg KzEyOSw3IEBAIG52a21faWNjc2Vuc2VfZHRvcihzdHJ1Y3QgbnZrbV9zdWJkZXYgKnMKIHsKIAlz dHJ1Y3QgbnZrbV9pY2NzZW5zZSAqaWNjc2Vuc2UgPSBudmttX2ljY3NlbnNlKHN1YmRldik7CiAK LQlpZiAoaWNjc2Vuc2UtPnJhaWxzKQotCQlrZnJlZShpY2NzZW5zZS0+cmFpbHMpOworCWtmcmVl KGljY3NlbnNlLT5yYWlscyk7CiAKIAlyZXR1cm4gaWNjc2Vuc2U7CiB9Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=