From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Date: Wed, 13 Apr 2016 09:19:43 +0000 Subject: Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable Message-Id: <20160413091943.GA17858@gmail.com> List-Id: References: <1460041951-22347-1-git-send-email-mhocko@kernel.org> <1460041951-22347-11-git-send-email-mhocko@kernel.org> <20160413090829.GB29579@gmail.com> <20160413091625.GF14351@dhcp22.suse.cz> In-Reply-To: <20160413091625.GF14351@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: LKML , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Andrew Morton , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, Josh Poimboeuf * Michal Hocko wrote: > On Wed 13-04-16 11:08:30, Ingo Molnar wrote: > > > > * Michal Hocko wrote: > [...] > > > +ENTRY(call_rwsem_down_write_failed_killable) > > > + save_common_regs > > > + movq %rax,%rdi > > > + call rwsem_down_write_failed_killable > > > + restore_common_regs > > > + ret > > > +ENDPROC(call_rwsem_down_write_failed_killable) > > > > Got this objtool warning on x86-64 allyesconfig: > > > > arch/x86/lib/rwsem.o: warning: objtool: call_rwsem_down_write_failed_killable()+0xe: call without frame pointer save/setup > > Peter has already pointed that out. This is because the 4.5 which I was > basing my work on doesn't have 3387a535ce62 ("x86/asm: Create stack > frames in rwsem functions") which shown up in 4.6-rc1. He mentioned to > add the missing FRAME_{BEGIN,END} during the merge AFAIR. > > Does that sound reasonable to you or should I rebase? I'm testing your patches today, if they are otherwise OK then please send a delta patch against the tip:locking/rwsem tree I'll push out. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934638AbcDMJTy (ORCPT ); Wed, 13 Apr 2016 05:19:54 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34695 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932454AbcDMJTu (ORCPT ); Wed, 13 Apr 2016 05:19:50 -0400 Date: Wed, 13 Apr 2016 11:19:43 +0200 From: Ingo Molnar To: Michal Hocko Cc: LKML , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Andrew Morton , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, Josh Poimboeuf Subject: Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable Message-ID: <20160413091943.GA17858@gmail.com> References: <1460041951-22347-1-git-send-email-mhocko@kernel.org> <1460041951-22347-11-git-send-email-mhocko@kernel.org> <20160413090829.GB29579@gmail.com> <20160413091625.GF14351@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160413091625.GF14351@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Michal Hocko wrote: > On Wed 13-04-16 11:08:30, Ingo Molnar wrote: > > > > * Michal Hocko wrote: > [...] > > > +ENTRY(call_rwsem_down_write_failed_killable) > > > + save_common_regs > > > + movq %rax,%rdi > > > + call rwsem_down_write_failed_killable > > > + restore_common_regs > > > + ret > > > +ENDPROC(call_rwsem_down_write_failed_killable) > > > > Got this objtool warning on x86-64 allyesconfig: > > > > arch/x86/lib/rwsem.o: warning: objtool: call_rwsem_down_write_failed_killable()+0xe: call without frame pointer save/setup > > Peter has already pointed that out. This is because the 4.5 which I was > basing my work on doesn't have 3387a535ce62 ("x86/asm: Create stack > frames in rwsem functions") which shown up in 4.6-rc1. He mentioned to > add the missing FRAME_{BEGIN,END} during the merge AFAIR. > > Does that sound reasonable to you or should I rebase? I'm testing your patches today, if they are otherwise OK then please send a delta patch against the tip:locking/rwsem tree I'll push out. Thanks, Ingo