From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:37996 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030425AbcDMJuf (ORCPT ); Wed, 13 Apr 2016 05:50:35 -0400 Date: Wed, 13 Apr 2016 11:50:32 +0200 From: Jan Kara To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz Subject: Re: [PATCH 2/3] writeback: add wbc_to_write() Message-ID: <20160413095032.GH15098@quack2.suse.cz> References: <1460486633-26099-1-git-send-email-axboe@fb.com> <1460486633-26099-3-git-send-email-axboe@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460486633-26099-3-git-send-email-axboe@fb.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue 12-04-16 12:43:52, Jens Axboe wrote: > Add wbc_to_write(), which returns the write type to use, based on a > struct writeback_control. No functional changes in this patch, but it > prepares us for factoring other wbc fields for write type. > > No intended functional changes in this patch. I like the patch except for the function name ;). Maybe wbc_to_write_cmd() or something like that? Honza -- Jan Kara SUSE Labs, CR