All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maxin B. John" <maxin.john@intel.com>
To: Gary Thomas <gary@mlbassoc.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] matchbox-keyboard: Hide desktop launcher
Date: Wed, 13 Apr 2016 15:24:11 +0300	[thread overview]
Message-ID: <20160413122411.GA11999@mbabyjoh-desk.ger.corp.intel.com> (raw)
In-Reply-To: <570E37F7.3020309@mlbassoc.com>

Hi,

On Wed, Apr 13, 2016 at 02:13:43PM +0200, Gary Thomas wrote:
> On 2016-04-13 14:08, Jussi Kukkonen wrote:
> >On 13 April 2016 at 14:35, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:

<snip>
> >
> >Have you checked that your /etc/formfactor/machconfig contains "HAVE_KEYBOARD=0"? This value is used by
> >/etc/matchbox/session to decide whether to load the keyboard panel or not, and by .the Xsession script to decide whether
> >to start the daemonized keyboard or not.
> 
> Has this or any of the files it depends on (/etc/formfactor/*) changed recently?
> As I said, as recently as mid February everything worked as expected, no longer.
> If something changed that I need to track, I'm happy to adapt.
>

Yes, there was a change in Keyboard related logic in formfactor with this recent commit:

commit 463fd5ee26c5037b0f4ecfe4bc6ed48945b3b07e
Author: Ross Burton <ross.burton@intel.com>
Date:   Thu Mar 3 16:56:43 2016 +0000

 formfactor: assume a keyboard is plugged in
        
 A sensible assumption is that BSPs have a USB keyboard and mouse connected
 unless told otherwise, so flip the logic in the formfactor config script that
 previously assumed that a keyboard was not connected by default.
                       
 [ YOCTO #9174 ]
                                
(From OE-Core rev: a82ce3e477a475dccea3837eabacd9e93b873ee6)
                                       
 Signed-off-by: Ross Burton <ross.burton@intel.com>
 Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
 <snip>
if [ -z "$HAVE_KEYBOARD" ]; then
 -    HAVE_KEYBOARD=0
 +    HAVE_KEYBOARD=1


Best Regards,
Maxin


  reply	other threads:[~2016-04-13 12:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12  8:14 [PATCH] matchbox-keyboard: Hide desktop launcher Jussi Kukkonen
2016-04-13 11:35 ` Gary Thomas
2016-04-13 12:08   ` Jussi Kukkonen
2016-04-13 12:13     ` Gary Thomas
2016-04-13 12:24       ` Maxin B. John [this message]
2016-04-13 12:42         ` Gary Thomas
2016-04-13 14:48           ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413122411.GA11999@mbabyjoh-desk.ger.corp.intel.com \
    --to=maxin.john@intel.com \
    --cc=gary@mlbassoc.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.