* drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
@ 2016-04-13 7:07 kbuild test robot
2016-04-13 7:07 ` kbuild test robot
0 siblings, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2016-04-13 7:07 UTC (permalink / raw)
To: Karol Herbst; +Cc: kbuild-all, linux-kernel, Ben Skeggs, Martin Peres
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1c74a7f812b135d3df41d7c3671b647aed6467bf
commit: b71c0892631af3dd2aea708529d282a65c683be5 drm/nouveau/iccsense: implement for ina209, ina219 and ina3221
date: 4 weeks ago
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings
2016-04-13 7:07 drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values kbuild test robot
@ 2016-04-13 7:07 ` kbuild test robot
0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2016-04-13 7:07 UTC (permalink / raw)
To: Karol Herbst
Cc: kbuild-all, linux-kernel, Ben Skeggs, Martin Peres, David Airlie,
dri-devel
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Karol Herbst <nouveau@karolherbst.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
@@ -129,8 +129,7 @@ nvkm_iccsense_dtor(struct nvkm_subdev *s
{
struct nvkm_iccsense *iccsense = nvkm_iccsense(subdev);
- if (iccsense->rails)
- kfree(iccsense->rails);
+ kfree(iccsense->rails);
return iccsense;
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings
@ 2016-04-13 7:07 ` kbuild test robot
0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2016-04-13 7:07 UTC (permalink / raw)
To: Karol Herbst; +Cc: linux-kernel, dri-devel, Ben Skeggs, kbuild-all
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Karol Herbst <nouveau@karolherbst.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
@@ -129,8 +129,7 @@ nvkm_iccsense_dtor(struct nvkm_subdev *s
{
struct nvkm_iccsense *iccsense = nvkm_iccsense(subdev);
- if (iccsense->rails)
- kfree(iccsense->rails);
+ kfree(iccsense->rails);
return iccsense;
}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings
2016-04-13 7:07 ` kbuild test robot
@ 2016-04-13 7:55 ` Martin Peres
-1 siblings, 0 replies; 6+ messages in thread
From: Martin Peres @ 2016-04-13 7:55 UTC (permalink / raw)
To: kbuild test robot, Karol Herbst
Cc: kbuild-all, linux-kernel, Ben Skeggs, David Airlie, dri-devel
On 13/04/16 10:07, kbuild test robot wrote:
> drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
>
> NULL check before some freeing functions is not needed.
>
> Based on checkpatch warning
> "kfree(NULL) is safe this check is probably not required"
> and kfreeaddr.cocci by Julia Lawall.
>
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
>
> CC: Karol Herbst <nouveau@karolherbst.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Martin Peres <martin.peres@free.fr>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings
@ 2016-04-13 7:55 ` Martin Peres
0 siblings, 0 replies; 6+ messages in thread
From: Martin Peres @ 2016-04-13 7:55 UTC (permalink / raw)
To: kbuild test robot, Karol Herbst
Cc: Ben Skeggs, kbuild-all, dri-devel, linux-kernel
On 13/04/16 10:07, kbuild test robot wrote:
> drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
>
> NULL check before some freeing functions is not needed.
>
> Based on checkpatch warning
> "kfree(NULL) is safe this check is probably not required"
> and kfreeaddr.cocci by Julia Lawall.
>
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
>
> CC: Karol Herbst <nouveau@karolherbst.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Martin Peres <martin.peres@free.fr>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings
2016-04-13 7:55 ` Martin Peres
(?)
@ 2016-04-13 10:08 ` Karol Herbst
-1 siblings, 0 replies; 6+ messages in thread
From: Karol Herbst @ 2016-04-13 10:08 UTC (permalink / raw)
To: Martin Peres, kbuild test robot
Cc: kbuild-all, Ben Skeggs, linux-kernel, David Airlie, dri-devel
> Martin Peres <martin.peres@free.fr> hat am 13. April 2016 um 09:55
> geschrieben:
>
>
> On 13/04/16 10:07, kbuild test robot wrote:
> > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL
> > check before freeing functions like kfree, debugfs_remove,
> > debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
> > reorganizing relevant code to avoid passing NULL values.
> >
> > NULL check before some freeing functions is not needed.
> >
> > Based on checkpatch warning
> > "kfree(NULL) is safe this check is probably not required"
> > and kfreeaddr.cocci by Julia Lawall.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > CC: Karol Herbst <nouveau@karolherbst.de>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Martin Peres <martin.peres@free.fr>
Signed-off-by: Karol Herbst <nouveau@karolherbst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-13 10:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-13 7:07 drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values kbuild test robot
2016-04-13 7:07 ` [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings kbuild test robot
2016-04-13 7:07 ` kbuild test robot
2016-04-13 7:55 ` Martin Peres
2016-04-13 7:55 ` Martin Peres
2016-04-13 10:08 ` Karol Herbst
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.