From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: julien.grall@arm.com, sstabellini@kernel.org,
xen-devel@lists.xensource.com, jonathan.davies@citrix.com,
jonathan.ludlam@citrix.com, euan.harris@citrix.com,
andrew.cooper3@citrix.com
Subject: OCaml compilation issues (staging) under ARM32 (ocaml-4.01)
Date: Wed, 13 Apr 2016 16:28:49 -0400 [thread overview]
Message-ID: <20160413202849.GA5962@char.us.oracle.com> (raw)
Hey,
As I was testing xSplice I had compile issues to Andrew's CPUID work
which was easy to fix:
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 5477df3..881f1b4 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -1216,8 +1216,9 @@ CAMLprim value stub_xc_domain_deassign_device(value xch, value domid, value desc
CAMLprim value stub_xc_get_cpu_featureset(value xch, value idx)
{
- CAMLparam2(xch, idx);
CAMLlocal1(bitmap_val);
+#if defined(__i386__) || defined(__x86_64__)
+ CAMLparam2(xch, idx);
/* Safe, because of the global ocaml lock. */
static uint32_t fs_len;
@@ -1245,7 +1246,9 @@ CAMLprim value stub_xc_get_cpu_featureset(value xch, value idx)
for (i = 0; i < len; ++i)
Store_field(bitmap_val, i, caml_copy_int64(fs[i]));
}
-
+#else
+ caml_failwith("xc_domain_cpuid_set: not implemented");
+#endif
CAMLreturn(bitmap_val);
}
But then I hit on this:
[3]: Entering directory `/mnt/xen/tools/ocaml/libs'
make -C xc all
make[4]: Entering directory `/mnt/xen/tools/ocaml/libs/xc'
CC xenctrl_stubs.o
In file included from xenctrl_stubs.c:23:0:
xenctrl_stubs.c: In function 'stub_xc_get_cpu_featureset':
/usr/lib/ocaml/caml/memory.h:223:22: error: 'caml__frame' undeclared (first use in this function)
caml_local_roots = caml__frame; \
^
/usr/lib/ocaml/caml/memory.h:227:28: note: in expansion of macro 'CAMLreturnT'
#define CAMLreturn(result) CAMLreturnT(value, result)
^
xenctrl_stubs.c:1252:2: note: in expansion of macro 'CAMLreturn'
CAMLreturn(bitmap_val);
^
/usr/lib/ocaml/caml/memory.h:223:22: note: each undeclared identifier is reported only once for each function it appears in
caml_local_roots = caml__frame; \
^
/usr/lib/ocaml/caml/memory.h:227:28: note: in expansion of macro 'CAMLreturnT'
#define CAMLreturn(result) CAMLreturnT(value, result)
^
xenctrl_stubs.c:1252:2: note: in expansion of macro 'CAMLreturn'
CAMLreturn(bitmap_val);
^
make[4]: *** [xenctrl_stubs.o] Error 1
make[4]: Leaving directory `/mnt/xen/tools/ocaml/libs/xc'
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
This is running on ARM32 cubietruck running Linar something.
dpkg tells me:
root@cubietruck:~# dpkg -l | grep ocaml
ii libfindlib-ocaml 1.4-2 armhf library for managing OCaml libraries (runtime)
ii libfindlib-ocaml-dev 1.4-2 armhf library for managing OCaml libraries (development files)
ii ocaml 4.01.0-3ubuntu3 armhf ML language implementation with a class-based object system
ii ocaml-base 4.01.0-3ubuntu3 armhf Runtime system for OCaml bytecode executables
ii ocaml-base-nox 4.01.0-3ubuntu3 armhf Runtime system for OCaml bytecode executables (no X)
ii ocaml-compiler-libs 4.01.0-3ubuntu3 armhf OCaml interpreter and standard libraries
ii ocaml-findlib 1.4-2 armhf management tool for OCaml libraries
ii ocaml-interp 4.01.0-3ubuntu3 armhf OCaml interactive interpreter and standard libraries
ii ocaml-native-compilers 4.01.0-3ubuntu3 armhf Native code compilers of the OCaml suite (the .opt ones)
ii ocaml-nox 4.01.0-3ubuntu3 armhf ML implementation with a class-based object system (no X)
Ideas?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-04-13 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 20:28 Konrad Rzeszutek Wilk [this message]
2016-04-13 21:06 ` OCaml compilation issues (staging) under ARM32 (ocaml-4.01) Andrew Cooper
2016-04-14 11:26 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413202849.GA5962@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=euan.harris@citrix.com \
--cc=jonathan.davies@citrix.com \
--cc=jonathan.ludlam@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.