From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 06/12] tpm: Manage itpm workaround with tis specific data_expect bit Date: Wed, 13 Apr 2016 14:44:54 -0600 Message-ID: <20160413204454.GC3836@obsidianresearch.com> References: <1460577351-24632-1-git-send-email-christophe-h.ricard@st.com> <1460577351-24632-7-git-send-email-christophe-h.ricard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1460577351-24632-7-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org, ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org, benoit.houyere-qxv4g6HH51o@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Apr 13, 2016 at 09:55:45PM +0200, Christophe Ricard wrote: > +static struct tpm_tis_phy_ops tis_phy_ops = { > + .data_expect_mask = TPM_STS_DATA_EXPECT, > + .data_expect_val = TPM_STS_DATA_EXPECT, > +}; > +struct tpm_tis_phy_ops { > + int (*post_probe)(struct tpm_chip *chip); > +}; Doesn't lool like this will compile. No idea why we'd want to add a tpm_tis_phy_ops along side tpm_tis_class_lowlevel, just use one. ops is a better name. Jason ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z