From: Will Deacon <will.deacon@arm.com>
To: Balbir Singh <bsingharora@gmail.com>
Cc: kvm@vger.kernel.org, mpe@ellerman.id.au,
Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH] kvmtool: delegate exit/reboot responsibility to vcpu0
Date: Thu, 14 Apr 2016 09:49:33 +0100 [thread overview]
Message-ID: <20160414084933.GB23207@arm.com> (raw)
In-Reply-To: <570EF90B.908@gmail.com>
On Thu, Apr 14, 2016 at 11:57:31AM +1000, Balbir Singh wrote:
>
>
> On 12/04/16 01:37, Will Deacon wrote:
> > Our exit/reboot code is a bit of a mess:
> >
> > - Both kvm__reboot and kvm_cpu_exit send SIGKVMEXIT to running vcpus
> > - When vcpu0 exits, the main thread starts executing destructors
> > (exitcalls) whilst other vcpus may be running
> > - The pause_lock isn't always held when inspecting is_running for
> > a vcpu
> >
> > This patch attempts to fix these issues by restricting the exit/reboot
> > path to vcpu0 and the main thread. In particular, a KVM_SYSTEM_EVENT
> > will signal SIGKVMEXIT to vcpu0, which will join with the main thread
> > and then tear down the other vcpus before invoking any destructor code.
> >
> > Cc: Julien Grall <julien.grall@arm.com>
> > Cc: Balbir Singh <bsingharora@gmail.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > ---
> >
> > Balbir -- does this work on ppc?
>
>
> Yes, it does
>
> Acked-by: Balbir Singh <bsingharora@gmail.com>
>
> My patch for exit race fixes can be dropped in favour of this change
Thanks, Balbir! I've pushed it out, along with your ppc changes.
Will
prev parent reply other threads:[~2016-04-14 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 15:37 [PATCH] kvmtool: delegate exit/reboot responsibility to vcpu0 Will Deacon
2016-04-12 10:03 ` Julien Grall
2016-04-14 1:57 ` Balbir Singh
2016-04-14 8:49 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414084933.GB23207@arm.com \
--to=will.deacon@arm.com \
--cc=bsingharora@gmail.com \
--cc=julien.grall@arm.com \
--cc=kvm@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.