From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754930AbcDNOcH (ORCPT ); Thu, 14 Apr 2016 10:32:07 -0400 Received: from sauhun.de ([89.238.76.85]:42882 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753313AbcDNOcE (ORCPT ); Thu, 14 Apr 2016 10:32:04 -0400 Date: Thu, 14 Apr 2016 16:31:25 +0200 From: Wolfram Sang To: Guenter Roeck Cc: Geert Uytterhoeven , Mark Rutland , Russell King , Catalin Marinas , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lorenzo Pieralisi Subject: Re: [PATCH 3/6] ARM: PSCI: Register with kernel restart handler Message-ID: <20160414143125.GB1539@katana> References: <1460120039-2497-1-git-send-email-linux@roeck-us.net> <1460120039-2497-4-git-send-email-linux@roeck-us.net> <20160413110519.GE32018@leverpostej> <570E4550.5000207@roeck-us.net> <20160414004223.GA18564@roeck-us.net> <20160414085242.GB1533@katana> <570F9942.30608@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KFztAG8eRSV9hGtP" Content-Disposition: inline In-Reply-To: <570F9942.30608@roeck-us.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --KFztAG8eRSV9hGtP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > "the higher, the more important" makes sense to me. We don't have to > enforce the linux scheme, though that happens to be the same (the priority > argument in the notifier block takes an int, so it would not even be > necessary to adjust it unless someone specifies 0xffffffff). I think we should enforce the scheme internally (but not in DT, of course): a) it is documented to be in the range 0-255 b) it should be valid to prioritize the watchdogs with 1,2,3 in DT. If we don't apply the '255 - pos_in_sorted_list' value, then the priority could be below some machine default of 128, or? > I am fine either way - boolean properties or numbers, with a personal > preference for numbers as more flexible. Same here. Time to go to the DT list probably. --KFztAG8eRSV9hGtP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXD6m9AAoJEBQN5MwUoCm29LcQAJZyANhwqk/gNtxGe35Qq399 Il//DGHWc1l89fygga6gxl16VgIv1xfvmxHvhxQj0PTrYKFSV20enviWkRFCBhLz 9lodPVKGD037JXdLMCFVqHuwLeU27uNYr2tnJcefF/xzYcTSHD2DFyZfADFN8aiB G6Fd/HgavmlTcHrdEX6waoPpL7MCnUYo7aHIFgmqrYgAwVOii1XbV27/nXiQInkP fckUD/Jl5BJrznUPo9o0MGY//dgKUKSu5Y+QeGTK4FqlMT+E/stARoaBJBngzog8 2Ptc70wqnqxEmYgzbC5pWBAXrujiQvmpw5zoq3E9krbkevLqvZhxyywt+hArIgRD vBfs7Vel6UFXXNJgaEA1LSH9svyVKBfylW4bRU49RfF9Ud8fPf702saWxFvS2j6q mr7v061Q9uOHcE5EP+riwIXTnwpN39tlY0yRJclPba2HZbtYPqkgM9QvSsMqsvxc 5Kd7BzDKVtRHv/7OL/PtpkKtlxVZwxZE/w4PgWik/6qhBun2Rq66Ge+zwSaNrZmA E/uzNlpPAUPV/dKVPQjUQWziLeABqUOw0YLW65uPQzLJWVHc6KP8SnARKpsRjluM bl/PmDNLCxoDMXTycB24cC1AbLSHW70zaIWLT5voKTpehC0O0ik0xu59BwugQlIb tugadZo4wEQQhrSfALRm =F9yJ -----END PGP SIGNATURE----- --KFztAG8eRSV9hGtP-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: wsa@the-dreams.de (Wolfram Sang) Date: Thu, 14 Apr 2016 16:31:25 +0200 Subject: [PATCH 3/6] ARM: PSCI: Register with kernel restart handler In-Reply-To: <570F9942.30608@roeck-us.net> References: <1460120039-2497-1-git-send-email-linux@roeck-us.net> <1460120039-2497-4-git-send-email-linux@roeck-us.net> <20160413110519.GE32018@leverpostej> <570E4550.5000207@roeck-us.net> <20160414004223.GA18564@roeck-us.net> <20160414085242.GB1533@katana> <570F9942.30608@roeck-us.net> Message-ID: <20160414143125.GB1539@katana> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > "the higher, the more important" makes sense to me. We don't have to > enforce the linux scheme, though that happens to be the same (the priority > argument in the notifier block takes an int, so it would not even be > necessary to adjust it unless someone specifies 0xffffffff). I think we should enforce the scheme internally (but not in DT, of course): a) it is documented to be in the range 0-255 b) it should be valid to prioritize the watchdogs with 1,2,3 in DT. If we don't apply the '255 - pos_in_sorted_list' value, then the priority could be below some machine default of 128, or? > I am fine either way - boolean properties or numbers, with a personal > preference for numbers as more flexible. Same here. Time to go to the DT list probably. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: