From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, oleg@redhat.com, rientjes@google.com,
linux-mm@kvack.org
Subject: Re: [PATCH] mm,oom: Clarify reason to kill other threads sharing thevitctim's memory.
Date: Thu, 14 Apr 2016 17:18:38 +0200 [thread overview]
Message-ID: <20160414151838.GK2850@dhcp22.suse.cz> (raw)
In-Reply-To: <201604150003.GAI13041.MLHFOtOFOQSJVF@I-love.SAKURA.ne.jp>
On Fri 15-04-16 00:03:31, Tetsuo Handa wrote:
> Michal Hocko wrote:
[...]
> > I would rather be explicit that we _do not care_
> > about these configurations. It is just PITA maintain and it doesn't make
> > any sense. So rather than trying to document all the weird thing that
> > might happen I would welcome a warning "mm shared with OOM_SCORE_ADJ_MIN
> > task. Something is broken in your configuration!"
>
> Would you please stop rejecting configurations which do not match your values?
Can you point out a single real life example where the above
configuration would make a sense? This is not about _my_ values. This is
about general _sanity_. If two/more entities share the mm and they disagree
about their OOM priorities then something is clearly broken. Don't you think?
How can the OOM killer do anything sensible here? The API we have
created is broken because it allows broken configurations too easily. It
is too late to fix it though so we can only rely on admins to use it
sensibly.
So please try to step back and think about whether it actually make
sense to make the oom even more complex/confusing for something that
gives little (if any) sense.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-14 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 10:56 [PATCH] mm,oom_reaper: Use try_oom_reaper() for reapability test Tetsuo Handa
2016-04-14 10:56 ` [PATCH] mm,oom: Clarify reason to kill other threads sharing the vitctim's memory Tetsuo Handa
2016-04-14 11:31 ` Michal Hocko
2016-04-14 15:03 ` [PATCH] mm,oom: Clarify reason to kill other threads sharing thevitctim's memory Tetsuo Handa
2016-04-14 15:18 ` Michal Hocko [this message]
2016-04-14 21:59 ` [PATCH] mm,oom: Clarify reason to kill other threads sharing the vitctim's memory Tetsuo Handa
2016-04-14 11:21 ` [PATCH] mm,oom_reaper: Use try_oom_reaper() for reapability test Michal Hocko
2016-04-14 11:34 ` Tetsuo Handa
2016-04-14 12:01 ` Michal Hocko
2016-04-14 12:34 ` Michal Hocko
2016-04-14 14:01 ` Tetsuo Handa
2016-04-14 14:30 ` Michal Hocko
2016-04-15 12:11 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414151838.GK2850@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.