From: Tejun Heo <tj@kernel.org>
To: Manish Chopra <manish.chopra@qlogic.com>
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dept-Eng Linux Driver <Linux-Driver@qlogic.com>,
Harish Patil <harish.patil@qlogic.com>,
Dept-GE Linux NIC Dev <Dept-GELinuxNICDev@qlogic.com>
Subject: Re: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue
Date: Thu, 14 Apr 2016 11:47:00 -0400 [thread overview]
Message-ID: <20160414154700.GE12583@htj.duckdns.org> (raw)
In-Reply-To: <BLUPR11MB011498CD02CC919F023545E793970@BLUPR11MB0114.namprd11.prod.outlook.com>
Hello, Manish.
On Thu, Apr 14, 2016 at 07:25:15AM +0000, Manish Chopra wrote:
> Just want to confirm that __WQ_LEGACY flag is not necessary here as this is removed
> with this change ?
Yeah, that should be fine. That only affects locking dependency
tracking which can fire spuriously due to workqueues created with the
old interface having WQ_MEM_RECLAIM unconditionally. In this case, we
actually want WQ_MEM_RECLAIM and thus we want the dependency tracking
too.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-04-14 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 11:57 [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue Amitoj Kaur Chawla
2016-04-13 17:44 ` Tejun Heo
2016-04-14 7:25 ` Manish Chopra
2016-04-14 15:47 ` Tejun Heo [this message]
2016-04-15 20:42 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-03-15 14:38 Amitoj Kaur Chawla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414154700.GE12583@htj.duckdns.org \
--to=tj@kernel.org \
--cc=Dept-GELinuxNICDev@qlogic.com \
--cc=Linux-Driver@qlogic.com \
--cc=Sudarsana.Kalluru@qlogic.com \
--cc=amitoj1606@gmail.com \
--cc=harish.patil@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.