From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932708AbcDNRMp (ORCPT ); Thu, 14 Apr 2016 13:12:45 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58079 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932420AbcDNRMn (ORCPT ); Thu, 14 Apr 2016 13:12:43 -0400 Date: Thu, 14 Apr 2016 19:12:41 +0200 From: Maxime Ripard To: Andre Przywara Cc: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, robh@kernel.org, Russell King , Chen-Yu Tsai , Catalin Marinas , Will Deacon , Thomas Gleixner , Jason Cooper , Marc Zyngier Subject: Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Message-ID: <20160414171241.GQ4005@lukather> References: <1460563167-18517-1-git-send-email-suzuki.poulose@arm.com> <20160413200735.GC4005@lukather> <570F5932.2020809@arm.com> <570F5B5B.90302@arm.com> <570F5F94.1090602@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LwgCY5hL6Igino+O" Content-Disposition: inline In-Reply-To: <570F5F94.1090602@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LwgCY5hL6Igino+O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 14, 2016 at 10:15:00AM +0100, Andre Przywara wrote: > Hi, >=20 > On 14/04/16 09:56, Suzuki K Poulose wrote: > > On 14/04/16 09:47, Suzuki K Poulose wrote: > >> On 13/04/16 21:07, Maxime Ripard wrote: > >>> Hi, > >>> > >>> On Wed, Apr 13, 2016 at 04:59:27PM +0100, Suzuki K Poulose wrote: > >>>> The sunxi-nmi and sun4i irq chips are selected by ARCH_SUNXI on both > >>>> arm > >>>> and arm64 (recently added). However on arm64, we don't explicitly > >>>> select > >>>> GENERIC_IRQ_CHIP which is required by the sunxi-nmi irq chip driver = and > >>>> causes build breaks on 4.6-rc1 : > >> > >>>> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > >>>> index b03cfcb..c9626f4 100644 > >>>> --- a/drivers/irqchip/Makefile > >>>> +++ b/drivers/irqchip/Makefile > >>>> @@ -19,8 +19,8 @@ obj-$(CONFIG_CLPS711X_IRQCHIP) +=3D > >>>> irq-clps711x.o > >>>> obj-$(CONFIG_OR1K_PIC) +=3D irq-or1k-pic.o > >>>> obj-$(CONFIG_ORION_IRQCHIP) +=3D irq-orion.o > >>>> obj-$(CONFIG_OMAP_IRQCHIP) +=3D irq-omap-intc.o > >>>> -obj-$(CONFIG_ARCH_SUNXI) +=3D irq-sun4i.o > >>>> -obj-$(CONFIG_ARCH_SUNXI) +=3D irq-sunxi-nmi.o > >>>> +obj-$(CONFIG_SUNXI_IRQCHIP) +=3D irq-sun4i.o > >>>> +obj-$(CONFIG_SUNXI_IRQCHIP) +=3D irq-sunxi-nmi.o > >>> > >>> Those are two different drivers, that should be selected by different > >>> SoCs (MACH_SUN4I and MACH_SUN5I for the former, SUN6I, SUN7I and SUN8I > >>> for the latter) >=20 > But actually they aren't at the moment - and this is a post-rc1 fix, so > I'd prefer to not introduce this right now. >=20 > I can bake a proper patch for 4.7 which separates the two, if people > want this change. >=20 > >> OK. I had thought about that, but wasn't sure who needs what. So went > >> with > >> what existed already. I can respin it. >=20 > I would rather not do this right now. > Maxime, can't we just go with this patch? That seems like the proper fix > for this part of the release cycle to me. I don't really see the difference. We're going to shuffle around Kconfig options anyway. But yeah, if we have a patch properly fixing it in 4.7, fine by me. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --LwgCY5hL6Igino+O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXD8+JAAoJEBx+YmzsjxAgi4IP/1CIdEQo2D2huipYoEM/i434 uhCA/d34c30Jji7iylDjLsqY8+R5G6JbVsoo85udMa4ifGhuk7qiJ9q+1rtpklZA 5+u/nGCKoy19xQ8eL21UfgsqMqfJbmzsZpBXYzbPI30rdIpe2kcsRPfarJlUXvd2 dDEZ3XuQuL1VLH/e/rJD6TDeiDsWnm3v5jriwr2fEFV3tWf40YfxjayectuzaARA k29XL/eUdCq3N5eLoDyd9WJXQmmekMsLv4+rGMeeo/4G434c12XG2WPIfBH8Uv8I dItL3JanQ3Mr3W1L2+uxiFV/s267yFVIUqlEtAfUkzmHhCvVWfpg7Hf+oa5xMBGR 0Ixr8M9EU4IhtCOb8TrMJtj49XRxYZDZBmMWnG75ZDQjU0H6YyUJAUxaL7oMMShG VjkCGFAEZKgWF91EfTkePoNfRRuaPn3B7FSdfmEaHolVNjL3y9dSXWzs5BVjr9Vt EphIUnBEJf4tr4pXXdH8atE+NJAmmlc4YcT9SSU0g5QzatoV4ypGivk2+sPUjs9k ePJm+c8lPc7CrDVJh/WD9WHdl7GMeqcOsJxDtW+EjSPCBIpVKN4WBcW7/AD7AP/t 6KSCunu/TmNkjcRDUhpCPJn6R57uKYg5Zc2Fk4NmsCrOBEgm1jxmuDyHlX/09aNj CB3QfpZqjOAEOvf0lVov =+EUn -----END PGP SIGNATURE----- --LwgCY5hL6Igino+O-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Thu, 14 Apr 2016 19:12:41 +0200 Subject: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP In-Reply-To: <570F5F94.1090602@arm.com> References: <1460563167-18517-1-git-send-email-suzuki.poulose@arm.com> <20160413200735.GC4005@lukather> <570F5932.2020809@arm.com> <570F5B5B.90302@arm.com> <570F5F94.1090602@arm.com> Message-ID: <20160414171241.GQ4005@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 14, 2016 at 10:15:00AM +0100, Andre Przywara wrote: > Hi, > > On 14/04/16 09:56, Suzuki K Poulose wrote: > > On 14/04/16 09:47, Suzuki K Poulose wrote: > >> On 13/04/16 21:07, Maxime Ripard wrote: > >>> Hi, > >>> > >>> On Wed, Apr 13, 2016 at 04:59:27PM +0100, Suzuki K Poulose wrote: > >>>> The sunxi-nmi and sun4i irq chips are selected by ARCH_SUNXI on both > >>>> arm > >>>> and arm64 (recently added). However on arm64, we don't explicitly > >>>> select > >>>> GENERIC_IRQ_CHIP which is required by the sunxi-nmi irq chip driver and > >>>> causes build breaks on 4.6-rc1 : > >> > >>>> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > >>>> index b03cfcb..c9626f4 100644 > >>>> --- a/drivers/irqchip/Makefile > >>>> +++ b/drivers/irqchip/Makefile > >>>> @@ -19,8 +19,8 @@ obj-$(CONFIG_CLPS711X_IRQCHIP) += > >>>> irq-clps711x.o > >>>> obj-$(CONFIG_OR1K_PIC) += irq-or1k-pic.o > >>>> obj-$(CONFIG_ORION_IRQCHIP) += irq-orion.o > >>>> obj-$(CONFIG_OMAP_IRQCHIP) += irq-omap-intc.o > >>>> -obj-$(CONFIG_ARCH_SUNXI) += irq-sun4i.o > >>>> -obj-$(CONFIG_ARCH_SUNXI) += irq-sunxi-nmi.o > >>>> +obj-$(CONFIG_SUNXI_IRQCHIP) += irq-sun4i.o > >>>> +obj-$(CONFIG_SUNXI_IRQCHIP) += irq-sunxi-nmi.o > >>> > >>> Those are two different drivers, that should be selected by different > >>> SoCs (MACH_SUN4I and MACH_SUN5I for the former, SUN6I, SUN7I and SUN8I > >>> for the latter) > > But actually they aren't at the moment - and this is a post-rc1 fix, so > I'd prefer to not introduce this right now. > > I can bake a proper patch for 4.7 which separates the two, if people > want this change. > > >> OK. I had thought about that, but wasn't sure who needs what. So went > >> with > >> what existed already. I can respin it. > > I would rather not do this right now. > Maxime, can't we just go with this patch? That seems like the proper fix > for this part of the release cycle to me. I don't really see the difference. We're going to shuffle around Kconfig options anyway. But yeah, if we have a patch properly fixing it in 4.7, fine by me. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: