Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 1/2] qemu-io: Support 'aio_write -z'

From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 1/2] qemu-io: Support 'aio_write -z'
Date: Fri, 15 Apr 2016 10:18:22 +0200	[thread overview]
Message-ID: <20160415081822.GB4341@noname.redhat.com> (raw)
In-Reply-To: <57102473.3070807@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

Am 15.04.2016 um 01:14 hat Max Reitz geschrieben:
> On 13.04.2016 13:06, Kevin Wolf wrote:
> > This allows testing blk_aio_write_zeroes().
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  qemu-io-cmds.c | 64 +++++++++++++++++++++++++++++++++++++++++++---------------
> >  1 file changed, 48 insertions(+), 16 deletions(-)
> 
> Despite the continuing use of int instead of bool where the latter would
> be appropriate and of "9" instead of "BDRV_SECTOR_BITS":

I considered whether to use bool, but having a few ints and then a bool
for flags in the same struct would be inconsistent. We can have a
cleanup patch on top that changes all instances.

Same thing really with the explicit 9. I didn't even notice it, but this
is just copied code and changing it in one instance only would be
inconsistent.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]