From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH] powerpc: Add SPRs migration test Date: Fri, 15 Apr 2016 10:43:12 +0200 Message-ID: <20160415084312.26fhcdltgcuiv3az@hawk.localdomain> References: <1460115329-21611-1-git-send-email-thuth@redhat.com> <20160411115507.524f8f9f@voom.fritz.box> <570B6D22.50104@redhat.com> <20160412112108.5ed39dfc@voom.fritz.box> <570F5265.9030204@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Huth , kvm@vger.kernel.org To: Greg Harmon Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40701 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbcDOInQ (ORCPT ); Fri, 15 Apr 2016 04:43:16 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Apr 14, 2016 at 09:43:10AM -0700, Greg Harmon wrote: > On Thu, Apr 14, 2016 at 1:18 AM, Thomas Huth wrote: > > On 12.04.2016 23:32, Greg Harmon wrote: > >> David Gibson redhat.com> writes: > >>> On Mon, 11 Apr 2016 11:23:46 +0200 > >>> Thomas Huth redhat.com> wrote: > >>>> On 11.04.2016 03:55, David Gibson wrote: > >>>>> On Fri, 8 Apr 2016 13:35:29 +0200 > >>>>> Thomas Huth redhat.com> wrote: > >>>>> > >>>>>> This test can be used to check whether the SPR (special purpose > >>>>>> registers) of the PowerPC CPU are migrated right. It first fills > >>>>>> the various SPRs with some non-zero value, then reads the values > >>>>>> back into a first array, then waits for a key (with the '-w' option) > >>>>>> so that it is possible to migrate the VM, and finally reads the > >>>>>> values from the SPRs back into another array and then compares it > >>>>>> with the initial values. > >> > >> Hi, > >> In order to make this test automated, what if we extend the test device to > >> return a save/restore generation number? It can report that in a > >> register,and then the test can spin, waiting for that value to increase. > > > > The test device only works on x86, as far as I know, so I'm afraid it's > > not usable for this case here on PowerPC. > > That's too bad that test device doesn't run on PowerPC. I'll try to > send a patch sometime to add this type of register to the test device. The current plan for powerpc testdev is to use chr-testdev (see backends/testdev.c in qemu src), like arm does. Also the current plan to use it is to bind it to an spapr-vty. Of course plans can change in light of better proposals, but that's where things were left. chr- testdev currently only has one function (debugexit), which doesn't require a read function, so we'll need to add one to support a generation number feature. Thanks, drew > > Thanks, > Greg > > > > > Thomas > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html