All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] memcached: fix musl build
@ 2016-04-15  5:19 Baruch Siach
  2016-04-15  7:36 ` Thomas Petazzoni
  2016-04-16 14:48 ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2016-04-15  5:19 UTC (permalink / raw)
  To: buildroot

Add a patch fixing pre-processor warnings that breaks the build. The patch is
pending upstream.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../memcached/0001-fix-build-with-musl-libc.patch  | 78 ++++++++++++++++++++++
 1 file changed, 78 insertions(+)
 create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patch

diff --git a/package/memcached/0001-fix-build-with-musl-libc.patch b/package/memcached/0001-fix-build-with-musl-libc.patch
new file mode 100644
index 000000000000..068382051cde
--- /dev/null
+++ b/package/memcached/0001-fix-build-with-musl-libc.patch
@@ -0,0 +1,78 @@
+From 2137a608c77c467200d73469f723ba97ff6b3511 Mon Sep 17 00:00:00 2001
+From: Natanael Copa <ncopa@alpinelinux.org>
+Date: Mon, 18 Jan 2016 12:11:48 +0100
+Subject: [PATCH] fix build with musl libc
+
+musl libc will warn if you include sys/signal.h instead of signal.h as
+specified by posix. Build will fail due to -Werror explicitly beeing
+set.
+
+Fix it by use the posix location.
+
+fixes #138
+
+Signed-off-by: Baruch Siach <baruch@tkos.co.il>
+---
+Patch status: pending (https://github.com/memcached/memcached/pull/139)
+
+ assoc.c | 2 +-
+ items.c | 2 +-
+ slabs.c | 2 +-
+ 3 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/assoc.c b/assoc.c
+index e6cf09b64e8c..9fff38fe01d6 100644
+--- a/assoc.c
++++ b/assoc.c
+@@ -14,8 +14,8 @@
+ #include "memcached.h"
+ #include <sys/stat.h>
+ #include <sys/socket.h>
+-#include <sys/signal.h>
+ #include <sys/resource.h>
++#include <signal.h>
+ #include <fcntl.h>
+ #include <netinet/in.h>
+ #include <errno.h>
+diff --git a/items.c b/items.c
+index 199dc9fa6e6b..7040777ab0fb 100644
+--- a/items.c
++++ b/items.c
+@@ -2,13 +2,13 @@
+ #include "memcached.h"
+ #include <sys/stat.h>
+ #include <sys/socket.h>
+-#include <sys/signal.h>
+ #include <sys/resource.h>
+ #include <fcntl.h>
+ #include <netinet/in.h>
+ #include <errno.h>
+ #include <stdlib.h>
+ #include <stdio.h>
++#include <signal.h>
+ #include <string.h>
+ #include <time.h>
+ #include <assert.h>
+diff --git a/slabs.c b/slabs.c
+index 31e85f6ec21d..bfafe5d0fdde 100644
+--- a/slabs.c
++++ b/slabs.c
+@@ -10,7 +10,6 @@
+ #include "memcached.h"
+ #include <sys/stat.h>
+ #include <sys/socket.h>
+-#include <sys/signal.h>
+ #include <sys/resource.h>
+ #include <fcntl.h>
+ #include <netinet/in.h>
+@@ -18,6 +17,7 @@
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <string.h>
++#include <signal.h>
+ #include <assert.h>
+ #include <pthread.h>
+ 
+-- 
+2.8.0.rc3
+
-- 
2.8.0.rc3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] memcached: fix musl build
  2016-04-15  5:19 [Buildroot] [PATCH] memcached: fix musl build Baruch Siach
@ 2016-04-15  7:36 ` Thomas Petazzoni
  2016-04-16 14:48 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-04-15  7:36 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 15 Apr 2016 08:19:11 +0300, Baruch Siach wrote:
> Add a patch fixing pre-processor warnings that breaks the build. The patch is
> pending upstream.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  .../memcached/0001-fix-build-with-musl-libc.patch  | 78 ++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patch

I've added a reference to the autobuilder failure being fixed by this
patch, and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] memcached: fix musl build
  2016-04-15  5:19 [Buildroot] [PATCH] memcached: fix musl build Baruch Siach
  2016-04-15  7:36 ` Thomas Petazzoni
@ 2016-04-16 14:48 ` Peter Korsgaard
  2016-04-16 19:30   ` Baruch Siach
  1 sibling, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2016-04-16 14:48 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Add a patch fixing pre-processor warnings that breaks the build. The patch is
 > pending upstream.

 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
 > ---
 >  .../memcached/0001-fix-build-with-musl-libc.patch  | 78 ++++++++++++++++++++++
 >  1 file changed, 78 insertions(+)
 >  create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patch

 > diff --git a/package/memcached/0001-fix-build-with-musl-libc.patch
 > b/package/memcached/0001-fix-build-with-musl-libc.patch
 > new file mode 100644
 > index 000000000000..068382051cde
 > --- /dev/null
 > +++ b/package/memcached/0001-fix-build-with-musl-libc.patch
 > @@ -0,0 +1,78 @@
 > +From 2137a608c77c467200d73469f723ba97ff6b3511 Mon Sep 17 00:00:00 2001
 > +From: Natanael Copa <ncopa@alpinelinux.org>
 > +Date: Mon, 18 Jan 2016 12:11:48 +0100
 > +Subject: [PATCH] fix build with musl libc
 > +
 > +musl libc will warn if you include sys/signal.h instead of signal.h as
 > +specified by posix. Build will fail due to -Werror explicitly beeing
 > +set.

Is there any way to disable -Werror? -Werror should imho not be used for
any released SW as it tends to break the build time and again.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] memcached: fix musl build
  2016-04-16 14:48 ` Peter Korsgaard
@ 2016-04-16 19:30   ` Baruch Siach
  0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2016-04-16 19:30 UTC (permalink / raw)
  To: buildroot

Hi Peter,

On Sat, Apr 16, 2016 at 04:48:11PM +0200, Peter Korsgaard wrote:
> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> 
>  > Add a patch fixing pre-processor warnings that breaks the build. The patch is
>  > pending upstream.
> 
>  > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>  > ---
>  >  .../memcached/0001-fix-build-with-musl-libc.patch  | 78 ++++++++++++++++++++++
>  >  1 file changed, 78 insertions(+)
>  >  create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patch
> 
>  > diff --git a/package/memcached/0001-fix-build-with-musl-libc.patch
>  > b/package/memcached/0001-fix-build-with-musl-libc.patch
>  > new file mode 100644
>  > index 000000000000..068382051cde
>  > --- /dev/null
>  > +++ b/package/memcached/0001-fix-build-with-musl-libc.patch
>  > @@ -0,0 +1,78 @@
>  > +From 2137a608c77c467200d73469f723ba97ff6b3511 Mon Sep 17 00:00:00 2001
>  > +From: Natanael Copa <ncopa@alpinelinux.org>
>  > +Date: Mon, 18 Jan 2016 12:11:48 +0100
>  > +Subject: [PATCH] fix build with musl libc
>  > +
>  > +musl libc will warn if you include sys/signal.h instead of signal.h as
>  > +specified by posix. Build will fail due to -Werror explicitly beeing
>  > +set.
> 
> Is there any way to disable -Werror? -Werror should imho not be used for
> any released SW as it tends to break the build time and again.

Removing -Werror requires patching configure.ac. It's not required at this 
point with this patch applied. We can always do it later if it's needed.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-04-16 19:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-15  5:19 [Buildroot] [PATCH] memcached: fix musl build Baruch Siach
2016-04-15  7:36 ` Thomas Petazzoni
2016-04-16 14:48 ` Peter Korsgaard
2016-04-16 19:30   ` Baruch Siach

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.