From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751319AbcDPJH2 (ORCPT ); Sat, 16 Apr 2016 05:07:28 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47786 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751155AbcDPJHY (ORCPT ); Sat, 16 Apr 2016 05:07:24 -0400 Date: Sat, 16 Apr 2016 11:07:20 +0200 From: Boris Brezillon To: Han Xu Cc: Roger Quadros , Tony Lindgren , Wenyou Yang , Josh Wu , Boris Brezillon , Richard Weinberger , linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Kamal Dasu , Ezequiel Garcia , Stefan Agner , linux-omap@vger.kernel.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Daniel Mack , Haojian Zhuang , Robert Jarzmik , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Zhou Wang , Alex Smith , Harvey Hunt Subject: Re: [PATCH 06/12] mtd: nand: gpmi: rely on generic DT parsing done in nand_scan_ident() Message-ID: <20160416110720.462822e6@bbrezillon> In-Reply-To: <1459515272-31011-7-git-send-email-boris.brezillon@free-electrons.com> References: <1459515272-31011-1-git-send-email-boris.brezillon@free-electrons.com> <1459515272-31011-7-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Han, On Fri, 1 Apr 2016 14:54:26 +0200 Boris Brezillon wrote: > The core now takes care of parsing generic DT properties in > nand_scan_ident() when nand_set_flash_node() has been called. > Rely on this initialization instead of calling of_get_nand_xxx() > manually. Can you review/test this patch? I'd like to have the whole series merged in this release. Thanks, Boris > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index 8122c69..c6e8a1c 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include "gpmi-nand.h" > #include "bch-regs.h" > > @@ -1914,16 +1913,6 @@ static int gpmi_nand_init(struct gpmi_nand_data *this) > /* Set up swap_block_mark, must be set before the gpmi_set_geometry() */ > this->swap_block_mark = !GPMI_IS_MX23(this); > > - if (of_get_nand_on_flash_bbt(this->dev->of_node)) { > - chip->bbt_options |= NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB; > - > - if (of_property_read_bool(this->dev->of_node, > - "fsl,no-blockmark-swap")) > - this->swap_block_mark = false; > - } > - dev_dbg(this->dev, "Blockmark swapping %sabled\n", > - this->swap_block_mark ? "en" : "dis"); > - > /* > * Allocate a temporary DMA buffer for reading ID in the > * nand_scan_ident(). > @@ -1938,6 +1927,16 @@ static int gpmi_nand_init(struct gpmi_nand_data *this) > if (ret) > goto err_out; > > + if (chip->bbt_options & NAND_BBT_USE_FLASH) { > + chip->bbt_options |= NAND_BBT_NO_OOB; > + > + if (of_property_read_bool(this->dev->of_node, > + "fsl,no-blockmark-swap")) > + this->swap_block_mark = false; > + } > + dev_dbg(this->dev, "Blockmark swapping %sabled\n", > + this->swap_block_mark ? "en" : "dis"); > + > ret = gpmi_init_last(this); > if (ret) > goto err_out; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 06/12] mtd: nand: gpmi: rely on generic DT parsing done in nand_scan_ident() Date: Sat, 16 Apr 2016 11:07:20 +0200 Message-ID: <20160416110720.462822e6@bbrezillon> References: <1459515272-31011-1-git-send-email-boris.brezillon@free-electrons.com> <1459515272-31011-7-git-send-email-boris.brezillon@free-electrons.com> Reply-To: boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <1459515272-31011-7-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Han Xu Cc: Roger Quadros , Tony Lindgren , Wenyou Yang , Josh Wu , Boris Brezillon , Richard Weinberger , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, David Woodhouse , Brian Norris , Kamal Dasu , Ezequiel Garcia , Stefan Agner , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn List-Id: linux-omap@vger.kernel.org Hi Han, On Fri, 1 Apr 2016 14:54:26 +0200 Boris Brezillon wrote: > The core now takes care of parsing generic DT properties in > nand_scan_ident() when nand_set_flash_node() has been called. > Rely on this initialization instead of calling of_get_nand_xxx() > manually. Can you review/test this patch? I'd like to have the whole series merged in this release. Thanks, Boris > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index 8122c69..c6e8a1c 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include "gpmi-nand.h" > #include "bch-regs.h" > > @@ -1914,16 +1913,6 @@ static int gpmi_nand_init(struct gpmi_nand_data *this) > /* Set up swap_block_mark, must be set before the gpmi_set_geometry() */ > this->swap_block_mark = !GPMI_IS_MX23(this); > > - if (of_get_nand_on_flash_bbt(this->dev->of_node)) { > - chip->bbt_options |= NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB; > - > - if (of_property_read_bool(this->dev->of_node, > - "fsl,no-blockmark-swap")) > - this->swap_block_mark = false; > - } > - dev_dbg(this->dev, "Blockmark swapping %sabled\n", > - this->swap_block_mark ? "en" : "dis"); > - > /* > * Allocate a temporary DMA buffer for reading ID in the > * nand_scan_ident(). > @@ -1938,6 +1927,16 @@ static int gpmi_nand_init(struct gpmi_nand_data *this) > if (ret) > goto err_out; > > + if (chip->bbt_options & NAND_BBT_USE_FLASH) { > + chip->bbt_options |= NAND_BBT_NO_OOB; > + > + if (of_property_read_bool(this->dev->of_node, > + "fsl,no-blockmark-swap")) > + this->swap_block_mark = false; > + } > + dev_dbg(this->dev, "Blockmark swapping %sabled\n", > + this->swap_block_mark ? "en" : "dis"); > + > ret = gpmi_init_last(this); > if (ret) > goto err_out; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Sat, 16 Apr 2016 11:07:20 +0200 Subject: [PATCH 06/12] mtd: nand: gpmi: rely on generic DT parsing done in nand_scan_ident() In-Reply-To: <1459515272-31011-7-git-send-email-boris.brezillon@free-electrons.com> References: <1459515272-31011-1-git-send-email-boris.brezillon@free-electrons.com> <1459515272-31011-7-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <20160416110720.462822e6@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Han, On Fri, 1 Apr 2016 14:54:26 +0200 Boris Brezillon wrote: > The core now takes care of parsing generic DT properties in > nand_scan_ident() when nand_set_flash_node() has been called. > Rely on this initialization instead of calling of_get_nand_xxx() > manually. Can you review/test this patch? I'd like to have the whole series merged in this release. Thanks, Boris > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index 8122c69..c6e8a1c 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include "gpmi-nand.h" > #include "bch-regs.h" > > @@ -1914,16 +1913,6 @@ static int gpmi_nand_init(struct gpmi_nand_data *this) > /* Set up swap_block_mark, must be set before the gpmi_set_geometry() */ > this->swap_block_mark = !GPMI_IS_MX23(this); > > - if (of_get_nand_on_flash_bbt(this->dev->of_node)) { > - chip->bbt_options |= NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB; > - > - if (of_property_read_bool(this->dev->of_node, > - "fsl,no-blockmark-swap")) > - this->swap_block_mark = false; > - } > - dev_dbg(this->dev, "Blockmark swapping %sabled\n", > - this->swap_block_mark ? "en" : "dis"); > - > /* > * Allocate a temporary DMA buffer for reading ID in the > * nand_scan_ident(). > @@ -1938,6 +1927,16 @@ static int gpmi_nand_init(struct gpmi_nand_data *this) > if (ret) > goto err_out; > > + if (chip->bbt_options & NAND_BBT_USE_FLASH) { > + chip->bbt_options |= NAND_BBT_NO_OOB; > + > + if (of_property_read_bool(this->dev->of_node, > + "fsl,no-blockmark-swap")) > + this->swap_block_mark = false; > + } > + dev_dbg(this->dev, "Blockmark swapping %sabled\n", > + this->swap_block_mark ? "en" : "dis"); > + > ret = gpmi_init_last(this); > if (ret) > goto err_out; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com