All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] memcached: fix musl build
Date: Sat, 16 Apr 2016 22:30:20 +0300	[thread overview]
Message-ID: <20160416193020.GA2476@tarshish> (raw)
In-Reply-To: <871t65fw44.fsf@dell.be.48ers.dk>

Hi Peter,

On Sat, Apr 16, 2016 at 04:48:11PM +0200, Peter Korsgaard wrote:
> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> 
>  > Add a patch fixing pre-processor warnings that breaks the build. The patch is
>  > pending upstream.
> 
>  > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>  > ---
>  >  .../memcached/0001-fix-build-with-musl-libc.patch  | 78 ++++++++++++++++++++++
>  >  1 file changed, 78 insertions(+)
>  >  create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patch
> 
>  > diff --git a/package/memcached/0001-fix-build-with-musl-libc.patch
>  > b/package/memcached/0001-fix-build-with-musl-libc.patch
>  > new file mode 100644
>  > index 000000000000..068382051cde
>  > --- /dev/null
>  > +++ b/package/memcached/0001-fix-build-with-musl-libc.patch
>  > @@ -0,0 +1,78 @@
>  > +From 2137a608c77c467200d73469f723ba97ff6b3511 Mon Sep 17 00:00:00 2001
>  > +From: Natanael Copa <ncopa@alpinelinux.org>
>  > +Date: Mon, 18 Jan 2016 12:11:48 +0100
>  > +Subject: [PATCH] fix build with musl libc
>  > +
>  > +musl libc will warn if you include sys/signal.h instead of signal.h as
>  > +specified by posix. Build will fail due to -Werror explicitly beeing
>  > +set.
> 
> Is there any way to disable -Werror? -Werror should imho not be used for
> any released SW as it tends to break the build time and again.

Removing -Werror requires patching configure.ac. It's not required at this 
point with this patch applied. We can always do it later if it's needed.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

      reply	other threads:[~2016-04-16 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15  5:19 [Buildroot] [PATCH] memcached: fix musl build Baruch Siach
2016-04-15  7:36 ` Thomas Petazzoni
2016-04-16 14:48 ` Peter Korsgaard
2016-04-16 19:30   ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160416193020.GA2476@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.