All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: dts: socfpga: fix DTC unit name warnings
Date: Sun, 17 Apr 2016 23:55:04 +0200	[thread overview]
Message-ID: <20160417215504.GB20337@amd> (raw)
In-Reply-To: <1460716862-21523-1-git-send-email-hs@denx.de>

Hi!

> Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
>  but no reg property

I don't know who produces the warnings, but perhaps fix the tool,
instead?

> @@ -9,5 +9,5 @@
>  	#size-cells = <1>;
>  	chosen { };
>  	aliases { };
> -	memory { device_type = "memory"; reg = <0 0>; };
> +	memory at 0 { device_type = "memory"; reg = <0 0>; };
>  };

This does not look like an improvement to me...

> @@ -128,7 +128,7 @@
>  						compatible = "fixed-clock";
>  					};
>  
> -					main_pll: main_pll {
> +					main_pll: main_pll at 40 {
>  						#address-cells = <1>;
>  						#size-cells = <0>;
>  						#clock-cells = <0>;
> @@ -136,7 +136,7 @@
>  						clocks = <&osc1>;
>  						reg = <0x40>;
>  
> -						mpuclk: mpuclk {
> +						mpuclk: mpuclk at 48 {
>  							#clock-cells = <0>;
>  							compatible = "altr,socfpga-perip-clk";
>  							clocks = <&main_pll>;

Neither do these, actually. So we have clock at fixed addresses. Why
is it wrong?

> @@ -742,7 +742,7 @@
>  			reg = <0xffd05000 0x1000>;
>  		};
>  
> -		usbphy0: usbphy at 0 {
> +		usbphy0: usbphy {
>  			#phy-cells = <0>;
>  			compatible = "usb-nop-xceiv";
>  			status = "okay";

And this sounds like a bug waiting to happen..

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2016-04-17 21:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 10:41 [U-Boot] [PATCH] arm: dts: socfpga: fix DTC unit name warnings Heiko Schocher
2016-04-15 14:18 ` Marek Vasut
2016-04-18  4:55   ` Heiko Schocher
2016-04-18 10:36     ` Marek Vasut
2016-04-18 11:20       ` Heiko Schocher
2016-04-18 11:22         ` Marek Vasut
2016-04-17 21:55 ` Pavel Machek [this message]
2016-04-18  6:07   ` Heiko Schocher
2016-04-18 10:00     ` Pavel Machek
2016-04-18 10:35       ` Marek Vasut
2016-04-18 11:06       ` Heiko Schocher
2016-04-18 15:31 ` Tom Rini
2016-04-18 15:37   ` Marek Vasut
2016-04-18 15:46     ` Tom Rini
2016-04-18 17:52       ` Marek Vasut
2016-04-19  5:01         ` Heiko Schocher
2016-04-19 10:38           ` Marek Vasut
2016-04-19  4:47       ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160417215504.GB20337@amd \
    --to=pavel@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.