From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 0/4] ASoC: add graph base connection on simple-card Date: Mon, 18 Apr 2016 12:12:48 -0500 Message-ID: <20160418171248.GA18460@rob-hp-laptop> References: <871t68wxxe.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <871t68wxxe.wl%kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Kuninori Morimoto Cc: Jose Abreu , Linux-DT , Linux-ALSA , Lars-Peter Clausen , Mark Brown , Liam Girdwood , Linux-Renesas , Simon , Laurent List-Id: devicetree@vger.kernel.org On Thu, Apr 14, 2016 at 05:45:41AM +0000, Kuninori Morimoto wrote: > Hi Mark > > Current simple-card is using "sound-dai" base connection on DT, > but V4L2 is using graph base connection. > For example HDMI case, we would like to use both connection. > To above confusable connection method, and to reuse current resource, > this patch adds new function, and detect both "sound-dai" and "remote-endpoint" > on simple-card. like this > > sound { > compatible = "simple-audio-card"; > ... > sndcpu: simple-audio-card,cpu { > sound-dai = <&xxx>; > }; > sndcodec: simple-audio-card,codec { > => remote-endpoint = <&out_hdmi>; This is not valid usage of the graph binding. You are only using half of it. > }; > }; > > xxx { > ... > ports { > ... > port@0 { > reg = <0>; > out_rgb: endpoint { > }; > }; > port@1 { > reg = <1>; > => out_hdmi: endpoint { > }; > }; > ... > }; > }; > > Kuninori Morimoto (4): > of_graph: add of_graph_get_endpoint_count() > ASoC: add of_parse_snd_connection_with_args() for sound-dai/graph connection > ASoC: snd_soc_of_get_dai_name() uses of_parse_snd_soc_connection_with_args() > ASoC: simple-card: probe both sound-dai and remote-endpoint > > Documentation/devicetree/bindings/sound/simple-card.txt | 19 +++++++++++++++++++ > include/linux/of_graph.h | 11 +++++++++++ > include/sound/soc.h | 2 ++ > sound/soc/generic/simple-card.c | 9 ++++++--- > sound/soc/soc-core.c | 45 +++++++++++++++++++++++++++++++++++++++++++-- > 5 files changed, 81 insertions(+), 5 deletions(-) > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 18 Apr 2016 12:12:48 -0500 From: Rob Herring To: Kuninori Morimoto Cc: Mark Brown , Laurent , Lars-Peter Clausen , Simon , Linux-Renesas , Linux-DT , Linux-ALSA , Liam Girdwood , Jose Abreu Subject: Re: [PATCH 0/4] ASoC: add graph base connection on simple-card Message-ID: <20160418171248.GA18460@rob-hp-laptop> References: <871t68wxxe.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871t68wxxe.wl%kuninori.morimoto.gx@renesas.com> Sender: devicetree-owner@vger.kernel.org List-ID: On Thu, Apr 14, 2016 at 05:45:41AM +0000, Kuninori Morimoto wrote: > Hi Mark > > Current simple-card is using "sound-dai" base connection on DT, > but V4L2 is using graph base connection. > For example HDMI case, we would like to use both connection. > To above confusable connection method, and to reuse current resource, > this patch adds new function, and detect both "sound-dai" and "remote-endpoint" > on simple-card. like this > > sound { > compatible = "simple-audio-card"; > ... > sndcpu: simple-audio-card,cpu { > sound-dai = <&xxx>; > }; > sndcodec: simple-audio-card,codec { > => remote-endpoint = <&out_hdmi>; This is not valid usage of the graph binding. You are only using half of it. > }; > }; > > xxx { > ... > ports { > ... > port@0 { > reg = <0>; > out_rgb: endpoint { > }; > }; > port@1 { > reg = <1>; > => out_hdmi: endpoint { > }; > }; > ... > }; > }; > > Kuninori Morimoto (4): > of_graph: add of_graph_get_endpoint_count() > ASoC: add of_parse_snd_connection_with_args() for sound-dai/graph connection > ASoC: snd_soc_of_get_dai_name() uses of_parse_snd_soc_connection_with_args() > ASoC: simple-card: probe both sound-dai and remote-endpoint > > Documentation/devicetree/bindings/sound/simple-card.txt | 19 +++++++++++++++++++ > include/linux/of_graph.h | 11 +++++++++++ > include/sound/soc.h | 2 ++ > sound/soc/generic/simple-card.c | 9 ++++++--- > sound/soc/soc-core.c | 45 +++++++++++++++++++++++++++++++++++++++++++-- > 5 files changed, 81 insertions(+), 5 deletions(-) > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html