All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Nicolas Boullis <nboullis@debian.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>, rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH] rtc: ds1307: ensure that any pending alarm is cleared before a new alarm is enabled
Date: Tue, 19 Apr 2016 00:28:03 +0200	[thread overview]
Message-ID: <20160418222803.GA25196@piout.net> (raw)
In-Reply-To: <20160410112305.GB3603@haddock.home>

On 10/04/2016 at 13:23:05 +0200, Nicolas Boullis wrote :
> If a previously-set alarm was disabled and then triggered, it may still=
=20
> be pending when a new alarm is configured.
>=20
> Then, if the alarm is enabled before the pending alarm is cleared, then=
=20
> an interrupt is immediately raised.
>=20
> Unfortunately, when the alarm is cleared and enabled during the same I=E6=
=B6=8E=20
> block write, the chip (at least the DS1339 I have) considers that the=20
> alarm is enabled before it is cleared, and raises an interrupt.
>=20
> This patch ensures that the pending alarm is cleared before the alarm is=
=20
> enabled.
>=20
> Signed-off-by: Nicolas Boullis <nboullis@debian.org>
>=20
Applied, thanks.

--=20
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  reply	other threads:[~2016-04-18 22:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-02 22:10 [rtc-linux] [PATCH 2/2] rtc: ds1307: clear the interrupts on probe Nicolas Boullis
2016-04-10 11:23 ` [rtc-linux] [PATCH] rtc: ds1307: ensure that any pending alarm is cleared before a new alarm is enabled Nicolas Boullis
2016-04-18 22:28   ` Alexandre Belloni [this message]
2016-04-21 21:19     ` [rtc-linux] " Nicolas Boullis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418222803.GA25196@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=a.zummo@towertech.it \
    --cc=nboullis@debian.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.