From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbcDTAPy (ORCPT ); Tue, 19 Apr 2016 20:15:54 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38694 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcDTAPx (ORCPT ); Tue, 19 Apr 2016 20:15:53 -0400 Date: Tue, 19 Apr 2016 20:15:50 -0400 (EDT) Message-Id: <20160419.201550.902520333910307559.davem@davemloft.net> To: andrew.goodbody@cambrionix.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs From: David Miller In-Reply-To: <1460987606-18125-1-git-send-email-andrew.goodbody@cambrionix.com> References: <1460987606-18125-1-git-send-email-andrew.goodbody@cambrionix.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Apr 2016 17:15:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Goodbody Date: Mon, 18 Apr 2016 14:53:25 +0100 > This is a fix for a NULL pointer dereference from cpsw which is triggered > by having two slave PHYs attached to a cpsw network device. The problem is > due to only maintaining a single reference to a PHY node in the prive data > which gets overwritten by the second PHY probe. So move the PHY node > reference to the individual slave data so that there is now one per slave. > > v1 had a problem that data->slaves was used before it had been filled in I already applied v1 the other day, so you need to send me a relative patch rather than a whole new one. Thanks.