From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asRg2-0002On-35 for qemu-devel@nongnu.org; Tue, 19 Apr 2016 05:10:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asRfx-0002VV-WF for qemu-devel@nongnu.org; Tue, 19 Apr 2016 05:10:34 -0400 Date: Tue, 19 Apr 2016 10:10:27 +0100 From: Stefan Hajnoczi Message-ID: <20160419091027.GB16312@stefanha-x1.localdomain> References: <1460046816-102846-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rS8CxjVDS/+yyDmU" Content-Disposition: inline In-Reply-To: <1460046816-102846-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/8] bdrv_flush_io_queue removal, shared LinuxAioState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com --rS8CxjVDS/+yyDmU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 07, 2016 at 06:33:28PM +0200, Paolo Bonzini wrote: > Patch 1 comes from Kevin's series to do BlockBackend throttling. >=20 > Patches 2-6 are from my bdrv_drain patches. They apply on top of Fam's > patch (which will be in 2.6) that introduces bdrv_co_drain. Patch 4 > is new in this version, compared to v3. >=20 > Patches 7-8 are new but based on Ming Lei's old submission. > I'm including them here because they apply on top of patches 2-6. >=20 > Kevin Wolf (1): > block: Don't disable I/O throttling on sync requests >=20 > Paolo Bonzini (7): > block: make bdrv_start_throttled_reqs return void > block: move restarting of throttled reqs to block/throttle-groups.c > block: extract bdrv_drain_poll/bdrv_co_yield_to_drain from > bdrv_drain/bdrv_co_drain > block: introduce bdrv_no_throttling_begin/end > block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end > linux-aio: make it more type safe > linux-aio: share one LinuxAioState within an AioContext >=20 > async.c | 23 +++++ > block.c | 1 - > block/block-backend.c | 6 +- > block/io.c | 168 ++++++++++++++++++++++---------= ------ > block/linux-aio.c | 60 ++++++------- > block/raw-posix.c | 133 ++++------------------------- > block/raw-win32.c | 2 +- > block/throttle-groups.c | 18 ++++ > include/block/aio.h | 13 +++ > include/block/block.h | 3 +- > include/block/block_int.h | 14 +++- > {block =3D> include/block}/raw-aio.h | 15 ++-- > include/block/throttle-groups.h | 1 + > 13 files changed, 216 insertions(+), 241 deletions(-) > rename {block =3D> include/block}/raw-aio.h (80%) Looks good overall. I have reservations about the last patch, see my reply there. Acked-by: Stefan Hajnoczi --rS8CxjVDS/+yyDmU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXFfYDAAoJEJykq7OBq3PImw0H/j6VN+79MP6Y4nkqE88PpfIq RFlxqwRIe7VhkA/UcxfbTT1zCQZJSbcH2Atkcpm43H4km51jRn4ExTij4LVOcBNQ vBdN9vfyWG5FjKvu4Mt/jr3/aiuoW2VTLGaVtJe7GF8/gX2BvTuLaF/UCozGeClA 1pM9YdV51B3ZRlMoDGEjkUL2zIzbz2SOR91EtIppRy3T47KUSWz4ZE7B/6RU0XJ0 fJ0+sLzOgh3HCZIp7S/3XfX7xluLgv/+exQNnlHY9t5yThyD624JyoNM0HCMM7G4 OzLp3AodhxVeiWkXU7gjjfxTWU4hDXutb3NKzAqW7e4OxCSe1/Sesm4kF2xAX4s= =2Xfm -----END PGP SIGNATURE----- --rS8CxjVDS/+yyDmU--