From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC PATCH 2/2] drm/i915/bxt: Adjusting the error in horizontal timings retrieval Date: Wed, 20 Apr 2016 15:26:47 +0200 Message-ID: <20160420132647.GH2510@phenom.ffwll.local> References: <1461053894-5058-1-git-send-email-ramalingam.c@intel.com> <1461053894-5058-2-git-send-email-ramalingam.c@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A0D46E161 for ; Wed, 20 Apr 2016 13:26:52 +0000 (UTC) Received: by mail-wm0-x22b.google.com with SMTP id v188so203567947wme.1 for ; Wed, 20 Apr 2016 06:26:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1461053894-5058-2-git-send-email-ramalingam.c@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ramalingam C Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBcHIgMTksIDIwMTYgYXQgMDE6NDg6MTRQTSArMDUzMCwgUmFtYWxpbmdhbSBDIHdy b3RlOgo+IEluIEJYVCBEU0kgdGhlcmUgaXMgbm8gcmVncyBwcm9ncmFtbWVkIHdpdGggZmV3IGhv cml6b250YWwgdGltaW5ncwo+IGluIFBpeGVscyBidXQgdHhieXRlY2xraHMuLiBTbyByZXRyaWV2 YWwgcHJvY2VzcyBhZGRzIHNvbWUKPiBST1VORF9VUCBFUlJPUlMgaW4gdGhlIHByb2Nlc3Mgb2Yg UElYRUxTPD09PnR4Ynl0ZWNsa2hzLgo+IAo+IEFjdHVhbGx5IGhlcmUgZm9yIHRoZSBnaXZlbiBh ZGp1c3RlZF9tb2RlLCB3ZSBhcmUgY2FsY3VsYXRpbmcgdGhlCj4gdmFsdWUgcHJvZ3JhbW1lZCB0 byB0aGUgcG9ydCBhbmQgdGhlbiBiYWNrIHRvIHRoZSBob3Jpem9udGFsIHRpbWluZwo+IHBhcmFt IGluIHBpeGVscy4gVGhpcyBpcyB0aGUgZXhwZWN0ZWQgdmFsdWUgYXQgdGhlIGVuZCBvZiBnZXRf Y29uZmlnLAo+IGluY2x1ZGluZyByb3VuZHVwIGVycm9ycy4gQW5kIGlmIHRoYXQgaXMgc2FtZSBh cyByZXRyaWV2ZWQgdmFsdWUKPiBmcm9tIHBvcnQsIHRoZW4gcmV0cmlldmVkIChIVyBzdGF0ZSkg YWRqdXN0ZWRfbW9kZSdzIGhvcml6b250YWwKPiB0aW1pbmdzIGFyZSBjb3JyZWN0ZWQgdG8gbWF0 Y2ggd2l0aCBTVyBzdGF0ZSB0byBudWxsaWZ5IHRoZSBlcnJvcnMuCj4gCj4gU2lnbmVkLW9mZi1i eTogUmFtYWxpbmdhbSBDIDxyYW1hbGluZ2FtLmNAaW50ZWwuY29tPgoKSSBkaWRuJ3QgY2hlY2sg dGhlIGRldGFpbHMsIGJ1dCBJIHRoaW5rIHRoaXMgaXMgdGhlIGZpeCB3ZSB3YW50LiBTdGlsbApu ZWVkcyBpbi1kZXB0aCByZXZpZXcsIGFuZCBzb21lIHRlc3Rpbmcgb24gYSBmZXcgZGlmZmVyZW50 IGRzaSBieHQKbWFjaGluZXMganVzdCB0byBtYWtlIHN1cmUgSSB0aGluaywgYnV0IG9uIGJvdGgg cGF0Y2hlczoKCkFja2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNo PgoKQ2hlZXJzLCBEYW5pZWwKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNp LmMgfCAgIDk3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tCj4gIDEgZmls ZSBjaGFuZ2VkLCA4OCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RzaS5jCj4gaW5kZXggZTAyNTllNi4uOGExYjg3MiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RzaS5jCj4gQEAgLTQ2LDYgKzQ2LDE0IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg ewo+ICAJfSwKPiAgfTsKPiAgCj4gKy8qIHJldHVybiBwaXhlbHMgaW4gdGVybXMgb2YgdHhieXRl Y2xraHMgKi8KPiArc3RhdGljIHUxNiB0eGJ5dGVjbGtocyh1MTYgcGl4ZWxzLCBpbnQgYnBwLCBp bnQgbGFuZV9jb3VudCwKPiArCQkgICAgICAgdTE2IGJ1cnN0X21vZGVfcmF0aW8pCj4gK3sKPiAr CXJldHVybiBESVZfUk9VTkRfVVAoRElWX1JPVU5EX1VQKHBpeGVscyAqIGJwcCAqIGJ1cnN0X21v ZGVfcmF0aW8sCj4gKwkJCQkJIDggKiAxMDApLCBsYW5lX2NvdW50KTsKPiArfQo+ICsKPiAgLyog cmV0dXJuIHBpeGVscyBlcXV2YWxlbnQgdG8gdHhieXRlY2xraHMgKi8KPiAgc3RhdGljIHUxNiBw aXhlbHNfZnJvbV90eGJ5dGVjbGtocyh1MTYgY2xrX2hzLCBpbnQgYnBwLCBpbnQgbGFuZV9jb3Vu dCwKPiAgCQkJdTE2IGJ1cnN0X21vZGVfcmF0aW8pCj4gQEAgLTc3OSwxMSArNzg3LDE5IEBAIHN0 YXRpYyB2b2lkIGJ4dF9kc2lfZ2V0X3BpcGVfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICpl bmNvZGVyLAo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZf cHJpdmF0ZTsKPiAgCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2RlID0KPiAg CQkJCQkmcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPiArCXN0cnVjdCBkcm1fZGlz cGxheV9tb2RlICphZGp1c3RlZF9tb2RlX3N3Owo+ICsJc3RydWN0IGludGVsX2NydGMgKmludGVs X2NydGM7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2kgPSBlbmNfdG9faW50ZWxfZHNp KCZlbmNvZGVyLT5iYXNlKTsKPiAgCXVuc2lnbmVkIGludCBsYW5lX2NvdW50ID0gaW50ZWxfZHNp LT5sYW5lX2NvdW50Owo+ICAJdW5zaWduZWQgaW50IGJwcCwgZm10Owo+ICAJZW51bSBwb3J0IHBv cnQ7Cj4gIAl1MTYgaGFjdGl2ZSwgaGZwLCBoc3luYywgaGJwLCB2ZnAsIHZzeW5jLCB2YnA7Cj4g Kwl1MTYgaGZwX3N3LCBoc3luY19zdywgaGJwX3N3Owo+ICsJdTE2IGNydGNfaHRvdGFsX3N3LCBj cnRjX2hzeW5jX3N0YXJ0X3N3LCBjcnRjX2hzeW5jX2VuZF9zdywKPiArCQkJCWNydGNfaGJsYW5r X3N0YXJ0X3N3LCBjcnRjX2hibGFua19lbmRfc3c7Cj4gKwo+ICsJaW50ZWxfY3J0YyA9IHRvX2lu dGVsX2NydGMoZW5jb2Rlci0+YmFzZS5jcnRjKTsKPiArCWFkanVzdGVkX21vZGVfc3cgPSAmaW50 ZWxfY3J0Yy0+Y29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGU7Cj4gIAo+ICAJLyoKPiAgCSAqIEF0 bGVhc3Qgb25lIHBvcnQgaXMgYWN0aXZlIGFzIGVuY29kZXItPmdldF9jb25maWcgY2FsbGVkIG9u bHkgaWYKPiBAQCAtODQ3LDggKzg2Myw3OSBAQCBzdGF0aWMgdm9pZCBieHRfZHNpX2dldF9waXBl X2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCWFkanVzdGVkX21vZGUt PmNydGNfdnN5bmNfZW5kID0gdnN5bmMgKyBhZGp1c3RlZF9tb2RlLT5jcnRjX3ZzeW5jX3N0YXJ0 Owo+ICAJYWRqdXN0ZWRfbW9kZS0+Y3J0Y192Ymxhbmtfc3RhcnQgPSBhZGp1c3RlZF9tb2RlLT5j cnRjX3ZkaXNwbGF5Owo+ICAJYWRqdXN0ZWRfbW9kZS0+Y3J0Y192YmxhbmtfZW5kID0gYWRqdXN0 ZWRfbW9kZS0+Y3J0Y192dG90YWw7Cj4gLX0KPiAgCj4gKwkvKgo+ICsJICogSW4gQlhUIERTSSB0 aGVyZSBpcyBubyByZWdzIHByb2dyYW1tZWQgd2l0aCBmZXcgaG9yaXpvbnRhbCB0aW1pbmdzCj4g KwkgKiBpbiBQaXhlbHMgYnV0IHR4Ynl0ZWNsa2hzLi4gU28gcmV0cmlldmFsIHByb2Nlc3MgYWRk cyBzb21lCj4gKwkgKiBST1VORF9VUCBFUlJPUlMgaW4gdGhlIHByb2Nlc3Mgb2YgUElYRUxTPD09 PnR4Ynl0ZWNsa2hzLgo+ICsJICogQWN0dWFsbHkgaGVyZSBmb3IgdGhlIGdpdmVuIGFkanVzdGVk X21vZGUsIHdlIGFyZSBjYWxjdWxhdGluZyB0aGUKPiArCSAqIHZhbHVlIHByb2dyYW1tZWQgdG8g dGhlIHBvcnQgYW5kIHRoZW4gYmFjayB0byB0aGUgaG9yaXpvbnRhbCB0aW1pbmcKPiArCSAqIHBh cmFtIGluIHBpeGVscy4gVGhpcyBpcyB0aGUgZXhwZWN0ZWQgdmFsdWUsIGluY2x1ZGluZyByb3Vu ZHVwIGVycm9ycwo+ICsJICogQW5kIGlmIHRoYXQgaXMgc2FtZSBhcyByZXRyaWV2ZWQgdmFsdWUg ZnJvbSBwb3J0LCB0aGVuCj4gKwkgKiAoSFcgc3RhdGUpIGFkanVzdGVkX21vZGUncyBob3Jpem9u dGFsIHRpbWluZ3MgYXJlIGNvcnJlY3RlZCB0bwo+ICsJICogbWF0Y2ggd2l0aCBTVyBzdGF0ZSB0 byBudWxsaWZ5IHRoZSBlcnJvcnMuCj4gKwkgKi8KPiArCS8qIENhbGN1bGF0aW5nIHRoZSB2YWx1 ZSBwcm9ncmFtbWVkIHRvIHRoZSBQb3J0IHJlZ2lzdGVyICovCj4gKwloZnBfc3cgPSBhZGp1c3Rl ZF9tb2RlX3N3LT5jcnRjX2hzeW5jX3N0YXJ0IC0KPiArCQkJCQlhZGp1c3RlZF9tb2RlX3N3LT5j cnRjX2hkaXNwbGF5Owo+ICsJaHN5bmNfc3cgPSBhZGp1c3RlZF9tb2RlX3N3LT5jcnRjX2hzeW5j X2VuZCAtCj4gKwkJCQkJYWRqdXN0ZWRfbW9kZV9zdy0+Y3J0Y19oc3luY19zdGFydDsKPiArCWhi cF9zdyA9IGFkanVzdGVkX21vZGVfc3ctPmNydGNfaHRvdGFsIC0KPiArCQkJCQlhZGp1c3RlZF9t b2RlX3N3LT5jcnRjX2hzeW5jX2VuZDsKPiArCj4gKwlpZiAoaW50ZWxfZHNpLT5kdWFsX2xpbmsp IHsKPiArCQloZnBfc3cgLz0gMjsKPiArCQloc3luY19zdyAvPSAyOwo+ICsJCWhicF9zdyAvPSAy Owo+ICsJfQo+ICsKPiArCWhmcF9zdyA9IHR4Ynl0ZWNsa2hzKGhmcF9zdywgYnBwLCBsYW5lX2Nv dW50LAo+ICsJCQkJCQlpbnRlbF9kc2ktPmJ1cnN0X21vZGVfcmF0aW8pOwo+ICsJaHN5bmNfc3cg PSB0eGJ5dGVjbGtocyhoc3luY19zdywgYnBwLCBsYW5lX2NvdW50LAo+ICsJCQkgICAgaW50ZWxf ZHNpLT5idXJzdF9tb2RlX3JhdGlvKTsKPiArCWhicF9zdyA9IHR4Ynl0ZWNsa2hzKGhicF9zdywg YnBwLCBsYW5lX2NvdW50LAo+ICsJCQkJCQlpbnRlbF9kc2ktPmJ1cnN0X21vZGVfcmF0aW8pOwo+ ICsKPiArCS8qIFJldmVyc2UgY2FsY3VsYXRpbmcgdGhlIGFkanVzdGVkIG1vZGUgcGFyYW1ldGVy cyBmcm9tIHBvcnQgcmVnIHZhbHMqLwo+ICsJaGZwX3N3ID0gcGl4ZWxzX2Zyb21fdHhieXRlY2xr aHMoaGZwX3N3LCBicHAsIGxhbmVfY291bnQsCj4gKwkJCQkJCWludGVsX2RzaS0+YnVyc3RfbW9k ZV9yYXRpbyk7Cj4gKwloc3luY19zdyA9IHBpeGVsc19mcm9tX3R4Ynl0ZWNsa2hzKGhzeW5jX3N3 LCBicHAsIGxhbmVfY291bnQsCj4gKwkJCQkJCWludGVsX2RzaS0+YnVyc3RfbW9kZV9yYXRpbyk7 Cj4gKwloYnBfc3cgPSBwaXhlbHNfZnJvbV90eGJ5dGVjbGtocyhoYnBfc3csIGJwcCwgbGFuZV9j b3VudCwKPiArCQkJCQkJaW50ZWxfZHNpLT5idXJzdF9tb2RlX3JhdGlvKTsKPiArCj4gKwlpZiAo aW50ZWxfZHNpLT5kdWFsX2xpbmspIHsKPiArCQloZnBfc3cgKj0gMjsKPiArCQloc3luY19zdyAq PSAyOwo+ICsJCWhicF9zdyAqPSAyOwo+ICsJfQo+ICsKPiArCWNydGNfaHRvdGFsX3N3ID0gYWRq dXN0ZWRfbW9kZV9zdy0+Y3J0Y19oZGlzcGxheSArIGhmcF9zdyArCj4gKwkJCQkJCQloc3luY19z dyArIGhicF9zdzsKPiArCWNydGNfaHN5bmNfc3RhcnRfc3cgPSBoZnBfc3cgKyBhZGp1c3RlZF9t b2RlX3N3LT5jcnRjX2hkaXNwbGF5Owo+ICsJY3J0Y19oc3luY19lbmRfc3cgPSBoc3luY19zdyAr IGNydGNfaHN5bmNfc3RhcnRfc3c7Cj4gKwljcnRjX2hibGFua19zdGFydF9zdyA9IGFkanVzdGVk X21vZGVfc3ctPmNydGNfaGRpc3BsYXk7Cj4gKwljcnRjX2hibGFua19lbmRfc3cgPSBjcnRjX2h0 b3RhbF9zdzsKPiArCj4gKwlpZiAoYWRqdXN0ZWRfbW9kZS0+Y3J0Y19odG90YWwgPT0gY3J0Y19o dG90YWxfc3cpCj4gKwkJYWRqdXN0ZWRfbW9kZS0+Y3J0Y19odG90YWwgPSBhZGp1c3RlZF9tb2Rl X3N3LT5jcnRjX2h0b3RhbDsKPiArCj4gKwlpZiAoYWRqdXN0ZWRfbW9kZS0+Y3J0Y19oc3luY19z dGFydCA9PSBjcnRjX2hzeW5jX3N0YXJ0X3N3KQo+ICsJCWFkanVzdGVkX21vZGUtPmNydGNfaHN5 bmNfc3RhcnQgPQo+ICsJCQkJCWFkanVzdGVkX21vZGVfc3ctPmNydGNfaHN5bmNfc3RhcnQ7Cj4g Kwo+ICsJaWYgKGFkanVzdGVkX21vZGUtPmNydGNfaHN5bmNfZW5kID09IGNydGNfaHN5bmNfZW5k X3N3KQo+ICsJCWFkanVzdGVkX21vZGUtPmNydGNfaHN5bmNfZW5kID0KPiArCQkJCQlhZGp1c3Rl ZF9tb2RlX3N3LT5jcnRjX2hzeW5jX2VuZDsKPiArCj4gKwlpZiAoYWRqdXN0ZWRfbW9kZS0+Y3J0 Y19oYmxhbmtfc3RhcnQgPT0gY3J0Y19oYmxhbmtfc3RhcnRfc3cpCj4gKwkJYWRqdXN0ZWRfbW9k ZS0+Y3J0Y19oYmxhbmtfc3RhcnQgPQo+ICsJCQkJCWFkanVzdGVkX21vZGVfc3ctPmNydGNfaGJs YW5rX3N0YXJ0Owo+ICsKPiArCWlmIChhZGp1c3RlZF9tb2RlLT5jcnRjX2hibGFua19lbmQgPT0g Y3J0Y19oYmxhbmtfZW5kX3N3KQo+ICsJCWFkanVzdGVkX21vZGUtPmNydGNfaGJsYW5rX2VuZCA9 Cj4gKwkJCQkJYWRqdXN0ZWRfbW9kZV9zdy0+Y3J0Y19oYmxhbmtfZW5kOwo+ICt9Cj4gIAo+ICBz dGF0aWMgdm9pZCBpbnRlbF9kc2lfZ2V0X2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5j b2RlciwKPiAgCQkJCSBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gQEAg LTkxNywxNCArMTAwNCw2IEBAIHN0YXRpYyB1MTYgdHhjbGtlc2ModTMyIGRpdmlkZXIsIHVuc2ln bmVkIGludCB1cykKPiAgCX0KPiAgfQo+ICAKPiAtLyogcmV0dXJuIHBpeGVscyBpbiB0ZXJtcyBv ZiB0eGJ5dGVjbGtocyAqLwo+IC1zdGF0aWMgdTE2IHR4Ynl0ZWNsa2hzKHUxNiBwaXhlbHMsIGlu dCBicHAsIGludCBsYW5lX2NvdW50LAo+IC0JCSAgICAgICB1MTYgYnVyc3RfbW9kZV9yYXRpbykK PiAtewo+IC0JcmV0dXJuIERJVl9ST1VORF9VUChESVZfUk9VTkRfVVAocGl4ZWxzICogYnBwICog YnVyc3RfbW9kZV9yYXRpbywKPiAtCQkJCQkgOCAqIDEwMCksIGxhbmVfY291bnQpOwo+IC19Cj4g LQo+ICBzdGF0aWMgdm9pZCBzZXRfZHNpX3RpbWluZ3Moc3RydWN0IGRybV9lbmNvZGVyICplbmNv ZGVyLAo+ICAJCQkgICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmFkanVzdGVkX21v ZGUpCj4gIHsKPiAtLSAKPiAxLjcuOS41CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==