From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbcDTRoU (ORCPT ); Wed, 20 Apr 2016 13:44:20 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35731 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbcDTRoS (ORCPT ); Wed, 20 Apr 2016 13:44:18 -0400 Date: Wed, 20 Apr 2016 19:44:14 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, daniel@ffwll.ch, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap Message-ID: <20160420174414.GQ2510@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-6-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461165929-11344-6-git-send-email-noralf@tronnes.org> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2016 at 05:25:26PM +0200, Noralf Trønnes wrote: > Export fb_deferred_io_mmap so drivers can change vma->vm_page_prot. > When the framebuffer memory is allocated using dma_alloc_writecombine() > instead of vmalloc(), I get cache syncing problems. > This solves it: > > static int drm_fbdev_cma_deferred_io_mmap(struct fb_info *info, > struct vm_area_struct *vma) > { > fb_deferred_io_mmap(info, vma); > vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); Hm, do we need pgpropt_writecombine? There recently was some discussion (on the arc platform) that fbdev pgprots need to be fixed up in fbdev code. I have no idea, just repeating from memory ... -Daniel > > return 0; > } > > Signed-off-by: Noralf Trønnes > --- > drivers/video/fbdev/core/fb_defio.c | 3 ++- > include/linux/fb.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c > index 57721c7..74b5bca 100644 > --- a/drivers/video/fbdev/core/fb_defio.c > +++ b/drivers/video/fbdev/core/fb_defio.c > @@ -164,7 +164,7 @@ static const struct address_space_operations fb_deferred_io_aops = { > .set_page_dirty = fb_deferred_io_set_page_dirty, > }; > > -static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) > +int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) > { > vma->vm_ops = &fb_deferred_io_vm_ops; > vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP; > @@ -173,6 +173,7 @@ static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) > vma->vm_private_data = info; > return 0; > } > +EXPORT_SYMBOL(fb_deferred_io_mmap); > > /* workqueue callback */ > static void fb_deferred_io_work(struct work_struct *work) > diff --git a/include/linux/fb.h b/include/linux/fb.h > index dfe8835..a964d07 100644 > --- a/include/linux/fb.h > +++ b/include/linux/fb.h > @@ -673,6 +673,7 @@ static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, > } > > /* drivers/video/fb_defio.c */ > +int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma); > extern void fb_deferred_io_init(struct fb_info *info); > extern void fb_deferred_io_open(struct fb_info *info, > struct inode *inode, > -- > 2.2.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Wed, 20 Apr 2016 17:44:14 +0000 Subject: Re: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap Message-Id: <20160420174414.GQ2510@phenom.ffwll.local> List-Id: References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-6-git-send-email-noralf@tronnes.org> In-Reply-To: <1461165929-11344-6-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com On Wed, Apr 20, 2016 at 05:25:26PM +0200, Noralf Tr=F8nnes wrote: > Export fb_deferred_io_mmap so drivers can change vma->vm_page_prot. > When the framebuffer memory is allocated using dma_alloc_writecombine() > instead of vmalloc(), I get cache syncing problems. > This solves it: >=20 > static int drm_fbdev_cma_deferred_io_mmap(struct fb_info *info, > struct vm_area_struct *vma) > { > fb_deferred_io_mmap(info, vma); > vma->vm_page_prot =3D pgprot_writecombine(vma->vm_page_prot); Hm, do we need pgpropt_writecombine? There recently was some discussion (on the arc platform) that fbdev pgprots need to be fixed up in fbdev code. I have no idea, just repeating from memory ... -Daniel >=20 > return 0; > } >=20 > Signed-off-by: Noralf Tr=F8nnes > --- > drivers/video/fbdev/core/fb_defio.c | 3 ++- > include/linux/fb.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/co= re/fb_defio.c > index 57721c7..74b5bca 100644 > --- a/drivers/video/fbdev/core/fb_defio.c > +++ b/drivers/video/fbdev/core/fb_defio.c > @@ -164,7 +164,7 @@ static const struct address_space_operations fb_defer= red_io_aops =3D { > .set_page_dirty =3D fb_deferred_io_set_page_dirty, > }; > =20 > -static int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_stru= ct *vma) > +int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) > { > vma->vm_ops =3D &fb_deferred_io_vm_ops; > vma->vm_flags |=3D VM_DONTEXPAND | VM_DONTDUMP; > @@ -173,6 +173,7 @@ static int fb_deferred_io_mmap(struct fb_info *info, = struct vm_area_struct *vma) > vma->vm_private_data =3D info; > return 0; > } > +EXPORT_SYMBOL(fb_deferred_io_mmap); > =20 > /* workqueue callback */ > static void fb_deferred_io_work(struct work_struct *work) > diff --git a/include/linux/fb.h b/include/linux/fb.h > index dfe8835..a964d07 100644 > --- a/include/linux/fb.h > +++ b/include/linux/fb.h > @@ -673,6 +673,7 @@ static inline void __fb_pad_aligned_buffer(u8 *dst, u= 32 d_pitch, > } > =20 > /* drivers/video/fb_defio.c */ > +int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma= ); > extern void fb_deferred_io_init(struct fb_info *info); > extern void fb_deferred_io_open(struct fb_info *info, > struct inode *inode, > --=20 > 2.2.2 >=20 --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/8] fbdev: fb_defio: Export fb_deferred_io_mmap Date: Wed, 20 Apr 2016 19:44:14 +0200 Message-ID: <20160420174414.GQ2510@phenom.ffwll.local> References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-6-git-send-email-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 930646E23D for ; Wed, 20 Apr 2016 17:44:18 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id l6so15728035wml.3 for ; Wed, 20 Apr 2016 10:44:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1461165929-11344-6-git-send-email-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMjAsIDIwMTYgYXQgMDU6MjU6MjZQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IEV4cG9ydCBmYl9kZWZlcnJlZF9pb19tbWFwIHNvIGRyaXZlcnMgY2FuIGNoYW5n ZSB2bWEtPnZtX3BhZ2VfcHJvdC4KPiBXaGVuIHRoZSBmcmFtZWJ1ZmZlciBtZW1vcnkgaXMgYWxs b2NhdGVkIHVzaW5nIGRtYV9hbGxvY193cml0ZWNvbWJpbmUoKQo+IGluc3RlYWQgb2Ygdm1hbGxv YygpLCBJIGdldCBjYWNoZSBzeW5jaW5nIHByb2JsZW1zLgo+IFRoaXMgc29sdmVzIGl0Ogo+IAo+ IHN0YXRpYyBpbnQgZHJtX2ZiZGV2X2NtYV9kZWZlcnJlZF9pb19tbWFwKHN0cnVjdCBmYl9pbmZv ICppbmZvLAo+IAkJCQkJICBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiB7Cj4gCWZiX2Rl ZmVycmVkX2lvX21tYXAoaW5mbywgdm1hKTsKPiAJdm1hLT52bV9wYWdlX3Byb3QgPSBwZ3Byb3Rf d3JpdGVjb21iaW5lKHZtYS0+dm1fcGFnZV9wcm90KTsKCkhtLCBkbyB3ZSBuZWVkIHBncHJvcHRf d3JpdGVjb21iaW5lPyBUaGVyZSByZWNlbnRseSB3YXMgc29tZSBkaXNjdXNzaW9uCihvbiB0aGUg YXJjIHBsYXRmb3JtKSB0aGF0IGZiZGV2IHBncHJvdHMgbmVlZCB0byBiZSBmaXhlZCB1cCBpbiBm YmRldgpjb2RlLiBJIGhhdmUgbm8gaWRlYSwganVzdCByZXBlYXRpbmcgZnJvbSBtZW1vcnkgLi4u Ci1EYW5pZWwKCj4gCj4gCXJldHVybiAwOwo+IH0KPiAKPiBTaWduZWQtb2ZmLWJ5OiBOb3JhbGYg VHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiAtLS0KPiAgZHJpdmVycy92aWRlby9mYmRl di9jb3JlL2ZiX2RlZmlvLmMgfCAzICsrLQo+ICBpbmNsdWRlL2xpbnV4L2ZiLmggICAgICAgICAg ICAgICAgICB8IDEgKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJfZGVm aW8uYyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jCj4gaW5kZXggNTc3MjFj Ny4uNzRiNWJjYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJfZGVm aW8uYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvY29yZS9mYl9kZWZpby5jCj4gQEAgLTE2 NCw3ICsxNjQsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGFkZHJlc3Nfc3BhY2Vfb3BlcmF0aW9u cyBmYl9kZWZlcnJlZF9pb19hb3BzID0gewo+ICAJLnNldF9wYWdlX2RpcnR5ID0gZmJfZGVmZXJy ZWRfaW9fc2V0X3BhZ2VfZGlydHksCj4gIH07Cj4gIAo+IC1zdGF0aWMgaW50IGZiX2RlZmVycmVk X2lvX21tYXAoc3RydWN0IGZiX2luZm8gKmluZm8sIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1h KQo+ICtpbnQgZmJfZGVmZXJyZWRfaW9fbW1hcChzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgc3RydWN0 IHZtX2FyZWFfc3RydWN0ICp2bWEpCj4gIHsKPiAgCXZtYS0+dm1fb3BzID0gJmZiX2RlZmVycmVk X2lvX3ZtX29wczsKPiAgCXZtYS0+dm1fZmxhZ3MgfD0gVk1fRE9OVEVYUEFORCB8IFZNX0RPTlRE VU1QOwo+IEBAIC0xNzMsNiArMTczLDcgQEAgc3RhdGljIGludCBmYl9kZWZlcnJlZF9pb19tbWFw KHN0cnVjdCBmYl9pbmZvICppbmZvLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgCXZt YS0+dm1fcHJpdmF0ZV9kYXRhID0gaW5mbzsKPiAgCXJldHVybiAwOwo+ICB9Cj4gK0VYUE9SVF9T WU1CT0woZmJfZGVmZXJyZWRfaW9fbW1hcCk7Cj4gIAo+ICAvKiB3b3JrcXVldWUgY2FsbGJhY2sg Ki8KPiAgc3RhdGljIHZvaWQgZmJfZGVmZXJyZWRfaW9fd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3Qg KndvcmspCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvZmIuaCBiL2luY2x1ZGUvbGludXgv ZmIuaAo+IGluZGV4IGRmZTg4MzUuLmE5NjRkMDcgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51 eC9mYi5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9mYi5oCj4gQEAgLTY3Myw2ICs2NzMsNyBAQCBz dGF0aWMgaW5saW5lIHZvaWQgX19mYl9wYWRfYWxpZ25lZF9idWZmZXIodTggKmRzdCwgdTMyIGRf cGl0Y2gsCj4gIH0KPiAgCj4gIC8qIGRyaXZlcnMvdmlkZW8vZmJfZGVmaW8uYyAqLwo+ICtpbnQg ZmJfZGVmZXJyZWRfaW9fbW1hcChzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgc3RydWN0IHZtX2FyZWFf c3RydWN0ICp2bWEpOwo+ICBleHRlcm4gdm9pZCBmYl9kZWZlcnJlZF9pb19pbml0KHN0cnVjdCBm Yl9pbmZvICppbmZvKTsKPiAgZXh0ZXJuIHZvaWQgZmJfZGVmZXJyZWRfaW9fb3BlbihzdHJ1Y3Qg ZmJfaW5mbyAqaW5mbywKPiAgCQkJCXN0cnVjdCBpbm9kZSAqaW5vZGUsCj4gLS0gCj4gMi4yLjIK PiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK