From: David Miller <davem@davemloft.net>
To: broonie@kernel.org
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: spi_ks8895: Don't leak references to SPI devices
Date: Thu, 21 Apr 2016 15:00:39 -0400 (EDT) [thread overview]
Message-ID: <20160421.150039.591459586047228776.davem@davemloft.net> (raw)
In-Reply-To: <1461153245-7992-1-git-send-email-broonie@kernel.org>
From: Mark Brown <broonie@kernel.org>
Date: Wed, 20 Apr 2016 12:54:05 +0100
> The ks8895 driver is using spi_dev_get() apparently just to take a copy
> of the SPI device used to instantiate it but never calls spi_dev_put()
> to free it. Since the device is guaranteed to exist between probe() and
> remove() there should be no need for the driver to take an extra
> reference to it so fix the leak by just using a straight assignment.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Applied.
prev parent reply other threads:[~2016-04-21 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 11:54 [PATCH] net: phy: spi_ks8895: Don't leak references to SPI devices Mark Brown
2016-04-21 19:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421.150039.591459586047228776.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.