From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set
Date: Thu, 21 Apr 2016 09:35:51 +0300 [thread overview]
Message-ID: <20160421063551.GA12510@tyrael> (raw)
In-Reply-To: <20160420201955.GA35572@f23x64.localdomain>
On Wed, Apr 20, 2016 at 01:19:55PM -0700, Darren Hart wrote:
> On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote:
> > Properly return rv back to the caller in the case of an error in
> > parse_arg. In the process remove a unused variable 'out'.
>
> The initial problem if I recall was value being uninitialized. Is that correct?
No, 'out' was just removed as it was unused. Then you caught the issue with
error handling in this function so I've updated this patch to fix that as well.
next prev parent reply other threads:[~2016-04-21 6:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 0:01 [PATCH v2 1/2] asus-laptop: remove redundant initializers Giedrius Statkevičius
2016-04-16 0:01 ` [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius
2016-04-20 20:19 ` Darren Hart
2016-04-21 6:35 ` Giedrius Statkevičius [this message]
2016-04-21 20:34 ` Andy Shevchenko
2016-04-21 20:59 ` Darren Hart
2016-04-25 17:47 ` Darren Hart
2016-04-21 23:01 ` [PATCH v2 1/2] asus-laptop: remove redundant initializers Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421063551.GA12510@tyrael \
--to=giedrius.statkevicius@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.