From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbcDUH2x (ORCPT ); Thu, 21 Apr 2016 03:28:53 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37094 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbcDUH2v (ORCPT ); Thu, 21 Apr 2016 03:28:51 -0400 Date: Thu, 21 Apr 2016 09:28:47 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Message-ID: <20160421072847.GW2510@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-3-git-send-email-noralf@tronnes.org> <20160420174241.GP2510@phenom.ffwll.local> <5717C742.7080807@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5717C742.7080807@tronnes.org> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2016 at 08:15:30PM +0200, Noralf Trønnes wrote: > > Den 20.04.2016 19:42, skrev Daniel Vetter: > >On Wed, Apr 20, 2016 at 05:25:23PM +0200, Noralf Trønnes wrote: > >>Now that drm_fb_helper gets deferred io support, the > >>drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule > >>the worker that calls the deferred_io callback. This will break this > >>driver so use the sys_{fillrect,copyarea,imageblit} functions directly. > >> > >>Signed-off-by: Noralf Trønnes > >I think this intermediately breaks the build, if you disable fbdev > >support. That's now supported in the fbdev helpers core generically across > >all drivers. > > > >Not sure how to best fix this up, since the only way would be to squash > >these patches, plus generic deferred io plus the conversion patches for > >udl/qxl all into one. Tricky. > > Yes you're right, I missed that. > How about this: > #ifdef CONFIG_FB > sys_fillrect(info, rect); > #endif > > The later patch will then remove this ugliness... Yeah I think we have to bite the bullet and take this temporary ugliness :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Thu, 21 Apr 2016 07:28:47 +0000 Subject: Re: [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Message-Id: <20160421072847.GW2510@phenom.ffwll.local> List-Id: References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-3-git-send-email-noralf@tronnes.org> <20160420174241.GP2510@phenom.ffwll.local> <5717C742.7080807@tronnes.org> In-Reply-To: <5717C742.7080807@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: linux-fbdev@vger.kernel.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org On Wed, Apr 20, 2016 at 08:15:30PM +0200, Noralf Tr=F8nnes wrote: >=20 > Den 20.04.2016 19:42, skrev Daniel Vetter: > >On Wed, Apr 20, 2016 at 05:25:23PM +0200, Noralf Tr=F8nnes wrote: > >>Now that drm_fb_helper gets deferred io support, the > >>drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule > >>the worker that calls the deferred_io callback. This will break this > >>driver so use the sys_{fillrect,copyarea,imageblit} functions directly. > >> > >>Signed-off-by: Noralf Tr=F8nnes > >I think this intermediately breaks the build, if you disable fbdev > >support. That's now supported in the fbdev helpers core generically acro= ss > >all drivers. > > > >Not sure how to best fix this up, since the only way would be to squash > >these patches, plus generic deferred io plus the conversion patches for > >udl/qxl all into one. Tricky. >=20 > Yes you're right, I missed that. > How about this: > #ifdef CONFIG_FB > sys_fillrect(info, rect); > #endif >=20 > The later patch will then remove this ugliness... Yeah I think we have to bite the bullet and take this temporary ugliness :( -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Date: Thu, 21 Apr 2016 09:28:47 +0200 Message-ID: <20160421072847.GW2510@phenom.ffwll.local> References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-3-git-send-email-noralf@tronnes.org> <20160420174241.GP2510@phenom.ffwll.local> <5717C742.7080807@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFD226EBE6 for ; Thu, 21 Apr 2016 07:28:51 +0000 (UTC) Received: by mail-wm0-x234.google.com with SMTP id e201so75775876wme.0 for ; Thu, 21 Apr 2016 00:28:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5717C742.7080807@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: linux-fbdev@vger.kernel.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMjAsIDIwMTYgYXQgMDg6MTU6MzBQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IERlbiAyMC4wNC4yMDE2IDE5OjQyLCBza3JldiBEYW5pZWwgVmV0dGVyOgo+ ID5PbiBXZWQsIEFwciAyMCwgMjAxNiBhdCAwNToyNToyM1BNICswMjAwLCBOb3JhbGYgVHLDuG5u ZXMgd3JvdGU6Cj4gPj5Ob3cgdGhhdCBkcm1fZmJfaGVscGVyIGdldHMgZGVmZXJyZWQgaW8gc3Vw cG9ydCwgdGhlCj4gPj5kcm1fZmJfaGVscGVyX3N5c197ZmlsbHJlY3QsY29weWFyZWEsaW1hZ2Vi bGl0fSBmdW5jdGlvbnMgd2lsbCBzY2hlZHVsZQo+ID4+dGhlIHdvcmtlciB0aGF0IGNhbGxzIHRo ZSBkZWZlcnJlZF9pbyBjYWxsYmFjay4gVGhpcyB3aWxsIGJyZWFrIHRoaXMKPiA+PmRyaXZlciBz byB1c2UgdGhlIHN5c197ZmlsbHJlY3QsY29weWFyZWEsaW1hZ2VibGl0fSBmdW5jdGlvbnMgZGly ZWN0bHkuCj4gPj4KPiA+PlNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRy b25uZXMub3JnPgo+ID5JIHRoaW5rIHRoaXMgaW50ZXJtZWRpYXRlbHkgYnJlYWtzIHRoZSBidWls ZCwgaWYgeW91IGRpc2FibGUgZmJkZXYKPiA+c3VwcG9ydC4gVGhhdCdzIG5vdyBzdXBwb3J0ZWQg aW4gdGhlIGZiZGV2IGhlbHBlcnMgY29yZSBnZW5lcmljYWxseSBhY3Jvc3MKPiA+YWxsIGRyaXZl cnMuCj4gPgo+ID5Ob3Qgc3VyZSBob3cgdG8gYmVzdCBmaXggdGhpcyB1cCwgc2luY2UgdGhlIG9u bHkgd2F5IHdvdWxkIGJlIHRvIHNxdWFzaAo+ID50aGVzZSBwYXRjaGVzLCBwbHVzIGdlbmVyaWMg ZGVmZXJyZWQgaW8gcGx1cyB0aGUgY29udmVyc2lvbiBwYXRjaGVzIGZvcgo+ID51ZGwvcXhsIGFs bCBpbnRvIG9uZS4gVHJpY2t5Lgo+IAo+IFllcyB5b3UncmUgcmlnaHQsIEkgbWlzc2VkIHRoYXQu Cj4gSG93IGFib3V0IHRoaXM6Cj4gI2lmZGVmIENPTkZJR19GQgo+ICAgICAgICAgc3lzX2ZpbGxy ZWN0KGluZm8sIHJlY3QpOwo+ICNlbmRpZgo+IAo+IFRoZSBsYXRlciBwYXRjaCB3aWxsIHRoZW4g cmVtb3ZlIHRoaXMgdWdsaW5lc3MuLi4KClllYWggSSB0aGluayB3ZSBoYXZlIHRvIGJpdGUgdGhl IGJ1bGxldCBhbmQgdGFrZSB0aGlzIHRlbXBvcmFyeSB1Z2xpbmVzcwo6KAoKLURhbmllbAotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==