From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbcDUHtp (ORCPT ); Thu, 21 Apr 2016 03:49:45 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36199 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbcDUHto (ORCPT ); Thu, 21 Apr 2016 03:49:44 -0400 Date: Thu, 21 Apr 2016 09:49:39 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] drm/qxl: Use drm_fb_helper deferred_io support Message-ID: <20160421074939.GZ2510@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-8-git-send-email-noralf@tronnes.org> <20160420174710.GR2510@phenom.ffwll.local> <5717D2C6.7060806@tronnes.org> <20160421074134.GY2510@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160421074134.GY2510@phenom.ffwll.local> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2016 at 09:41:34AM +0200, Daniel Vetter wrote: > On Wed, Apr 20, 2016 at 09:04:38PM +0200, Noralf Trønnes wrote: > > > > Den 20.04.2016 19:47, skrev Daniel Vetter: > > >On Wed, Apr 20, 2016 at 05:25:28PM +0200, Noralf Trønnes wrote: > > >>Use the fbdev deferred io support in drm_fb_helper. > > >>The (struct fb_ops *)->fb_{fillrect,copyarea,imageblit} functions will > > >>now be deferred in the same way that mmap damage is, instead of being > > >>flushed directly. > > >>This patch has only been compile tested. > > >> > > >>Signed-off-by: Noralf Trønnes > > >>--- > > >> drivers/gpu/drm/qxl/qxl_display.c | 9 +- > > >> drivers/gpu/drm/qxl/qxl_drv.h | 7 +- > > >> drivers/gpu/drm/qxl/qxl_fb.c | 220 ++++++++++---------------------------- > > >> drivers/gpu/drm/qxl/qxl_kms.c | 4 - > > >> 4 files changed, 62 insertions(+), 178 deletions(-) > > >> > > >>diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c > > >>index 030409a..9a03524 100644 > > >>--- a/drivers/gpu/drm/qxl/qxl_display.c > > >>+++ b/drivers/gpu/drm/qxl/qxl_display.c > > >>@@ -465,7 +465,7 @@ static const struct drm_crtc_funcs qxl_crtc_funcs = { > > >> .page_flip = qxl_crtc_page_flip, > > >> }; > > >>-static void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb) > > >>+void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb) > > >> { > > >> struct qxl_framebuffer *qxl_fb = to_qxl_framebuffer(fb); > > >>@@ -527,12 +527,13 @@ int > > >> qxl_framebuffer_init(struct drm_device *dev, > > >> struct qxl_framebuffer *qfb, > > >> const struct drm_mode_fb_cmd2 *mode_cmd, > > >>- struct drm_gem_object *obj) > > >>+ struct drm_gem_object *obj, > > >>+ const struct drm_framebuffer_funcs *funcs) > > >There should be no need at all to have a separate fb funcs table for the > > >fbdev fb. Both /should/ be able to use the exact same (already existing) > > >->dirty() callback. We need this only in CMA because CMA is a midlayer > > >used by multiple drivers. > > > > I don't see how I can avoid it. > > > > fbdev framebuffer flushing: > > > > static void qxl_fb_dirty_flush(struct fb_info *info) > > { > > qxl_fb_image_init(&qxl_fb_image, qdev, info, NULL); > > qxl_draw_opaque_fb(&qxl_fb_image, stride); > > } > > > > drm framebuffer flushing: > > > > static int qxl_framebuffer_surface_dirty(...) > > { > > qxl_draw_dirty_fb(...); > > } > > > > qxl_draw_opaque_fb() and qxl_draw_dirty_fb() differ so much that it's way > > over my head to see if they can be combined. > > Here's an online diff of the two functions: > > https://www.diffchecker.com/jqbbalux > > Imo nuke the fbdev one entirely. If it breaks then it's either a bug in > your generic fbdefio code, or the qxl ->dirty implementation has a bug. It > should work ;-) > > Ok, slightly more seriously the difference seems to be that the fbdev one > support paletted mode too. But since qxl has 0 pixel format checking > anywhere I have no idea whether that's dead code (i.e. broken) or actually > working. I guess keeping the split is ok, if we add a big FIXME comment to > it that this is very fishy. Ok, I read around a bit more. The only things qxl seems to support are bits_per_pixel of 1, 24 and 32 (see qxl_image_init_helper). And drm has no way to pass in 1 bpp images. And it doesn't support 8 bit paletted, which is the only paletted thing drm supports. So if you totally feel like I think we could add format checking for DRM_FORMAT_XRGB8888 and DRM_FORMAT_RGB888 in qxl_framebuffer_init and then rip out all that code. But that's a few more patches and probably should be tested actually ;-) FIXME plus explaing it all in the commit message is fine with me too. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Thu, 21 Apr 2016 07:49:39 +0000 Subject: Re: [PATCH 7/8] drm/qxl: Use drm_fb_helper deferred_io support Message-Id: <20160421074939.GZ2510@phenom.ffwll.local> List-Id: References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-8-git-send-email-noralf@tronnes.org> <20160420174710.GR2510@phenom.ffwll.local> <5717D2C6.7060806@tronnes.org> <20160421074134.GY2510@phenom.ffwll.local> In-Reply-To: <20160421074134.GY2510@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org On Thu, Apr 21, 2016 at 09:41:34AM +0200, Daniel Vetter wrote: > On Wed, Apr 20, 2016 at 09:04:38PM +0200, Noralf Tr=F8nnes wrote: > >=20 > > Den 20.04.2016 19:47, skrev Daniel Vetter: > > >On Wed, Apr 20, 2016 at 05:25:28PM +0200, Noralf Tr=F8nnes wrote: > > >>Use the fbdev deferred io support in drm_fb_helper. > > >>The (struct fb_ops *)->fb_{fillrect,copyarea,imageblit} functions will > > >>now be deferred in the same way that mmap damage is, instead of being > > >>flushed directly. > > >>This patch has only been compile tested. > > >> > > >>Signed-off-by: Noralf Tr=F8nnes > > >>--- > > >> drivers/gpu/drm/qxl/qxl_display.c | 9 +- > > >> drivers/gpu/drm/qxl/qxl_drv.h | 7 +- > > >> drivers/gpu/drm/qxl/qxl_fb.c | 220 ++++++++++-----------------= ----------- > > >> drivers/gpu/drm/qxl/qxl_kms.c | 4 - > > >> 4 files changed, 62 insertions(+), 178 deletions(-) > > >> > > >>diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/= qxl_display.c > > >>index 030409a..9a03524 100644 > > >>--- a/drivers/gpu/drm/qxl/qxl_display.c > > >>+++ b/drivers/gpu/drm/qxl/qxl_display.c > > >>@@ -465,7 +465,7 @@ static const struct drm_crtc_funcs qxl_crtc_funcs= =3D { > > >> .page_flip =3D qxl_crtc_page_flip, > > >> }; > > >>-static void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb) > > >>+void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb) > > >> { > > >> struct qxl_framebuffer *qxl_fb =3D to_qxl_framebuffer(fb); > > >>@@ -527,12 +527,13 @@ int > > >> qxl_framebuffer_init(struct drm_device *dev, > > >> struct qxl_framebuffer *qfb, > > >> const struct drm_mode_fb_cmd2 *mode_cmd, > > >>- struct drm_gem_object *obj) > > >>+ struct drm_gem_object *obj, > > >>+ const struct drm_framebuffer_funcs *funcs) > > >There should be no need at all to have a separate fb funcs table for t= he > > >fbdev fb. Both /should/ be able to use the exact same (already existin= g) > > >->dirty() callback. We need this only in CMA because CMA is a midlayer > > >used by multiple drivers. > >=20 > > I don't see how I can avoid it. > >=20 > > fbdev framebuffer flushing: > >=20 > > static void qxl_fb_dirty_flush(struct fb_info *info) > > { > > qxl_fb_image_init(&qxl_fb_image, qdev, info, NULL); > > qxl_draw_opaque_fb(&qxl_fb_image, stride); > > } > >=20 > > drm framebuffer flushing: > >=20 > > static int qxl_framebuffer_surface_dirty(...) > > { > > qxl_draw_dirty_fb(...); > > } > >=20 > > qxl_draw_opaque_fb() and qxl_draw_dirty_fb() differ so much that it's w= ay > > over my head to see if they can be combined. > > Here's an online diff of the two functions: > > https://www.diffchecker.com/jqbbalux >=20 > Imo nuke the fbdev one entirely. If it breaks then it's either a bug in > your generic fbdefio code, or the qxl ->dirty implementation has a bug. It > should work ;-) >=20 > Ok, slightly more seriously the difference seems to be that the fbdev one > support paletted mode too. But since qxl has 0 pixel format checking > anywhere I have no idea whether that's dead code (i.e. broken) or actually > working. I guess keeping the split is ok, if we add a big FIXME comment to > it that this is very fishy. Ok, I read around a bit more. The only things qxl seems to support are bits_per_pixel of 1, 24 and 32 (see qxl_image_init_helper). And drm has no way to pass in 1 bpp images. And it doesn't support 8 bit paletted, which is the only paletted thing drm supports. So if you totally feel like I think we could add format checking for DRM_FORMAT_XRGB8888 and DRM_FORMAT_RGB888 in qxl_framebuffer_init and then rip out all that code. But that's a few more patches and probably should be tested actually ;-) FIXME plus explaing it all in the commit message is fine with me too. -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 7/8] drm/qxl: Use drm_fb_helper deferred_io support Date: Thu, 21 Apr 2016 09:49:39 +0200 Message-ID: <20160421074939.GZ2510@phenom.ffwll.local> References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-8-git-send-email-noralf@tronnes.org> <20160420174710.GR2510@phenom.ffwll.local> <5717D2C6.7060806@tronnes.org> <20160421074134.GY2510@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B6676EBFD for ; Thu, 21 Apr 2016 07:49:44 +0000 (UTC) Received: by mail-wm0-x236.google.com with SMTP id e201so76385834wme.0 for ; Thu, 21 Apr 2016 00:49:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160421074134.GY2510@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgMjEsIDIwMTYgYXQgMDk6NDE6MzRBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIEFwciAyMCwgMjAxNiBhdCAwOTowNDozOFBNICswMjAwLCBOb3JhbGYg VHLDuG5uZXMgd3JvdGU6Cj4gPiAKPiA+IERlbiAyMC4wNC4yMDE2IDE5OjQ3LCBza3JldiBEYW5p ZWwgVmV0dGVyOgo+ID4gPk9uIFdlZCwgQXByIDIwLCAyMDE2IGF0IDA1OjI1OjI4UE0gKzAyMDAs IE5vcmFsZiBUcsO4bm5lcyB3cm90ZToKPiA+ID4+VXNlIHRoZSBmYmRldiBkZWZlcnJlZCBpbyBz dXBwb3J0IGluIGRybV9mYl9oZWxwZXIuCj4gPiA+PlRoZSAoc3RydWN0IGZiX29wcyAqKS0+ZmJf e2ZpbGxyZWN0LGNvcHlhcmVhLGltYWdlYmxpdH0gZnVuY3Rpb25zIHdpbGwKPiA+ID4+bm93IGJl IGRlZmVycmVkIGluIHRoZSBzYW1lIHdheSB0aGF0IG1tYXAgZGFtYWdlIGlzLCBpbnN0ZWFkIG9m IGJlaW5nCj4gPiA+PmZsdXNoZWQgZGlyZWN0bHkuCj4gPiA+PlRoaXMgcGF0Y2ggaGFzIG9ubHkg YmVlbiBjb21waWxlIHRlc3RlZC4KPiA+ID4+Cj4gPiA+PlNpZ25lZC1vZmYtYnk6IE5vcmFsZiBU csO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+ID4gPj4tLS0KPiA+ID4+ICBkcml2ZXJzL2dw dS9kcm0vcXhsL3F4bF9kaXNwbGF5LmMgfCAgIDkgKy0KPiA+ID4+ICBkcml2ZXJzL2dwdS9kcm0v cXhsL3F4bF9kcnYuaCAgICAgfCAgIDcgKy0KPiA+ID4+ICBkcml2ZXJzL2dwdS9kcm0vcXhsL3F4 bF9mYi5jICAgICAgfCAyMjAgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K PiA+ID4+ICBkcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9rbXMuYyAgICAgfCAgIDQgLQo+ID4gPj4g IDQgZmlsZXMgY2hhbmdlZCwgNjIgaW5zZXJ0aW9ucygrKSwgMTc4IGRlbGV0aW9ucygtKQo+ID4g Pj4KPiA+ID4+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYyBi L2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYwo+ID4gPj5pbmRleCAwMzA0MDlhLi45 YTAzNTI0IDEwMDY0NAo+ID4gPj4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kaXNwbGF5 LmMKPiA+ID4+KysrIGIvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZGlzcGxheS5jCj4gPiA+PkBA IC00NjUsNyArNDY1LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19mdW5jcyBxeGxf Y3J0Y19mdW5jcyA9IHsKPiA+ID4+ICAJLnBhZ2VfZmxpcCA9IHF4bF9jcnRjX3BhZ2VfZmxpcCwK PiA+ID4+ICB9Owo+ID4gPj4tc3RhdGljIHZvaWQgcXhsX3VzZXJfZnJhbWVidWZmZXJfZGVzdHJv eShzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPiA+ID4+K3ZvaWQgcXhsX3VzZXJfZnJhbWVi dWZmZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPiA+ID4+ICB7Cj4gPiA+ PiAgCXN0cnVjdCBxeGxfZnJhbWVidWZmZXIgKnF4bF9mYiA9IHRvX3F4bF9mcmFtZWJ1ZmZlcihm Yik7Cj4gPiA+PkBAIC01MjcsMTIgKzUyNywxMyBAQCBpbnQKPiA+ID4+ICBxeGxfZnJhbWVidWZm ZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gPj4gIAkJICAgICBzdHJ1Y3QgcXhs X2ZyYW1lYnVmZmVyICpxZmIsCj4gPiA+PiAgCQkgICAgIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9m Yl9jbWQyICptb2RlX2NtZCwKPiA+ID4+LQkJICAgICBzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9i aikKPiA+ID4+KwkJICAgICBzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwKPiA+ID4+KwkJICAg ICBjb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyX2Z1bmNzICpmdW5jcykKPiA+ID5UaGVyZSBz aG91bGQgYmUgbm8gbmVlZCBhdCBhbGwgdG8gaGF2ZSBhIHNlcGFyYXRlIGZiIGZ1bmNzIHRhYmxl IGZvciB0aGUKPiA+ID5mYmRldiBmYi4gQm90aCAvc2hvdWxkLyBiZSBhYmxlIHRvIHVzZSB0aGUg ZXhhY3Qgc2FtZSAoYWxyZWFkeSBleGlzdGluZykKPiA+ID4tPmRpcnR5KCkgY2FsbGJhY2suIFdl IG5lZWQgdGhpcyBvbmx5IGluIENNQSBiZWNhdXNlIENNQSBpcyBhIG1pZGxheWVyCj4gPiA+dXNl ZCBieSBtdWx0aXBsZSBkcml2ZXJzLgo+ID4gCj4gPiBJIGRvbid0IHNlZSBob3cgSSBjYW4gYXZv aWQgaXQuCj4gPiAKPiA+IGZiZGV2IGZyYW1lYnVmZmVyIGZsdXNoaW5nOgo+ID4gCj4gPiBzdGF0 aWMgdm9pZCBxeGxfZmJfZGlydHlfZmx1c2goc3RydWN0IGZiX2luZm8gKmluZm8pCj4gPiB7Cj4g PiAgICAgICAgIHF4bF9mYl9pbWFnZV9pbml0KCZxeGxfZmJfaW1hZ2UsIHFkZXYsIGluZm8sIE5V TEwpOwo+ID4gICAgICAgICBxeGxfZHJhd19vcGFxdWVfZmIoJnF4bF9mYl9pbWFnZSwgc3RyaWRl KTsKPiA+IH0KPiA+IAo+ID4gZHJtIGZyYW1lYnVmZmVyIGZsdXNoaW5nOgo+ID4gCj4gPiBzdGF0 aWMgaW50IHF4bF9mcmFtZWJ1ZmZlcl9zdXJmYWNlX2RpcnR5KC4uLikKPiA+IHsKPiA+ICAgICAg ICAgcXhsX2RyYXdfZGlydHlfZmIoLi4uKTsKPiA+IH0KPiA+IAo+ID4gcXhsX2RyYXdfb3BhcXVl X2ZiKCkgYW5kIHF4bF9kcmF3X2RpcnR5X2ZiKCkgZGlmZmVyIHNvIG11Y2ggdGhhdCBpdCdzIHdh eQo+ID4gb3ZlciBteSBoZWFkIHRvIHNlZSBpZiB0aGV5IGNhbiBiZSBjb21iaW5lZC4KPiA+IEhl cmUncyBhbiBvbmxpbmUgZGlmZiBvZiB0aGUgdHdvIGZ1bmN0aW9uczoKPiA+IGh0dHBzOi8vd3d3 LmRpZmZjaGVja2VyLmNvbS9qcWJiYWx1eAo+IAo+IEltbyBudWtlIHRoZSBmYmRldiBvbmUgZW50 aXJlbHkuIElmIGl0IGJyZWFrcyB0aGVuIGl0J3MgZWl0aGVyIGEgYnVnIGluCj4geW91ciBnZW5l cmljIGZiZGVmaW8gY29kZSwgb3IgdGhlIHF4bCAtPmRpcnR5IGltcGxlbWVudGF0aW9uIGhhcyBh IGJ1Zy4gSXQKPiBzaG91bGQgd29yayA7LSkKPiAKPiBPaywgc2xpZ2h0bHkgbW9yZSBzZXJpb3Vz bHkgdGhlIGRpZmZlcmVuY2Ugc2VlbXMgdG8gYmUgdGhhdCB0aGUgZmJkZXYgb25lCj4gc3VwcG9y dCBwYWxldHRlZCBtb2RlIHRvby4gQnV0IHNpbmNlIHF4bCBoYXMgMCBwaXhlbCBmb3JtYXQgY2hl Y2tpbmcKPiBhbnl3aGVyZSBJIGhhdmUgbm8gaWRlYSB3aGV0aGVyIHRoYXQncyBkZWFkIGNvZGUg KGkuZS4gYnJva2VuKSBvciBhY3R1YWxseQo+IHdvcmtpbmcuIEkgZ3Vlc3Mga2VlcGluZyB0aGUg c3BsaXQgaXMgb2ssIGlmIHdlIGFkZCBhIGJpZyBGSVhNRSBjb21tZW50IHRvCj4gaXQgdGhhdCB0 aGlzIGlzIHZlcnkgZmlzaHkuCgpPaywgSSByZWFkIGFyb3VuZCBhIGJpdCBtb3JlLiBUaGUgb25s eSB0aGluZ3MgcXhsIHNlZW1zIHRvIHN1cHBvcnQgYXJlCmJpdHNfcGVyX3BpeGVsIG9mIDEsIDI0 IGFuZCAzMiAoc2VlIHF4bF9pbWFnZV9pbml0X2hlbHBlcikuIEFuZCBkcm0gaGFzIG5vCndheSB0 byBwYXNzIGluIDEgYnBwIGltYWdlcy4gQW5kIGl0IGRvZXNuJ3Qgc3VwcG9ydCA4IGJpdCBwYWxl dHRlZCwgd2hpY2gKaXMgdGhlIG9ubHkgcGFsZXR0ZWQgdGhpbmcgZHJtIHN1cHBvcnRzLgoKU28g aWYgeW91IHRvdGFsbHkgZmVlbCBsaWtlIEkgdGhpbmsgd2UgY291bGQgYWRkIGZvcm1hdCBjaGVj a2luZyBmb3IKRFJNX0ZPUk1BVF9YUkdCODg4OCBhbmQgRFJNX0ZPUk1BVF9SR0I4ODggaW4gcXhs X2ZyYW1lYnVmZmVyX2luaXQgYW5kIHRoZW4KcmlwIG91dCBhbGwgdGhhdCBjb2RlLiBCdXQgdGhh dCdzIGEgZmV3IG1vcmUgcGF0Y2hlcyBhbmQgcHJvYmFibHkgc2hvdWxkCmJlIHRlc3RlZCBhY3R1 YWxseSA7LSkKCkZJWE1FIHBsdXMgZXhwbGFpbmcgaXQgYWxsIGluIHRoZSBjb21taXQgbWVzc2Fn ZSBpcyBmaW5lIHdpdGggbWUgdG9vLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJl IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK