From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747AbcDUHwN (ORCPT ); Thu, 21 Apr 2016 03:52:13 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37832 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbcDUHwM (ORCPT ); Thu, 21 Apr 2016 03:52:12 -0400 Date: Thu, 21 Apr 2016 09:52:07 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] drm/qxl: Use drm_fb_helper deferred_io support Message-ID: <20160421075207.GB2510@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-8-git-send-email-noralf@tronnes.org> <20160420174710.GR2510@phenom.ffwll.local> <5717D2C6.7060806@tronnes.org> <20160421074134.GY2510@phenom.ffwll.local> <20160421074939.GZ2510@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160421074939.GZ2510@phenom.ffwll.local> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2016 at 09:49:39AM +0200, Daniel Vetter wrote: > On Thu, Apr 21, 2016 at 09:41:34AM +0200, Daniel Vetter wrote: > > On Wed, Apr 20, 2016 at 09:04:38PM +0200, Noralf Trønnes wrote: > > > > > > Den 20.04.2016 19:47, skrev Daniel Vetter: > > > >On Wed, Apr 20, 2016 at 05:25:28PM +0200, Noralf Trønnes wrote: > > > >>Use the fbdev deferred io support in drm_fb_helper. > > > >>The (struct fb_ops *)->fb_{fillrect,copyarea,imageblit} functions will > > > >>now be deferred in the same way that mmap damage is, instead of being > > > >>flushed directly. > > > >>This patch has only been compile tested. > > > >> > > > >>Signed-off-by: Noralf Trønnes > > > >>--- > > > >> drivers/gpu/drm/qxl/qxl_display.c | 9 +- > > > >> drivers/gpu/drm/qxl/qxl_drv.h | 7 +- > > > >> drivers/gpu/drm/qxl/qxl_fb.c | 220 ++++++++++---------------------------- > > > >> drivers/gpu/drm/qxl/qxl_kms.c | 4 - > > > >> 4 files changed, 62 insertions(+), 178 deletions(-) > > > >> > > > >>diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c > > > >>index 030409a..9a03524 100644 > > > >>--- a/drivers/gpu/drm/qxl/qxl_display.c > > > >>+++ b/drivers/gpu/drm/qxl/qxl_display.c > > > >>@@ -465,7 +465,7 @@ static const struct drm_crtc_funcs qxl_crtc_funcs = { > > > >> .page_flip = qxl_crtc_page_flip, > > > >> }; > > > >>-static void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb) > > > >>+void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb) > > > >> { > > > >> struct qxl_framebuffer *qxl_fb = to_qxl_framebuffer(fb); > > > >>@@ -527,12 +527,13 @@ int > > > >> qxl_framebuffer_init(struct drm_device *dev, > > > >> struct qxl_framebuffer *qfb, > > > >> const struct drm_mode_fb_cmd2 *mode_cmd, > > > >>- struct drm_gem_object *obj) > > > >>+ struct drm_gem_object *obj, > > > >>+ const struct drm_framebuffer_funcs *funcs) > > > >There should be no need at all to have a separate fb funcs table for the > > > >fbdev fb. Both /should/ be able to use the exact same (already existing) > > > >->dirty() callback. We need this only in CMA because CMA is a midlayer > > > >used by multiple drivers. > > > > > > I don't see how I can avoid it. > > > > > > fbdev framebuffer flushing: > > > > > > static void qxl_fb_dirty_flush(struct fb_info *info) > > > { > > > qxl_fb_image_init(&qxl_fb_image, qdev, info, NULL); > > > qxl_draw_opaque_fb(&qxl_fb_image, stride); > > > } > > > > > > drm framebuffer flushing: > > > > > > static int qxl_framebuffer_surface_dirty(...) > > > { > > > qxl_draw_dirty_fb(...); > > > } > > > > > > qxl_draw_opaque_fb() and qxl_draw_dirty_fb() differ so much that it's way > > > over my head to see if they can be combined. > > > Here's an online diff of the two functions: > > > https://www.diffchecker.com/jqbbalux > > > > Imo nuke the fbdev one entirely. If it breaks then it's either a bug in > > your generic fbdefio code, or the qxl ->dirty implementation has a bug. It > > should work ;-) > > > > Ok, slightly more seriously the difference seems to be that the fbdev one > > support paletted mode too. But since qxl has 0 pixel format checking > > anywhere I have no idea whether that's dead code (i.e. broken) or actually > > working. I guess keeping the split is ok, if we add a big FIXME comment to > > it that this is very fishy. > > Ok, I read around a bit more. The only things qxl seems to support are > bits_per_pixel of 1, 24 and 32 (see qxl_image_init_helper). And drm has no > way to pass in 1 bpp images. And it doesn't support 8 bit paletted, which > is the only paletted thing drm supports. > > So if you totally feel like I think we could add format checking for > DRM_FORMAT_XRGB8888 and DRM_FORMAT_RGB888 in qxl_framebuffer_init and then > rip out all that code. But that's a few more patches and probably should > be tested actually ;-) Even simpler: Check for bits_per_pixel == 24 || 32, since that matches the only other check in qxl. Extremely unlikely qxl supports all these formats, but meh ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Thu, 21 Apr 2016 07:52:07 +0000 Subject: Re: [PATCH 7/8] drm/qxl: Use drm_fb_helper deferred_io support Message-Id: <20160421075207.GB2510@phenom.ffwll.local> List-Id: References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-8-git-send-email-noralf@tronnes.org> <20160420174710.GR2510@phenom.ffwll.local> <5717D2C6.7060806@tronnes.org> <20160421074134.GY2510@phenom.ffwll.local> <20160421074939.GZ2510@phenom.ffwll.local> In-Reply-To: <20160421074939.GZ2510@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org On Thu, Apr 21, 2016 at 09:49:39AM +0200, Daniel Vetter wrote: > On Thu, Apr 21, 2016 at 09:41:34AM +0200, Daniel Vetter wrote: > > On Wed, Apr 20, 2016 at 09:04:38PM +0200, Noralf Tr=F8nnes wrote: > > >=20 > > > Den 20.04.2016 19:47, skrev Daniel Vetter: > > > >On Wed, Apr 20, 2016 at 05:25:28PM +0200, Noralf Tr=F8nnes wrote: > > > >>Use the fbdev deferred io support in drm_fb_helper. > > > >>The (struct fb_ops *)->fb_{fillrect,copyarea,imageblit} functions w= ill > > > >>now be deferred in the same way that mmap damage is, instead of bei= ng > > > >>flushed directly. > > > >>This patch has only been compile tested. > > > >> > > > >>Signed-off-by: Noralf Tr=F8nnes > > > >>--- > > > >> drivers/gpu/drm/qxl/qxl_display.c | 9 +- > > > >> drivers/gpu/drm/qxl/qxl_drv.h | 7 +- > > > >> drivers/gpu/drm/qxl/qxl_fb.c | 220 ++++++++++---------------= ------------- > > > >> drivers/gpu/drm/qxl/qxl_kms.c | 4 - > > > >> 4 files changed, 62 insertions(+), 178 deletions(-) > > > >> > > > >>diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qx= l/qxl_display.c > > > >>index 030409a..9a03524 100644 > > > >>--- a/drivers/gpu/drm/qxl/qxl_display.c > > > >>+++ b/drivers/gpu/drm/qxl/qxl_display.c > > > >>@@ -465,7 +465,7 @@ static const struct drm_crtc_funcs qxl_crtc_fun= cs =3D { > > > >> .page_flip =3D qxl_crtc_page_flip, > > > >> }; > > > >>-static void qxl_user_framebuffer_destroy(struct drm_framebuffer *f= b) > > > >>+void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb) > > > >> { > > > >> struct qxl_framebuffer *qxl_fb =3D to_qxl_framebuffer(fb); > > > >>@@ -527,12 +527,13 @@ int > > > >> qxl_framebuffer_init(struct drm_device *dev, > > > >> struct qxl_framebuffer *qfb, > > > >> const struct drm_mode_fb_cmd2 *mode_cmd, > > > >>- struct drm_gem_object *obj) > > > >>+ struct drm_gem_object *obj, > > > >>+ const struct drm_framebuffer_funcs *funcs) > > > >There should be no need at all to have a separate fb funcs table for= the > > > >fbdev fb. Both /should/ be able to use the exact same (already exist= ing) > > > >->dirty() callback. We need this only in CMA because CMA is a midlay= er > > > >used by multiple drivers. > > >=20 > > > I don't see how I can avoid it. > > >=20 > > > fbdev framebuffer flushing: > > >=20 > > > static void qxl_fb_dirty_flush(struct fb_info *info) > > > { > > > qxl_fb_image_init(&qxl_fb_image, qdev, info, NULL); > > > qxl_draw_opaque_fb(&qxl_fb_image, stride); > > > } > > >=20 > > > drm framebuffer flushing: > > >=20 > > > static int qxl_framebuffer_surface_dirty(...) > > > { > > > qxl_draw_dirty_fb(...); > > > } > > >=20 > > > qxl_draw_opaque_fb() and qxl_draw_dirty_fb() differ so much that it's= way > > > over my head to see if they can be combined. > > > Here's an online diff of the two functions: > > > https://www.diffchecker.com/jqbbalux > >=20 > > Imo nuke the fbdev one entirely. If it breaks then it's either a bug in > > your generic fbdefio code, or the qxl ->dirty implementation has a bug.= It > > should work ;-) > >=20 > > Ok, slightly more seriously the difference seems to be that the fbdev o= ne > > support paletted mode too. But since qxl has 0 pixel format checking > > anywhere I have no idea whether that's dead code (i.e. broken) or actua= lly > > working. I guess keeping the split is ok, if we add a big FIXME comment= to > > it that this is very fishy. >=20 > Ok, I read around a bit more. The only things qxl seems to support are > bits_per_pixel of 1, 24 and 32 (see qxl_image_init_helper). And drm has no > way to pass in 1 bpp images. And it doesn't support 8 bit paletted, which > is the only paletted thing drm supports. >=20 > So if you totally feel like I think we could add format checking for > DRM_FORMAT_XRGB8888 and DRM_FORMAT_RGB888 in qxl_framebuffer_init and then > rip out all that code. But that's a few more patches and probably should > be tested actually ;-) Even simpler: Check for bits_per_pixel =3D 24 || 32, since that matches the only other check in qxl. Extremely unlikely qxl supports all these formats, but meh ... -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 7/8] drm/qxl: Use drm_fb_helper deferred_io support Date: Thu, 21 Apr 2016 09:52:07 +0200 Message-ID: <20160421075207.GB2510@phenom.ffwll.local> References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-8-git-send-email-noralf@tronnes.org> <20160420174710.GR2510@phenom.ffwll.local> <5717D2C6.7060806@tronnes.org> <20160421074134.GY2510@phenom.ffwll.local> <20160421074939.GZ2510@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3EE286EBFF for ; Thu, 21 Apr 2016 07:52:12 +0000 (UTC) Received: by mail-wm0-x236.google.com with SMTP id e201so76461175wme.0 for ; Thu, 21 Apr 2016 00:52:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160421074939.GZ2510@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgMjEsIDIwMTYgYXQgMDk6NDk6MzlBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIEFwciAyMSwgMjAxNiBhdCAwOTo0MTozNEFNICswMjAwLCBEYW5pZWwg VmV0dGVyIHdyb3RlOgo+ID4gT24gV2VkLCBBcHIgMjAsIDIwMTYgYXQgMDk6MDQ6MzhQTSArMDIw MCwgTm9yYWxmIFRyw7hubmVzIHdyb3RlOgo+ID4gPiAKPiA+ID4gRGVuIDIwLjA0LjIwMTYgMTk6 NDcsIHNrcmV2IERhbmllbCBWZXR0ZXI6Cj4gPiA+ID5PbiBXZWQsIEFwciAyMCwgMjAxNiBhdCAw NToyNToyOFBNICswMjAwLCBOb3JhbGYgVHLDuG5uZXMgd3JvdGU6Cj4gPiA+ID4+VXNlIHRoZSBm YmRldiBkZWZlcnJlZCBpbyBzdXBwb3J0IGluIGRybV9mYl9oZWxwZXIuCj4gPiA+ID4+VGhlIChz dHJ1Y3QgZmJfb3BzICopLT5mYl97ZmlsbHJlY3QsY29weWFyZWEsaW1hZ2VibGl0fSBmdW5jdGlv bnMgd2lsbAo+ID4gPiA+Pm5vdyBiZSBkZWZlcnJlZCBpbiB0aGUgc2FtZSB3YXkgdGhhdCBtbWFw IGRhbWFnZSBpcywgaW5zdGVhZCBvZiBiZWluZwo+ID4gPiA+PmZsdXNoZWQgZGlyZWN0bHkuCj4g PiA+ID4+VGhpcyBwYXRjaCBoYXMgb25seSBiZWVuIGNvbXBpbGUgdGVzdGVkLgo+ID4gPiA+Pgo+ ID4gPiA+PlNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3Jn Pgo+ID4gPiA+Pi0tLQo+ID4gPiA+PiAgZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZGlzcGxheS5j IHwgICA5ICstCj4gPiA+ID4+ICBkcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kcnYuaCAgICAgfCAg IDcgKy0KPiA+ID4gPj4gIGRyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2ZiLmMgICAgICB8IDIyMCAr KysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiA+PiAgZHJpdmVycy9n cHUvZHJtL3F4bC9xeGxfa21zLmMgICAgIHwgICA0IC0KPiA+ID4gPj4gIDQgZmlsZXMgY2hhbmdl ZCwgNjIgaW5zZXJ0aW9ucygrKSwgMTc4IGRlbGV0aW9ucygtKQo+ID4gPiA+Pgo+ID4gPiA+PmRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vcXhsL3F4bF9kaXNwbGF5LmMKPiA+ID4gPj5pbmRleCAwMzA0MDlhLi45YTAzNTI0IDEw MDY0NAo+ID4gPiA+Pi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYwo+ID4g PiA+PisrKyBiL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYwo+ID4gPiA+PkBAIC00 NjUsNyArNDY1LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19mdW5jcyBxeGxfY3J0 Y19mdW5jcyA9IHsKPiA+ID4gPj4gIAkucGFnZV9mbGlwID0gcXhsX2NydGNfcGFnZV9mbGlwLAo+ ID4gPiA+PiAgfTsKPiA+ID4gPj4tc3RhdGljIHZvaWQgcXhsX3VzZXJfZnJhbWVidWZmZXJfZGVz dHJveShzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPiA+ID4gPj4rdm9pZCBxeGxfdXNlcl9m cmFtZWJ1ZmZlcl9kZXN0cm95KHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+ID4gPiA+PiAg ewo+ID4gPiA+PiAgCXN0cnVjdCBxeGxfZnJhbWVidWZmZXIgKnF4bF9mYiA9IHRvX3F4bF9mcmFt ZWJ1ZmZlcihmYik7Cj4gPiA+ID4+QEAgLTUyNywxMiArNTI3LDEzIEBAIGludAo+ID4gPiA+PiAg cXhsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ID4gPj4gIAkJ ICAgICBzdHJ1Y3QgcXhsX2ZyYW1lYnVmZmVyICpxZmIsCj4gPiA+ID4+ICAJCSAgICAgY29uc3Qg c3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGVfY21kLAo+ID4gPiA+Pi0JCSAgICAgc3RydWN0 IGRybV9nZW1fb2JqZWN0ICpvYmopCj4gPiA+ID4+KwkJICAgICBzdHJ1Y3QgZHJtX2dlbV9vYmpl Y3QgKm9iaiwKPiA+ID4gPj4rCQkgICAgIGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXJfZnVu Y3MgKmZ1bmNzKQo+ID4gPiA+VGhlcmUgc2hvdWxkIGJlIG5vIG5lZWQgYXQgYWxsIHRvIGhhdmUg YSBzZXBhcmF0ZSBmYiBmdW5jcyB0YWJsZSBmb3IgdGhlCj4gPiA+ID5mYmRldiBmYi4gQm90aCAv c2hvdWxkLyBiZSBhYmxlIHRvIHVzZSB0aGUgZXhhY3Qgc2FtZSAoYWxyZWFkeSBleGlzdGluZykK PiA+ID4gPi0+ZGlydHkoKSBjYWxsYmFjay4gV2UgbmVlZCB0aGlzIG9ubHkgaW4gQ01BIGJlY2F1 c2UgQ01BIGlzIGEgbWlkbGF5ZXIKPiA+ID4gPnVzZWQgYnkgbXVsdGlwbGUgZHJpdmVycy4KPiA+ ID4gCj4gPiA+IEkgZG9uJ3Qgc2VlIGhvdyBJIGNhbiBhdm9pZCBpdC4KPiA+ID4gCj4gPiA+IGZi ZGV2IGZyYW1lYnVmZmVyIGZsdXNoaW5nOgo+ID4gPiAKPiA+ID4gc3RhdGljIHZvaWQgcXhsX2Zi X2RpcnR5X2ZsdXNoKHN0cnVjdCBmYl9pbmZvICppbmZvKQo+ID4gPiB7Cj4gPiA+ICAgICAgICAg cXhsX2ZiX2ltYWdlX2luaXQoJnF4bF9mYl9pbWFnZSwgcWRldiwgaW5mbywgTlVMTCk7Cj4gPiA+ ICAgICAgICAgcXhsX2RyYXdfb3BhcXVlX2ZiKCZxeGxfZmJfaW1hZ2UsIHN0cmlkZSk7Cj4gPiA+ IH0KPiA+ID4gCj4gPiA+IGRybSBmcmFtZWJ1ZmZlciBmbHVzaGluZzoKPiA+ID4gCj4gPiA+IHN0 YXRpYyBpbnQgcXhsX2ZyYW1lYnVmZmVyX3N1cmZhY2VfZGlydHkoLi4uKQo+ID4gPiB7Cj4gPiA+ ICAgICAgICAgcXhsX2RyYXdfZGlydHlfZmIoLi4uKTsKPiA+ID4gfQo+ID4gPiAKPiA+ID4gcXhs X2RyYXdfb3BhcXVlX2ZiKCkgYW5kIHF4bF9kcmF3X2RpcnR5X2ZiKCkgZGlmZmVyIHNvIG11Y2gg dGhhdCBpdCdzIHdheQo+ID4gPiBvdmVyIG15IGhlYWQgdG8gc2VlIGlmIHRoZXkgY2FuIGJlIGNv bWJpbmVkLgo+ID4gPiBIZXJlJ3MgYW4gb25saW5lIGRpZmYgb2YgdGhlIHR3byBmdW5jdGlvbnM6 Cj4gPiA+IGh0dHBzOi8vd3d3LmRpZmZjaGVja2VyLmNvbS9qcWJiYWx1eAo+ID4gCj4gPiBJbW8g bnVrZSB0aGUgZmJkZXYgb25lIGVudGlyZWx5LiBJZiBpdCBicmVha3MgdGhlbiBpdCdzIGVpdGhl ciBhIGJ1ZyBpbgo+ID4geW91ciBnZW5lcmljIGZiZGVmaW8gY29kZSwgb3IgdGhlIHF4bCAtPmRp cnR5IGltcGxlbWVudGF0aW9uIGhhcyBhIGJ1Zy4gSXQKPiA+IHNob3VsZCB3b3JrIDstKQo+ID4g Cj4gPiBPaywgc2xpZ2h0bHkgbW9yZSBzZXJpb3VzbHkgdGhlIGRpZmZlcmVuY2Ugc2VlbXMgdG8g YmUgdGhhdCB0aGUgZmJkZXYgb25lCj4gPiBzdXBwb3J0IHBhbGV0dGVkIG1vZGUgdG9vLiBCdXQg c2luY2UgcXhsIGhhcyAwIHBpeGVsIGZvcm1hdCBjaGVja2luZwo+ID4gYW55d2hlcmUgSSBoYXZl IG5vIGlkZWEgd2hldGhlciB0aGF0J3MgZGVhZCBjb2RlIChpLmUuIGJyb2tlbikgb3IgYWN0dWFs bHkKPiA+IHdvcmtpbmcuIEkgZ3Vlc3Mga2VlcGluZyB0aGUgc3BsaXQgaXMgb2ssIGlmIHdlIGFk ZCBhIGJpZyBGSVhNRSBjb21tZW50IHRvCj4gPiBpdCB0aGF0IHRoaXMgaXMgdmVyeSBmaXNoeS4K PiAKPiBPaywgSSByZWFkIGFyb3VuZCBhIGJpdCBtb3JlLiBUaGUgb25seSB0aGluZ3MgcXhsIHNl ZW1zIHRvIHN1cHBvcnQgYXJlCj4gYml0c19wZXJfcGl4ZWwgb2YgMSwgMjQgYW5kIDMyIChzZWUg cXhsX2ltYWdlX2luaXRfaGVscGVyKS4gQW5kIGRybSBoYXMgbm8KPiB3YXkgdG8gcGFzcyBpbiAx IGJwcCBpbWFnZXMuIEFuZCBpdCBkb2Vzbid0IHN1cHBvcnQgOCBiaXQgcGFsZXR0ZWQsIHdoaWNo Cj4gaXMgdGhlIG9ubHkgcGFsZXR0ZWQgdGhpbmcgZHJtIHN1cHBvcnRzLgo+IAo+IFNvIGlmIHlv dSB0b3RhbGx5IGZlZWwgbGlrZSBJIHRoaW5rIHdlIGNvdWxkIGFkZCBmb3JtYXQgY2hlY2tpbmcg Zm9yCj4gRFJNX0ZPUk1BVF9YUkdCODg4OCBhbmQgRFJNX0ZPUk1BVF9SR0I4ODggaW4gcXhsX2Zy YW1lYnVmZmVyX2luaXQgYW5kIHRoZW4KPiByaXAgb3V0IGFsbCB0aGF0IGNvZGUuIEJ1dCB0aGF0 J3MgYSBmZXcgbW9yZSBwYXRjaGVzIGFuZCBwcm9iYWJseSBzaG91bGQKPiBiZSB0ZXN0ZWQgYWN0 dWFsbHkgOy0pCgpFdmVuIHNpbXBsZXI6IENoZWNrIGZvciBiaXRzX3Blcl9waXhlbCA9PSAyNCB8 fCAzMiwgc2luY2UgdGhhdCBtYXRjaGVzIHRoZQpvbmx5IG90aGVyIGNoZWNrIGluIHF4bC4gRXh0 cmVtZWx5IHVubGlrZWx5IHF4bCBzdXBwb3J0cyBhbGwgdGhlc2UKZm9ybWF0cywgYnV0IG1laCAu Li4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==