From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1atbpm-0006le-OO
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 10:13:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1atbpl-0001Ko-Uv
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 10:13:26 -0400
Date: Fri, 22 Apr 2016 10:13:18 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20160422141318.GD4841@localhost.localdomain>
References: <1461333236-5942-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1461333236-5942-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 for-2.6 0/5] block: Fix assertion
 failure at mirror exit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org

On Fri, Apr 22, 2016 at 09:53:51PM +0800, Fam Zheng wrote:
> v3: 04: Add check in aio_pending. [Kevin]
> 
> I tested this series survives the "snapshot + commit" loop reproducer with both
> bonnie++ and RHEL installation in the guest.
> 
> This supersedes the "virtio: Register host notifier handler as external" patch
> from yesterday.
> 
> The bug was initially reported by Matthew Schumacher as LaunchPad Bug 1570134,
> and nicely bisected by Max Reitz. See patch 2 for the analysis.
> 
> Fam Zheng (5):
>   iohandler: Introduce iohandler_get_aio_context
>   event-notifier: Add "is_external" parameter
>   virtio: Mark host notifiers as external
>   aio-posix: Skip external nodes in aio_dispatch
>   mirror: Workaround for unexpected iohandler events during completion
> 
>  aio-posix.c                   |  8 ++++++--
>  block/mirror.c                |  9 +++++++++
>  hw/usb/ccid-card-emulated.c   |  2 +-
>  hw/virtio/virtio.c            |  8 ++++----
>  include/qemu/event_notifier.h |  4 +++-
>  include/qemu/main-loop.h      |  1 +
>  iohandler.c                   |  6 ++++++
>  stubs/Makefile.objs           |  1 +
>  stubs/iohandler.c             |  8 ++++++++
>  stubs/set-fd-handler.c        | 10 ++++++++++
>  target-i386/hyperv.c          |  6 +++---
>  util/event_notifier-posix.c   |  4 +++-
>  util/event_notifier-win32.c   |  1 +
>  13 files changed, 56 insertions(+), 12 deletions(-)
>  create mode 100644 stubs/iohandler.c
> 
> -- 
> 2.8.0
> 

Patches 4,5: Reviewed-by: Jeff Cody <jcody@redhat.com>