From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: Tejun Heo Date: Fri, 22 Apr 2016 15:32:21 -0400 From: Tejun Heo To: Paolo Valente Cc: Jens Axboe , Fabio Checconi , Arianna Avanzini , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, broonie@kernel.org Subject: Re: [PATCH RFC 10/22] block, bfq: add full hierarchical scheduling and cgroups support Message-ID: <20160422193221.GY7822@mtj.duckdns.org> References: <1454364778-25179-1-git-send-email-paolo.valente@linaro.org> <1454364778-25179-11-git-send-email-paolo.valente@linaro.org> <20160211222824.GD3741@mtj.duckdns.org> <57174CA7.5000706@linaro.org> <20160422181321.GV7822@mtj.duckdns.org> <20160422184110.GX7822@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: List-ID: Hello, Paolo. On Fri, Apr 22, 2016 at 09:05:14PM +0200, Paolo Valente wrote: > > Ah, right, I was confused. cic is always associated with the task and > > yes a writeback worker can trigger blkcg changed events frequently as > > it walks through different cgroups. Is this an issue? > > That’s exactly the source of my confusion: why does the worker walk > through different cgroups all the time if the I/O is originated by > the same process, which never changes group? Because the workqueue workers aren't tied to individual workqueues, they wander around serving different workqueues. This might change if we eventually update workqueues to be cgroup aware but for now it's expected to happen. Thanks. -- tejun