From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 4/4] eal: add assert macro for debug
Date: Fri, 22 Apr 2016 12:51:10 -0700
Message-ID: <20160422195110.GE7603@yliu-dev.sh.intel.com>
References: <1461332640-24273-1-git-send-email-thomas.monjalon@6wind.com>
 <1461332640-24273-5-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 767E82BD4
 for <dev@dpdk.org>; Fri, 22 Apr 2016 21:49:32 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1461332640-24273-5-git-send-email-thomas.monjalon@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Apr 22, 2016 at 03:44:00PM +0200, Thomas Monjalon wrote:
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/v=
mxnet3_rxtx.c
> index 4ac0456..b7486cd 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -296,7 +296,7 @@ vmxnet3_unmap_pkt(uint16_t eop_idx, vmxnet3_tx_queu=
e_t *txq)
>  	struct rte_mbuf *mbuf;
> =20
>  	/* Release cmd_ring descriptor and free mbuf */
> -	VMXNET3_ASSERT(txq->cmd_ring.base[eop_idx].txd.eop =3D=3D 1);
> +	RTE_ASSERT(txq->cmd_ring.base[eop_idx].txd.eop =3D=3D 1);
> =20
>  	mbuf =3D txq->cmd_ring.buf_info[eop_idx].m;
>  	if (mbuf =3D=3D NULL)
> @@ -307,7 +307,7 @@ vmxnet3_unmap_pkt(uint16_t eop_idx, vmxnet3_tx_queu=
e_t *txq)
> =20
>  	while (txq->cmd_ring.next2comp !=3D eop_idx) {
>  		/* no out-of-order completion */
> -		VMXNET3_ASSERT(txq->cmd_ring.base[txq->cmd_ring.next2comp].txd.cq =3D=
=3D 0);
> +		RTE_ASSERT(txq->cmd_ring.base[txq->cmd_ring.next2comp].txd.cq =3D=3D=
 0);
>  		vmxnet3_cmd_ring_adv_next2comp(&txq->cmd_ring);
>  		completed++;
>  	}
> @@ -454,7 +454,7 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf *=
*tx_pkts,
>  		if (tso) {
>  			uint16_t mss =3D txm->tso_segsz;
> =20
> -			VMXNET3_ASSERT(mss > 0);
> +			RTE_ASSERT(mss > 0);
> =20
>  			gdesc->txd.hlen =3D txm->l2_len + txm->l3_len + txm->l4_len;
>  			gdesc->txd.om =3D VMXNET3_OM_TSO;
> @@ -662,8 +662,8 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf *=
*rx_pkts, uint16_t nb_pkts)
> =20
>  		PMD_RX_LOG(DEBUG, "rxd idx: %d ring idx: %d.", idx, ring_idx);
> =20
> -		VMXNET3_ASSERT(rcd->len <=3D rxd->len);
> -		VMXNET3_ASSERT(rbi->m);
> +		RTE_ASSERT(rcd->len <=3D rxd->len);
> +		RTE_ASSERT(rbi->m);
> =20


Seems this piece of code introduces a build error:

    drivers/net/vmxnet3/vmxnet3_rxtx.c: In function =E2=80=98vmxnet3_recv=
_pkts=E2=80=99:
    drivers/net/vmxnet3/vmxnet3_rxtx.c:635:18: error: variable =E2=80=98r=
xd=E2=80=99 set but not used [-Werror=3Dunused-but-set-variable]
      Vmxnet3_RxDesc *rxd;
                      ^
    cc1: all warnings being treated as errors
    make[6]: *** [vmxnet3_rxtx.o] Error 1


	--yliu