All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cam Hutchison <camh@xdna.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
Date: Sat, 23 Apr 2016 07:41:56 +1000	[thread overview]
Message-ID: <20160422214156.GA2816@xdna.net> (raw)
In-Reply-To: <20160422115129.4c4b523b@free-electrons.com>

Thomas Petazzoni wrote:
> Hello,
> 
> On Fri, 22 Apr 2016 11:09:50 +1000, Cam Hutchison wrote:
> 
> > [leaving and using host-go-bootstrap in its BUILDDIR]
> 
> We normally try to not use things from the build directory of package A
> when building package B. 

I agree that it is not ideal to reach into the builddir of another
package. Ludovic Guegan implemented an alternative where the host-golang
package encapsulated the bootstrap compiler rather than using a separate
package. This makes some sense since the bootstrap compiler is purely
internal to the build of the go compiler.

But the implementation meant that extraction and build of the bootstrap
compiler was just replicaing what buildroot already does and gave less
control (you couldn't run "make host-go-bootstrap-build" for example),
which made it more tedious to iterate some change I was trying.

A separate go-bootstrap package makes better use of buildroot's
infrastructure.

> However, back to your original problem, I don't really see why the fact
> that host-go-bootstrap is installed in $(HOST_DIR) prevents you from
> installing the toolchain system-wide for use by other builds. Yes, it
> increases the size of the host directory, but other than that I don't
> see the technical limitation.

With two go compiler installed in the host dir, it becomes possible for
someone to use the wrong one. Since the sources are also installed in
the host dir, two sets of sources - one older than the other - will be
installed. That's annoying when you want to index it (ctags, etc) for
easy navigation. Having both full compilers (one completely unncessary)
just feels like laying a land mine.

When it is just the outputdir, I don't mind so much but when installed
system-wide, I'm usually quite careful about what gets installed.

I could also just delete it in a post-install script. But not doing
something is better than doing it and undoing it.

Perhaps this is just all personal preference, in which case I'll
maintain a local patch. I'm happy that go has made it into buildroot.

  reply	other threads:[~2016-04-22 21:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 19:31 [Buildroot] [PATCH v3 0/3] Add go language support Geoff Levand
2016-04-04 19:31 ` [Buildroot] [PATCH v3 3/3] flannel: new package Geoff Levand
2016-04-20 21:03   ` Thomas Petazzoni
2016-04-04 19:31 ` [Buildroot] [PATCH v3 2/3] go: new host package Geoff Levand
2016-04-20 21:03   ` Thomas Petazzoni
2016-04-04 19:31 ` [Buildroot] [PATCH v3 1/3] go-bootstrap: " Geoff Levand
2016-04-20 21:02   ` Thomas Petazzoni
2016-04-22  1:09     ` Cam Hutchison
2016-04-22  9:51       ` Thomas Petazzoni
2016-04-22 21:41         ` Cam Hutchison [this message]
2016-04-22 21:49           ` Thomas Petazzoni
2016-04-23  8:34             ` Peter Korsgaard
2016-04-06  5:05 ` [Buildroot] [PATCH v3 0/3] Add go language support Christian Stewart
2016-04-06 16:23   ` Geoff Levand
2016-04-21 20:43 ` Thomas Petazzoni
2016-04-25 16:27   ` Geoff Levand
2016-04-29 21:26   ` Geoff Levand
2016-04-30 12:03     ` Thomas Petazzoni
2016-05-01  3:43       ` Christian Stewart
2016-05-02 16:37         ` Geoff Levand
2016-05-03  7:08           ` Thomas Petazzoni
2016-05-06 19:57             ` Geoff Levand
2016-05-06 19:58               ` Geoff Levand
2016-05-07 23:48                 ` Arnout Vandecappelle
2016-05-02 16:21       ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160422214156.GA2816@xdna.net \
    --to=camh@xdna.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.