From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 24 Apr 2016 12:20:50 +0200 Subject: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives In-Reply-To: <1461099580-3866-14-git-send-email-swarren@wwwdotorg.org> References: <1461099580-3866-1-git-send-email-swarren@wwwdotorg.org> <1461099580-3866-14-git-send-email-swarren@wwwdotorg.org> Message-ID: <20160424102050.AD0C110028B@atlas.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephen, In message <1461099580-3866-14-git-send-email-swarren@wwwdotorg.org> you wrote: > > --- a/board/avionic-design/common/tamonten-ng.c > +++ b/board/avionic-design/common/tamonten-ng.c > @@ -1,18 +1,19 @@ > /* > * (C) Copyright 2013 > * Avionic Design GmbH > + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. > * > * SPDX-License-Identifier: GPL-2.0+ > */ > > #include > #include > +#include > +#include > #include > #include > #include > -#include > #include "pinmux-config-tamonten-ng.h" > -#include > > #define PMU_I2C_ADDRESS 0x2D > Do you really think that moving around two lines of code is a big enough creative achievement to justify adding a copyright note on it? And even with "All rights reserved."? I stop reviewing this patch set here. I'm sorry, but I really dislike the way how it - intentionally or unintentionally - appears to be driven by the attempt to increase Nvidias presence in copyright claims. This seems not fair to me, and I would like to ask you to rework this whole patch set and be a little less aggressive in copyright claims. Thanks in advance. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de What is tolerance? -- it is the consequence of humanity. We are all formed of frailty and error; let us pardon reciprocally each other's folly -- that is the first law of nature. - Voltaire