From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbcDYJSL (ORCPT ); Mon, 25 Apr 2016 05:18:11 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56439 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbcDYJSJ (ORCPT ); Mon, 25 Apr 2016 05:18:09 -0400 Date: Mon, 25 Apr 2016 11:18:05 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: tony.luck@intel.com, ravi.v.shankar@intel.com, fenghua.yu@intel.com, vikas.shivappa@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, h.peter.anvin@intel.com Subject: Re: [PATCH 4/4] perf/x86/cqm: Support cqm/mbm only for perf events Message-ID: <20160425091805.GG3430@twins.programming.kicks-ass.net> References: <1461371241-4258-1-git-send-email-vikas.shivappa@linux.intel.com> <1461371241-4258-5-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461371241-4258-5-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2016 at 05:27:21PM -0700, Vikas Shivappa wrote: > The cgroup support for cqm is broken. Instead of mapping RMID to a > cgroup currently its mapped to the task and then hence when task moves > cgroup we get incorrect count. > > Also the conflict handling code which is meant to handle the case of > co-existing cgroup and task events, is broken. It reports very > confusing numbers of intermittent zero and some occupancy when perf is > run with cgroup and task events. > > Hence removing support for the parts which are broken rather than > pretending to support it and giving incorrect data. Uh what, how about attempt to fix it?